vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   New Posting Features - Photo Popup - Insert pictures easily from vB Albums, Photopost, vBGallery, Photoplog (https://vborg.vbsupport.ru/showthread.php?t=202385)

RvG2 01-23-2009 01:36 AM

honestly speaking, this should be built in on next release.

RvG2 01-23-2009 01:39 AM

Quote:

Originally Posted by cellarius (Post 1721421)
Did you read what I wrote in the posting just above yours? There is no conflict that I can see. As I interpret it, both mods do what they were designed for. You do not have to use linked insertions with the popup. Just offer unlinked insertions instead. If I get your issues wrong, please elaborate. At the moment I don't see a conflict, so I won't do anything about it.

Even so, I don't think there is anything I could do. You would have to take this issue to the author of the other mod. My mod inserts just plain bb-Code for images and links. If you insert the same by hand or with the editor, you would have exactly the same issues. There is nothing wrong with this mod.

actually I disabled the image resizer and used yours :)

cellarius 01-23-2009 04:25 AM

Quote:

Originally Posted by smirkley (Post 1721557)
Maybe if thismod allowed or allowed the option of a small 'click to see image' link, or 'click to view album' link, would be placed immediatly below the image.

This way the resizer will still be functional, as well as the clickability would also be available, for those that wish it to appear.

Just thinking outloud for solutions.

And a good thing it is you do! That really might be an option. This would be a one image per line only option, probably centered, with a small link under the image; something like medium_link_2_gallery_below ;)

There just might be another release in the pipe :D

Quote:

Originally Posted by rolandogomez (Post 1721677)
Nice mod. Added the code,

Code:

<td class="smallfont" colspan="$vboptions[smcolumns]">
                      [<a href="#" onclick="window.open('photo_popup.php','fotos','scrollbars=yes,resizable=yes,width={$vbulletin->options['photo_popup_width']},height={$vbulletin->options['photo_popup_heigth']}'); return false" title="$vbphrase[photo_popup_insertlink]">$vbphrase[photo_popup_insert]</a>]</td>
            </td>

in the showthread_quickreply template, and though you see the link and it pops out and the pop-out box works perfectly, when I click on a thumb, it doesn't insert the code. It does just fine in the regular reply box. Any ideas? Sounds java script related. Would like this on the quick reply box too so the user doesn't always have to go advanced. Thanks, rg

It is javascript related. The names/ids of the editor windows are different for quickreply, so js sends the code to nirwana. I'll have a look into it to see if I can handle this.

Quote:

Originally Posted by smirkley (Post 1721784)
quick bug question,...

I noticed on my install, when the popup shows, the paginator shows the number of pages required to list all the images within all of my vb album images, but each page number, when clicked on, shows ALL of the images, with the proper number of columns defined in acp, but with enough rows to show ALL the images in ALL gallaries.

When selecting an individual album, it does sort through and show the proper images, but still with no regard to the number of rows as defined in the acp settings.

No, sorry, I can't reproduce this here. Please tell me what your exact settings in AdminCP for rows and colums are, so I can try them. Anybody else have this issue?

Quote:

Originally Posted by RvG2 (Post 1721796)
actually I disabled the image resizer and used yours :)

:D:D:D

CrashfAB 01-23-2009 04:25 AM

I installed it--and it didn't work. But I also have myh smile box below the area you type so I assumed that was the issue and it was. It was just a matter of relocating the added code to the proper location--and It works great.. Thank you for this ;)

cellarius 01-23-2009 09:03 AM

Version 1.4:

For better use with Resize Image-Mod: Added 3 new insert-options:
  • thumb_2_gallery_link_below
  • med_2_gallery_link_below
  • orig_2_gallery_link_below
What they do on the front should be quite obvious: They insert the image in the choosen size and add a link to the gallery below. The image is inserted centered and with two line breaks below (resulting in one free line after the link). The link text is - as always - phrased, and it can contain bbcode to style the link. Default is: [size="1"]View image in gallery[/size]. If you want, make it bigger, color it, make it bold. Whatever.

Drawback: This way, you are limited to one image per line. There is no way that I am aware of that would enable you to group image and link.


Concerning use with QR (and inline) editors:
Sorry, apparently I can't figure it out at the moment, although it should be quite straightforward. It's no problem to tell the popup from which editor it is called (standard, quick-reply, or even inline). It looks like I'm adressing the editor correctly, too, since the auto-close on submit works fine with QR and inline editors - but that's not what we want, is it? A popup that does nothing but properly close at the right moment :( As it is, the injection method used by this mod does not seem to work with QR and inline editors. At least not until I find out where I'm wrong.

BTW: Let me say thanks for all the suggestions and bug-alerts you made. I think, it's a pretty good and functional product by now :D

Rene Kriest 01-23-2009 09:41 AM

Quote:

Originally Posted by cellarius (Post 1722086)
BTW: Let me say thanks for all the suggestions and bug-alerts you made. I think, it's a pretty good and functional product by now :D

Well, it kinda rocks! :D

RvG2 01-23-2009 12:56 PM

the 3 new sizes are not showing in the dropdown menus. also the version has not changed also still at 1.3

cellarius 01-23-2009 01:46 PM

1 Attachment(s)
Quote:

Originally Posted by RvG2 (Post 1722330)
the 3 new sizes are not showing in the dropdown menus. also the version has not changed also still at 1.3

Did you add them in AdminCP? If you don't, they won't show.

Edit: Yes, I forgot to change the product version. Uploading new .zip now. Product file with corrected verson attached for those who want to get it right, but it's really just the number.

RvG2 01-23-2009 01:47 PM

ah ok... :D

vbboarder 01-23-2009 02:54 PM

Thanks for this cool mod and the fast updates - nominated for MOTM! :D

RvG2 01-23-2009 03:28 PM

nominated for MOTM also :)

yotsume 01-23-2009 03:35 PM

Ok now were talking! thanks for the updates! The new options for having the link back to the album or gallery below is a nice workaround to the resize mod issue. Very slick!!!

wottech 01-23-2009 04:40 PM

Although I haven't updated the following mod to the most recent version, I figured out your template edit doesn't work with the following hack :https://vborg.vbsupport.ru/showthread.php?t=180330

If I disable the Full Quick Reply, then the box shows up in the editor. With the hack enabled, nothing shows up. I will try updating Full Quick Reply to the most recent (currently running v1.0) tonight to see if it changes anything.

I'm looking into how to make this work with vbGallery as well as CND Garage mods as well.

Deviant K1 01-23-2009 04:46 PM

*** MARKED INSTALLED ***

Thanks for this hack!:D

Installed it and it works great!

Totally APPRECIATED!!!:D:)

Andreas 01-23-2009 05:14 PM

Feature request:

Support for PhotoPlog and PhotoPost vBGallery (we do not use PhotoPost any longer) - that would be great :)

cellarius 01-23-2009 05:25 PM

Quote:

Originally Posted by Andreas (Post 1722552)
Feature request:

Support for PhotoPlog and PhotoPost vBGallery (we do not use PhotoPost any longer) - that would be great :)

If I had access to either, I'd probably do it - but since I don't, I can't. I was looking into PhotoPlog myself some time ago as a replacement for Photopost, but I wouldn't use it as it does not resize the images on upload. Can't have hundreds and thousands of 10 and 12 Megapixel photos on my server :D Now I've decided to wait for the albums system to ripen.

Concerning Photoplog: There is a light version, no? I might install it and have a look. I gather database stucture is the same with the pro version?

BTW - You'll have a PN in a minute.

mfowler70 01-23-2009 05:35 PM

Upgraded from 1.2 to 1.4

Only problem is the popup doesn't close, neither automatically when image is inserted or when post is submitted. Close on submit worked prior to upgrading.

Andreas 01-23-2009 05:47 PM

PhotoPlog Pro (dunno for the light version) does resize images - it offers 3 sizes, small, medium and normal.

cellarius 01-23-2009 06:02 PM

mfowler, you just might have become my personal hero. Your bug report is absolutely justified, a stupid typo in the template. But this typo made me look at the javascript code once again - and it looks that I just may have figured out my problem with QR.

Just wait a little bit longer - there might be a major update in the pipeline. I think the integration of QR and inline editors may be worthy of 2.0 :)

cellarius 01-23-2009 06:03 PM

Quote:

Originally Posted by Andreas (Post 1722575)
PhotoPlog Pro (dunno for the light version) does resize images - it offers 3 sizes, small, medium and normal.

Ah yes? I thought - and so Morgan told me - it always saved the original image along with the resized versions :confused:

mfowler70 01-23-2009 06:06 PM

awesome!

wottech 01-23-2009 07:03 PM

Quote:

Originally Posted by cellarius (Post 1722555)
If I had access to either, I'd probably do it - but since I don't, I can't. I was looking into PhotoPlog myself some time ago as a replacement for Photopost, but I wouldn't use it as it does not resize the images on upload. Can't have hundreds and thousands of 10 and 12 Megapixel photos on my server :D Now I've decided to wait for the albums system to ripen.

Concerning Photoplog: There is a light version, no? I might install it and have a look. I gather database stucture is the same with the pro version?

BTW - You'll have a PN in a minute.

If you have a current active Photopost license, then you have access to vbGallery, as they are both included in a single license now. Not sure when this happened, so if you haven't renewed your license recently, you may not have access to vbGallery. I was looking at it the other day, as I wanted to upgrade my current version ofvbGallery and found out I have to buy a Photopost license to get vbGallery now.

cellarius 01-23-2009 07:48 PM

1 Attachment(s)
Version 2.0

As requested: Mod now fully supports quickreply and quickedit editors. Popup is called by means of a toolbar button. A fitting png icon, taken from the silk icon set, is included in the package.

Please note: For update to 2.0 it is mandatory to redo template changes. The information which editor is used is transported by url-parameter and will be missing otherwise.

Enjoy!

By the way: Thanks for Mod of the month nominations! Should anyone else feel inspired to click that button, don't let yourself be stopped ;)

Rene Kriest 01-23-2009 08:46 PM

Finally we arrived at V2 - great. Your mod is a-w-e-s-o-m-e and should be a standard feature.

The addon debugger went on while I was testing the previously released v1.4. Gonna post the main part of its report here:

Code
HTML Code:

<a href="#" onclick="thumbpaste('<a href=\'http://forum.depressionsblog.com/picture.php?albumid=34&amp;pictureid=294\'><img src=\'http://forum.depressionsblog.com/picture.php?albumid=34&amp;pictureid=294&amp;thumb=1\' style=\'border: 0\' /></a> ','[url=\'http://forum.depressionsblog.com/picture.php?albumid=34&amp;pictureid=294\'][img]http://forum.depressionsblog.com/picture.php?albumid=34&amp;pictureid=294&amp;thumb=1[/img][/url] ')"><img src="http://forum.depressionsblog.com/picture.php?albumid=34&amp;pictureid=294&amp;thumb=1" style="border: 0" title=""/></a>
Link to Original
HTML Code:

http://forum.depressionsblog.com/picture.php?albumid=34&pictureid=294
Link to Thumb
HTML Code:

http://forum.depressionsblog.com/picture.php?albumid=34&pictureid=294&thumb=1
Insert options
HTML Code:

link_thumb_2_orig link_thumb_2_gallery thumb orig
Query    SELECT pictureid, albumpicture.albumid FROM albumpicture INNER JOIN album ON albumpicture.albumid = album.albumid WHERE userid = 1 AND albumpicture.albumid = 34

I just played around with your addon after upgrading to v1.4. I went to my testforum and clicked around the images to be inserted. Afted that I noticed that a <a> tag was wrongly set.

No serious problem for you I believe. :)

smirkley 01-23-2009 08:54 PM

Quote:

Originally Posted by cellarius (Post 1721926)
No, sorry, I can't reproduce this here. Please tell me what your exact settings in AdminCP for rows and colums are, so I can try them. Anybody else have this issue?


Originally, used the default of three and three for rows and columns, but have also tried three colums and four rows, seems like any row setting is ignored and it shows as many rows as needed to show all images in all albums, or will show all images in selected albums disregarding the number of rows selected to show. (although it does in fact filter album images selected by album name properly)

I will try to do a reinstall when I get home later, and let you know, but I did do an xml overwrite last night with the same resuts.

(still using v1.3 atm, fyi)

Thanks again

cellarius 01-23-2009 08:54 PM

@ Rene Kriest:

Hm, I might be missing my night vision goggles ;) - but where do you see an <a> tag that is wrong?

The Code seems perfectly alright to me. Do you have any issues?

vbboarder 01-23-2009 09:04 PM

Yeah :D, support for quick reply & quick edit - thanks for the update!

Does this work with PHPKD's advanced quick reply & quick edit mods?

Rene Kriest 01-23-2009 09:10 PM

@cellarius
I inserted 2 pics with different options ("linked to orig" and "original" I think). The addons doesn't handle the posting this way. What the addon does not check seems to be spaces.

When I tell the addon to insert pic 1 with option a and insert pic 2 with option b I would like to see the pictures be handled this way in my posting but the result was that you could press on either pic 1 or 2 with the same result.

Now with 2.0 I habe the following: I inserted a pic with "thumbnail, linked to original" option first thing in my new posting. After that I started typing text in the text field beside the picture but the [URL]-bbcode is still open so that the text is going to be shown as a link.

Rene Kriest 01-23-2009 09:19 PM

Quote:

Originally Posted by cellarius (Post 1722730)
where do you see an <a> tag that is wrong?

The Code seems perfectly alright to me. Do you have any issues?

No, have a closer look at the source that vb produces not the debugger to make it clear:

HTML Code:

<a href="http://forum.depressionsblog.com/picture.php?albumid=1&amp;pictureid=3" target="_blank"><img src="http://forum.depressionsblog.com/picture.php?albumid=1&amp;pictureid=3&amp;thumb=1" border="0" alt="" class="tcattdimgresizer" onload="NcodeImageResizer.createOn(this);" /><img src="http://forum.depressionsblog.com/picture.php?albumid=34&amp;pictureid=308" border="0" alt="" class="tcattdimgresizer" onload="NcodeImageResizer.createOn(this);" /> </a>
There is a </a> missing, isn't it? ;)

wottech 01-23-2009 10:19 PM

The </a> appears to be at the end of your quote, so it doesn't appear to be missing to me.

mfowler70 01-23-2009 10:36 PM

Working great. Nominated.

The popup doesn't close for me on picture insert, but it closes on post so I'm content.

Now if you could just make "link to original" open in lightbox instead of a new window, this would be golden. :)

Rene Kriest 01-23-2009 11:22 PM

Quote:

Originally Posted by wottech (Post 1722792)
The </a> appears to be at the end of your quote, so it doesn't appear to be missing to me.

Well then have a look at the 2 (!) img tags then.

Mukashi 01-23-2009 11:26 PM

The addons seems to conflict with the Quick Editor Improver by Sunrise2006. Having said that, I've uninstalled that mod for now in favor of this one. Much more useful functionality.

Rene Kriest 01-23-2009 11:27 PM

Suggestion: Could you put in an option to paste the code to the clipboard without pasting it to the board?

Your addon is so handy and that would make it even more valueable to designers.

wottech 01-24-2009 12:34 AM

Quote:

Originally Posted by vbboarder (Post 1722736)
Yeah :D, support for quick reply & quick edit - thanks for the update!

Does this work with PHPKD's advanced quick reply & quick edit mods?

I determined that to make it work to Advanced Quick Reply, just make the template edits to the Advanced Quick Reply templates of the same name. The only issue I see is that on the quick reply, both the button and the fieldset box are displayed.

wottech 01-24-2009 12:36 AM

Quote:

Originally Posted by smirkley (Post 1722729)
Originally, used the default of three and three for rows and columns, but have also tried three colums and four rows, seems like any row setting is ignored and it shows as many rows as needed to show all images in all albums, or will show all images in selected albums disregarding the number of rows selected to show. (although it does in fact filter album images selected by album name properly)

I will try to do a reinstall when I get home later, and let you know, but I did do an xml overwrite last night with the same resuts.

(still using v1.3 atm, fyi)

Thanks again

I have this same issue. It shows the pagination, yet it still ends up displaying more rows than are in the ACP settings. I am using FireFox (running on Linux) if that makes a difference...

RvG2 01-24-2009 01:29 AM

cellarius, thank you for working hard on this. :D recommended!!!

smirkley 01-24-2009 03:31 AM

I use IE6 and IE7 in different networks.

cellarius 01-24-2009 06:20 AM

1 Attachment(s)
If you have problems with table building, please upload the attached file for extended debugging and provide the information for Photo Popup Settings and Table building.

If you're using an old version, please upgrade. This is the 2.0 file version, so use this download only if you are sure that your product is up to date.

Perhaps a deinstall/reinstall might help. I'll update the product zip in a minute.

cellarius 01-24-2009 06:49 AM

Quote:

Originally Posted by Rene Kriest (Post 1722748)
No, have a closer look at the source that vb produces not the debugger to make it clear:

HTML Code:

<a href="http://forum.depressionsblog.com/picture.php?albumid=1&amp;pictureid=3" target="_blank"><img src="http://forum.depressionsblog.com/picture.php?albumid=1&amp;pictureid=3&amp;thumb=1" border="0" alt="" class="tcattdimgresizer" onload="NcodeImageResizer.createOn(this);" /><img src="http://forum.depressionsblog.com/picture.php?albumid=34&amp;pictureid=308" border="0" alt="" class="tcattdimgresizer" onload="NcodeImageResizer.createOn(this);" /> </a>
There is a </a> missing, isn't it? ;)

Quote:

Originally Posted by wottech (Post 1722792)
The </a> appears to be at the end of your quote, so it doesn't appear to be missing to me.

Quote:

Originally Posted by Rene Kriest (Post 1722821)
Well then have a look at the 2 (!) img tags then.

Let's see.

First: Where exactly does that code come from? Is this from your html source code in the browser? This is different from what you posted in your earlier post: There you posted from the debug informations of my mod. I could not find an issue there.

What I see here is html source code. While my mod indeed inserts html code into the wysiwyg-editor, you normally do not get to see it - the editor immediately transforms it to the image. If you change to standard mode, you'll see bbcode.

Now: To get things straight, you are trying to insert two images. The first one, so I gather from the code, is a thumb linked to original image. The second one is a original image. Whether this was linked originally, I don't know.

What I do see is that some other mod has tampered with the links
HTML Code:

(onload="NcodeImageResizer.createOn(this);)
is definitely nothing my mod does to a link. As stated before: My mod does nothing but to insert straightforward bbcode. I just checked once again, the code inserted is proper. All opening and closing tags are where they are supposed to be. As long as they are not missing in the code you see in the debug section, they are there upon insertion. Whatever this other mod does, I do not know. I gather that the other problem you described with the link not closed after insertion on your other post is the same issue.

To make sure: Please deactivate the other mod and try then.


All times are GMT. The time now is 12:46 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02277 seconds
  • Memory Usage 1,863KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (7)bbcode_html_printable
  • (18)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete