vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.7 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=228)
-   -   Add-On Releases - vBulletin-Glossary (https://vborg.vbsupport.ru/showthread.php?t=188189)

Keyser Soze 08-17-2008 07:39 AM

The next bug:
If you choose a certain letter from the "alphabet-table" within a certain category, the pagination is wrong. You are displaying the pagination for the whole category and not for a certain letter.

dreads 08-17-2008 08:09 AM

gonna install when i get home

thanks

Keyser Soze 08-17-2008 10:22 AM

Next bug:
This addon is incompatible with the following addon: vBaffiliate Links (see attached image)

Vossi 08-17-2008 11:07 AM

That doesnt have anything to with this addon being incompatible to vBaffiliate Links but is a logical thought when you know about the fact, that vBaffiliate Links forces his replace-routine on the global_start-hook. In this way the routines breaks everything coming along.

Using the global_start-hook for such a routine ain't good at all, actually we actually use the parser-hooks where those linking-routines belong to. We are not responsible for other peoples fault.

Keyser Soze 08-17-2008 11:36 AM

Yes, you are right. I also noticed this a few minutes ago. I fixed the problem by removing all "vBaffilialized" words from glossary descriptions.

Another question:
Why are you replacing the letters from A to Z with their html-entities in the link-texts (function "cb" in functions_vbglossar.php)?

Keyser Soze 08-17-2008 11:43 AM

The last part of the navbar-breadcrumb seems to be a little bit confusing. Currently it looks like this in the category-view:
Code:

-- Forum Title -> Lexikon -> Kategorie-Name
 '-> Kategorie anzeigen

but I would suggest to change it to
Code:

-- Forum Title -> Lexikon
 '-> Kategorie-Name

...and likewise for the showentry-view (removing "Eintrag anzeigen")

G?rome 08-17-2008 02:10 PM

Quote:

Originally Posted by Keyser Soze (Post 1600661)
Why are you replacing the letters from A to Z with their html-entities in the link-texts (function "cb" in functions_vbglossar.php)?

It was the most easy way to avoid recursions while retaining the speed of the crosslinking-module. This approach ensures that already patched text will not be patched again.


G?rome

Keyser Soze 08-17-2008 02:15 PM

Important Security Issue: Googlebot is able to create glossary-entries!
I have noticed that "unregistered" users with the IPs 66.249.71.26 and 66.249.71.25 have been able to create numerous new Glossary entries. These entries don't have a name and no description, but they do exist in my database.
No I am asking myself:
1.) Why is it possible that unregisterd users are able to create new entries and insert data into mysql, even if I disallowed the guest-usergroup to create new entries?
2.) Why is it possible to create new entries with an empty title and description, no matter if we are talking about registered or unregistered users?

As long as these questions are not answered, I would advise everyone who is reading this to disable this addon immediately and to no longer make it avaible for download here as long as this security issue is not fixed.

Keyser Soze 08-17-2008 02:45 PM

Quote:

Originally Posted by G?rome (Post 1600732)
It was the most easy way to avoid recursions while retaining the speed of the crosslinking-module. This approach ensures that already patched text will not be patched again.

Ok. I just thought that these html-entitities might not be the best solution for SEO purposes.

G?rome 08-17-2008 02:58 PM

Quote:

Originally Posted by Keyser Soze (Post 1600759)
Ok. I just thought that these html-entitities might not be the best solution for SEO purposes.

Why? Bots do translate them back as well as browsers do.

Vossi 08-17-2008 03:21 PM

Gérome just released Version 1.0.0 PL 1, users and guests cannot write unwanted entries anmore. Just upload all files to your server again (with overwrite), import the product and that's it.

There hasn't been any serious risk, everybody can calm down now.

abdelghani68 08-17-2008 06:32 PM

Thanks for this hack.

I don't see the sub sub-categorie in the admin cp.

can you help me please

thanks

Dr. Bantham 08-17-2008 06:34 PM

Quote:

Originally Posted by Dr. Bantham (Post 1600038)
Wonderful mod! MOTM quality, IMHO!

I only have one issue thus far. The crosslinking feature can hijack portions of existing links. It should be disabled if the text is within an existing link. This can be witnessed in the link below, where the portion of the previous link (The Shadow at the Bottom of the World) has a link to the glossary. Notice that the first segment of the text (Thomas Ligotti - ") still refers to the original link. Also note that the closing quotation mark has been stripped from the hyperlink and displays as normal text.
http://www.ligotti.net/showthread.php?t=1373

I have tested the process on a link which included only the glossary entry text, and it did not take over the link. Therefore, I assume the problem will only appear when a subset of the text is within a link which includes additional text within the description.

UPDATE
Strangely, the crosslink is not active when the text is presented while enclosed within quotation marks. The example above apparently was not following this rule due to the hyperlink. I would like to disable this rule as well, since I am using the glossary to catalog an author's body of work, and many of the stories are enclosed within quotation marks when referenced throughout the site.

Forgive me for the bump, but I assumed that my issues were likely overlooked in the panic over the bot activity. See my original post above.

WildSoftCat 08-18-2008 01:18 AM

Thanks :)

Some bugs in this version :

1) Icon near crosslink does not appear, if crosslinked text begins of post.
2) Popup doesn't appear, if crosslinked text is in the only string of post (?)
3) Popup encoding must be the same as in main page, now different (my common encoding is windows-1251, but popup is shown in utf8 (?) )

Keyser Soze 08-18-2008 06:53 AM

Thanks for the quick fix and for this great hack in general.
I have a few (small) feature requests:
  • Forum-ID exclude-list: Provide an option to exclude certain forum-ids from crosslinking. This would be useful for me because I have some forum categories where I don't want any crosslinking.
  • Don't highlight the current glossary entry name in the description on the showentry-page again. This is unneccessary ;)
  • Include a "read more" link in the overlib-popup and/or add 3 dots at the end (...) to show to the readers more clearly that there is more text if they click on the link.

Chadi 08-18-2008 03:55 PM

Thanks for the mod.

Questions:
- there is not general features in "manage entries" such as add, delete, edit.

Feature request:
- add above mentioned features in admincp
- list glossary terms
- show/hide author name and last edit columns

Thanks.

R_Enterprise 08-19-2008 05:59 AM

okay installed it.. how in the world do you add entries?

Theres like no "new topic" button to add any entries

derandechser 08-19-2008 08:00 AM

Quote:

Theres like no "new topic" button to add any entries
If you do not use standard-style, you have to put the images in the image-folder of your style...
(sorry for my english)

Peter

R_Enterprise 08-19-2008 09:23 PM

Quote:

Originally Posted by derandechser (Post 1602147)
If you do not use standard-style, you have to put the images in the image-folder of your style...
(sorry for my english)

Peter

Thanks got it fixed

MrD 08-20-2008 09:09 AM

Nice Hack and perfect Support ;)
Run?s without Problems.

Nominated for MOTM

i156 08-23-2008 11:30 PM

I don't see any add buttons either after installing. I'm pretty sure I'm using the standard style. Also, how can I change it from saying Glossar to Glossary?

Vossi 08-24-2008 06:22 AM

Quote:

Originally Posted by i156 (Post 1605428)
I don't see any add buttons either after installing. I'm pretty sure I'm using the standard style. Also, how can I change it from saying Glossar to Glossary?

Hm, are you sure you uploaded the images into the 'buttons'-folder?

About glossar/glossary... we figured out, that glossary would habe been the correct translation. In version 1.0.1, which is getting released in a few days with a hell lot of new functions, we're going to change that. Meanwhile you can change the phrases for that, simply search for 'glossar' in the phrase-manager.

i156 08-24-2008 06:33 AM

Quote:

Originally Posted by Vossi (Post 1605567)
Hm, are you sure you uploaded the images into the 'buttons'-folder?

About glossar/glossary... we figured out, that glossary would habe been the correct translation. In version 1.0.1, which is getting released in a few days with a hell lot of new functions, we're going to change that. Meanwhile you can change the phrases for that, simply search for 'glossar' in the phrase-manager.

Got it working, thanks!

i156 08-24-2008 12:49 PM

I am getting an error on the entry pages. Any help with fixing this?

http://www.usacarry.com/forums/vbglo...&catid=1&id=36


Warning: preg_replace_callback() [function.preg-replace-callback]: Compilation failed: missing ) at offset 117 in [path]/includes/functions_vbglossar.php on line 215

i156 08-24-2008 02:01 PM

Also, the crosslinking popups are showing up in another language. How do I get them to be english? BTW, that error shows up on top of the threads when there is a crosslink active on the page.

i156 08-24-2008 02:02 PM

The error has disappeared now that I turned off crosslinking. But I would like to use that feature. Please help, thanks.

i156 08-24-2008 02:19 PM

Last thing, when you click on a letter, shouldn't the pagination be cut down to only show those items?

http://www.usacarry.com/forums/vbglo...name&order=asc

For example there are more terms in the letter C than on this page but when I go to page 2, it just goes to the overall page 2, not page 2 of just the C's.

Keyser Soze 08-24-2008 02:39 PM

Quote:

Originally Posted by i156 (Post 1605813)
Last thing, when you click on a letter, shouldn't the pagination be cut down to only show those items?

I already reported this bug a few pages before.

imedic 08-25-2008 06:27 PM

Great mod! I am waiting for the new version to give it a go.

tiger 08-26-2008 11:09 PM

Quote:

Originally Posted by Vossi (Post 1605567)
Hm, are you sure you uploaded the images into the 'buttons'-folder?

About glossar/glossary... we figured out, that glossary would habe been the correct translation. In version 1.0.1, which is getting released in a few days with a hell lot of new functions, we're going to change that. Meanwhile you can change the phrases for that, simply search for 'glossar' in the phrase-manager.

Great can't wait and thanks for the awesome mod!

Vossi 08-31-2008 12:07 PM

I just uploaded version 1.0.1 with new features and a complete overworked code.

akulion 08-31-2008 10:01 PM

installed it - seems to be working fine initially...

thanks
aku

akulion 08-31-2008 10:20 PM

oh I thought cross linking would give a popup definition of the word, however it just displays some text in german.

Good mod for sure, thanks for creating it :)

tiger 08-31-2008 10:59 PM

Any chance of modifying that vbcms module to work with vba cmps, same basic thing but works a little different. Also in the last version when I had all the crosslinking options the posts disappeared. They were there if you hit edit but invisible to normal users.

I haven't tried crosslinking in the new version. Otherwise working good thanks for the great mod!

i156 09-01-2008 02:14 PM

Any chance of fixing the german in the cross linking popup?

Also is there anyway to have the category name in the actual url instead of the category id? I''ve got it working with vbSeo but it would be even better if it had the keywords from the category.

http://www.usacarry.com/forums/glossary-1/

Same with the term links if possible.

Vossi 09-01-2008 02:42 PM

Quote:

Originally Posted by i156 (Post 1612014)
Any chance of fixing the german in the cross linking popup?

Also is there anyway to have the category name in the actual url instead of the category id? I''ve got it working with vbSeo but it would be even better if it had the keywords from the category.

http://www.usacarry.com/forums/glossary-1/

Same with the term links if possible.

The german terms can be found in functions_vbglossar.php :o Actually we forgot to translate them.

We actually think about vBSEO-support, but aint't sure yet.

Fireproof 09-01-2008 04:16 PM

Quote:

Originally Posted by Vossi (Post 1612041)
The german terms can be found in functions_vbglossar.php :o Actually we forgot to translate them.

When do you think you'll have that accomplished?

I would love this mod, but would like it to be fully English compatable (i'm a noob to mods, so don't really want to hack a php file if I don't have to. :p)

thanks! Nice work so far it seems.

i156 09-01-2008 04:44 PM

Quote:

Originally Posted by Vossi (Post 1612041)
The german terms can be found in functions_vbglossar.php :o Actually we forgot to translate them.

We actually think about vBSEO-support, but aint't sure yet.

Is the crosslinking supposed to just show the definition of that word in a thread if you have it entered in the glossary? If so then can I just turn off the translation that is going on or am I not understanding this correctly?

abdelghani68 09-06-2008 12:02 PM

How to do for don't seethe bbcode when i edit the threed. I don't want for exemple i see [COLOR="Blue"-]glossar[/COLOR] but i wan't to see directly glossar

"When posting messages to the forums or other members, there are three interface types available to you. The simplest of these is a simple text box, while the last is a fully-fledged WYSIWYG editor, which allows you to format your text as you want it and see the results immediately.

Depending upon the capabilities of your web browser, you may not be able to use all of these options. If you experience problems when posting messages, try switching to a different interface type"

I have got the interface WYSIWYG

Thanks for your help!

imedic 09-07-2008 05:14 AM

I have installed and forgot to cmod folders prior to uploading the product. Crosslinking did not work.
I then have "brilliant" idea of uninstalling the product and if I wanted to reinstall it gave me error of tables being already created in database and did not install product.

Should I manually delete tables or is other way of doing it?


All times are GMT. The time now is 07:50 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01608 seconds
  • Memory Usage 1,831KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (13)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete