vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Forum Display Enhancements - Remove Spiders from Who's Online (https://vborg.vbsupport.ru/showthread.php?t=152321)

Charlie98902 07-18-2007 01:24 PM

When it is running it may be conflicting with one of my other mods, it was just a want not a I need this really, so I can live without it.

Kohhal 07-18-2007 02:48 PM

Quote:

Originally Posted by mfyvie (Post 1293575)
Ok, well there are only 3 places I know of where this can happen. The admincp (which my mod stops from updating the total), the who's online display, the main forum display, and the vbadvanced module (if you are running vbadvanced). If for example you are running vbadvanced and forgot to edit this module, it will be reseting the totals for you.

Can you confirm that you aren't running vbadvanced, and that you don't have any other areas of your forum where the maxonline is displayed (or updated)? Also, which version of vb are you running? If you are running pre 3.6.6 there is different code, but I wasn't able to test this because I'm running 3.6.7.

I'm not running vbadvanced and I've no hacks or anything installed that should affect this. Only couple of minor hacks installed.

I don't have any non-default displays of max users online anywhere so dunno if that could be it.

I'm running 3.6.7 PL1

SnitchSeeker 07-22-2007 05:05 PM

Quote:

I've never understood why people want to know the number of spiders on their board - it's a totally meaningless number - you could have 500 yahoo slurp spiders crawling one page per session, or you could have a single spider crawl 500 pages in a single session. What's more important to check is the spider activity in your weblogs - it really doesn't have any place in your online users in vbulletin.
I suppose you're right. I was thinking mainly for my own benefit so that if the site is slow I can see if it's due to a high number of spiders on. I've never been good at checking logs. They're complicated to understand for me at least. I'm not very technical savvy.

rungok 07-22-2007 06:32 PM

Thanx for this mod. But I have a problem wich you have talked about before. When I insert
Code:

" . ($killspiders ? " AND " . TABLE_PREFIX . "session.spider = -1 " : null) . "
in the onlineusers.php I get this fault:
Quote:

Database error in vBulletin 3.6.5:

Invalid SQL:

SELECT session.userid, username, usergroupid, (user.options & 512) AS invisible, IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid
FROM vb_session AS session
LEFT JOIN vb_user AS user USING (userid)
WHERE session.lastactivity > 1185130825
AND vb_session.spider = -1
ORDER BY invisible ASC, username ASC;

MySQL Error : Unknown table 'vb_session' in where clause
Error Number : 1109
Date : Sunday, July 22nd 2007 @ 09:30:25 PM
Script : http://www.nettkafeen.no/forums/portal.php
Referrer : http://www.nettkafeen.no/forums/index.php
IP Address : 81.167.190.76
Username : Mr.Man
Classname : vb_database
and the vb_session table exist.

rungok 07-22-2007 07:02 PM

Solved it. I just pasted this line without the table prefix, and it worked.
Code:

" . ($killspiders ? " AND session.spider = -1 " : null) . "
All of my tables have table-prefix _vb, but the rest of the original query refers to this table without it.

AndyP 07-27-2007 01:57 AM

Is anyone else trying to use this mod with PaulM's most ever mod?

I'm currently getting low counts for active users, that is, spiders aren't included.
But the most ever guest count is a lot higher than I'd expect. It must be including spiders, and in turn affecting the most ever users online stat.

Are they compatable? To me it doesn't look like it.

lebanon 07-28-2007 11:46 AM

I just added ur mod, however whats weird is my record of users went down from 1600 to 172 members online and today as the record.
My who is online shows guests but the main page shows 0 guests,
Am only confused cause i cant see in the code what could mess up the record query !

mfyvie 07-28-2007 12:13 PM

Quote:

Originally Posted by rungok (Post 1298478)
Solved it. I just pasted this line without the table prefix, and it worked.
Code:

" . ($killspiders ? " AND session.spider = -1 " : null) . "
All of my tables have table-prefix _vb, but the rest of the original query refers to this table without it.

Thanks for that. Very strange though - I have to check more into that syntax. I don't use table prefixes, or mysql 5 - are you using mysql 5 and if so, is strict mode set?

Quote:

Originally Posted by AndyP (Post 1302783)
Is anyone else trying to use this mod with PaulM's most ever mod?

I'm currently getting low counts for active users, that is, spiders aren't included.
But the most ever guest count is a lot higher than I'd expect. It must be including spiders, and in turn affecting the most ever users online stat.

Are they compatable? To me it doesn't look like it.

From the looks of it they wouldn't be compatible. The reason is that Paul's mod will not be differentiating spiders in the totals, and is probably re-writing the max online statistic.

Quote:

Originally Posted by lebanon (Post 1303819)
I just added ur mod, however whats weird is my record of users went down from 1600 to 172 members online and today as the record.
My who is online shows guests but the main page shows 0 guests,
Am only confused cause i cant see in the code what could mess up the record query !

Sounds like the mod is functioning exactly as designed. I suggest you give it time (see other posts on this thread which cover the same subject) and the number of guests will increase to the correct number. If in doubt -use the test script I included to verify that everything is working as you expect.

AndyP 07-28-2007 12:19 PM

Thanks mfyvie, that's what I thought. It would be great if they did work together though, as now it looks like I might have to drop one of them, unless I can work out a way to edit it myself.

mfyvie 07-28-2007 12:23 PM

Quote:

Originally Posted by AndyP (Post 1303833)
Thanks mfyvie, that's what I thought. It would be great if they did work together though, as now it looks like I might have to drop one of them, unless I can work out a way to edit it myself.

Take a look into Paul's mod and see if you can see the part where it does a query to get the number of guests. It should just be a matter of adding "AND spider = -1" to the "WHERE" section of the query. After that you'll probably want to manually reset the max online totals again.

AndyP 08-07-2007 10:14 AM

There wasn't a where statement.

However, I got it to fix the most guests online record from PaulM's mod by amending the execution order of your mod at the forumhome_complete hook to be earlier than Paul's. This way your mod was amending the max number of guests before Paul's mod used it.

Unfortunately the max users ever online is still including spiders and I don't believe PaulM's mod affected this.

Example:
The most ever members online was 16, Today at 09:06 PM. The most ever guests online was 4, Today at 09:08 PM.
=> Most users ever online was 35, Today at 09:10 PM.

Ronseal 09-04-2007 02:10 PM

This Mod appears to be working fine on my Forum Index, but still shows far too many guests on the VBadvanced portal page....... is it another case where I just have to wait?

I've added the code as advised to onlineusers.php but it doesn't seem to have made any diffence.

Ronseal 09-10-2007 10:05 PM

Sorry to bump the thread but has anybody any ideas why this Mod doesn't work on my portal page?

mfyvie 09-22-2007 06:18 AM

Quote:

Originally Posted by Ronseal (Post 1332166)
This Mod appears to be working fine on my Forum Index, but still shows far too many guests on the VBadvanced portal page....... is it another case where I just have to wait?

I've added the code as advised to onlineusers.php but it doesn't seem to have made any diffence.

Hi Ron,

Sorry I can't really help with that. This mod doesn't officially support vbadvanced mod. I just added that code as a courtesy. However, others have got it to work. If you see no difference at all you may have inserted the code into the wrong file, or the wrong section of the file. I suggest you go back and start from the beginning and try and debug it yourself. Sorry.

Ronseal 09-24-2007 12:11 PM

Thanks for the reply mfyvie but I have to admit I'm stumped, I've added the code as advised but it doesn't appear to correct the count on the vbadvanced portal page. Can anybody else spot anything I've done wrong, here's where I've added the code and I've also tried it without the line spaces above and below?
Code:

FROM " . TABLE_PREFIX . "session AS session
LEFT JOIN " . TABLE_PREFIX . "user AS user USING (userid)
WHERE session.lastactivity > " . (TIMENOW - $vbulletin->options['cookietimeout']) . "

" . ($killspiders ? " AND " . TABLE_PREFIX . "session.spider = -1 " : null) . "

ORDER BY username ASC
");


Many thanks
Ron

mfyvie 09-25-2007 10:58 AM

Hi Ron,

I can only see two possibilities -

1. You may be editing the wrong file. Try to deliberately insert a syntax error and see what happens. If nothing changes, you may be editing the wrong file. Try renaming the file, just to make sure that everything crashes (then rename it back)
2. The variable $killspiders must be set to true to see any difference. This variable is set by the mod itself earlier on, so should be true (unless you've disabled it). I could not tell you why it is not set to true, but you could try to force is by inserting the following line earlier in the file:

Code:

$killspiders = true;
Apart from those tips I really have no idea without looking at and playing with your system directly.

Ronseal 09-25-2007 02:18 PM

mfyvie, you've done it! :D
I simply added the killspiders code you've mentioned at the top of the 'onlineusers.php' file and hey-presto it works perfect. I'm not sure where this setting is supposed to be set, but for the time being untill I find out where, everything works perfect. Although just to clarify I hope this doesn't prevent spiders from crawling my site and indexing it, I just want to remove spiders from the online users count.

Many thanks mfyvie!

mfyvie 09-25-2007 02:37 PM

Ron, I'm glad you used this trick to at least verify that your edits are working.

Here is the code that sets this variable - it runs from the hook global_start, and therefore should be included on all vbadvanced pages as well.

Code:

$killspiders = $vbulletin->options['enablespiders'];
I suspect that you may have disabled the vbulletin setting "Enable spider display". If vbulletin does not identify connections as spiders or not, this mod cannot work correctly.

Ronseal 09-25-2007 02:49 PM

'Enable Spider Display' is set to 'Yes' and always has been as far as I recall, and I'm not sure what you mean by the hook 'global_start'. I've searched for a reference to this code in a few of my vBadvanced CMPS templates and I can't find any sign of it so I assume I'm looking in the wrong place.

mfyvie 09-25-2007 03:01 PM

Hi Ron, if you look in your vbadvanced files you'll see a line that reads like this:

Code:

require_once('./global.php');
If you then look in global.php you'll find a line that looks like this:

Code:

($hook = vBulletinHook::fetch_hook('global_start')) ? eval($hook) : false;
The code in my previous post fires at global_start, so in other words, if that setting is set to on as you say, then the variable should be set, and you shouldn't have to set it manually. Why it doesn't work is a mystery to me :)

Ronseal 09-25-2007 03:14 PM

Hi mfyvie, As you've already anticipated my 'global.php' file does indeed have the line
Code:

($hook = vBulletinHook::fetch_hook('global_start')) ? eval($hook) : false;
the same as yours, so it'll have to remain a mystery for the moment why is doesn't work. However I do run vBSEO 3.0.0 on my site so perhaps that has some involvement somewhere. I haven't explored all the options in vBSEO but if I find any potential conflict I'll let you know.... but for the meantime your manual edit to the 'onlineusers.php' appears to work fine.

Thanks again
Ron

James Argo 02-08-2008 04:02 AM

/\ /\ /\
Click installed! :)

Beautifull :)

Milktruck 02-10-2008 12:54 AM

For some reason it doesn't seem to be working me as far as Yahoo is concerned... maybe I've done something wrong.

Guests where the status has not yet been determined:
05:15 74.6.20.156 /showthread.php?t=26617 Mozilla/5.0 (compatible; Yahoo! Slurp; http://help.yahoo.com/help/us/ysearch/slurp)
05:30 74.6.24.110 /showthread.php?t=25687 Mozilla/5.0 (compatible; Yahoo! Slurp; http://help.yahoo.com/help/us/ysearch/slurp)
05:46 74.6.7.80 /showthread.php?t=26365&page=2 Mozilla/5.0 (compatible; Yahoo! Slurp; http://help.yahoo.com/help/us/ysearch/slurp)
06:06 74.6.24.100 /showthread.php?t=26212&page=9 Mozilla/5.0 (compatible; Yahoo! Slurp; http://help.yahoo.com/help/us/ysearch/slurp)
06:13 74.6.23.233 /forumdisplay.php?f=327 Mozilla/5.0 (compatible; Yahoo! Slurp; http://help.yahoo.com/help/us/ysearch/slurp)
06:28 74.6.28.164 /showthread.php?t=26353 Mozilla/5.0 (compatible; Yahoo! Slurp; http://help.yahoo.com/help/us/ysearch/slurp)

I've got a whole bunch more Yahoo entries in the list.. any idea why they are staying put in my guest list? This plugin seems to work for all of the others.

piraterevival 02-10-2008 04:53 PM

Added and installed, nice one

Marco van Herwaarden 05-15-2008 10:19 AM

*** Staff note: The author of this modification has passed away in a diving accident. We wish his family all strength in dealing with this traggic issue. ***

r5e 08-05-2008 01:23 AM

I've just granted permission to another coder who has agreed to take over the code from Mark's mods (like this one) and keep them up to date and free to all, which should be good news for all of you who use his mods and allow his legacy to continue.

Robert Fyvie

Sonyuserforum 01-06-2009 04:49 PM

Quote:

Originally Posted by r5e (Post 1591564)
I've just granted permission to another coder who has agreed to take over the code from Mark's mods (like this one) and keep them up to date and free to all, which should be good news for all of you who use his mods and allow his legacy to continue.

Robert Fyvie

Anything new here?

r5e 01-06-2009 09:53 PM

Nothing major to report that is new, but PHPKD has been a little slower than I expected to take it up. He made an announcement a while back saying that he had started work on this, but I can't find it now. Try contacting him directly if you want more info.

Omranic 01-07-2009 08:49 AM

Hello every body,

Sorry for any inconvenience delay.
This product has been scheduled to be released two weeks ago, but since there was some internal & external problems with PHP KingDom's teamwork we've forced to postponement the release date.
But now every thing is going well, thanks GOD.
We've finally finished working on this product & it will be released for all supported vBulletin versions by tomorrow Thursday 08-01-2009 06:00 PM GMT. Yes, tomorrow. It's the final date we think.
Thanks for your patience & sorry for that delay.

Sincerely Regards
PHP KingDom

Omranic 01-08-2009 03:58 PM

Quote:

Originally Posted by PHPKD (Post 1704007)
Hello every body,

Sorry for any inconvenience delay.
This product has been scheduled to be released two weeks ago, but since there was some internal & external problems with PHP KingDom's teamwork we've forced to postponement the release date.
But now every thing is going well, thanks GOD.
We've finally finished working on this product & it will be released for all supported vBulletin versions by tomorrow Thursday 08-01-2009 06:00 PM GMT. Yes, tomorrow. It's the final date we think.
Thanks for your patience & sorry for that delay.

Sincerely Regards
PHP KingDom

Follow-up.
According to users spotlights around this product & user's feedback received, we've decided to include some more features such as separating spiders in the "who is online" without neglecting them, also an option to reset the "maximum online users" any time from admin control panel. There is also other new features that's currently in progress, we preferred not to release the product before implementing these new features.
As we said before, the base product has been completed already, but will be released after implementing these new features. We will update this thread with further details & with release time (which should be very very soon).
Thank you for your patience.

Sonyuserforum 04-13-2009 06:37 PM

Quote:

Originally Posted by PHPKD (Post 1705266)
As we said before, the base product has been completed already, but will be released after implementing these new features. We will update this thread with further details & with release time (which should be very very soon).
Thank you for your patience.

??? Anybody here ???

Birched 08-23-2009 12:36 AM

I can't find the equivalent to this for 3.8.4. Is anyone running it in 3.8.x?

It looks like the developer who took this particular mod over disappeared.

Thanks.

Claverhouse 09-02-2009 11:20 AM

It's working on 3.8.4...

Stormtrooper 05-31-2010 05:26 PM

Is anyone working on something similar for 4.x?


All times are GMT. The time now is 05:58 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01305 seconds
  • Memory Usage 1,842KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (9)bbcode_code_printable
  • (11)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (34)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete