vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Show Thread Enhancements - Automatic Embedded Video (youtube, plus many more) (https://vborg.vbsupport.ru/showthread.php?t=150472)

Hornstar 06-23-2007 11:10 PM

Quote:

Originally Posted by FleaBag (Post 1274952)
I changed the execution order of this hack, to 1, and it all works just fine now. Working with vBSEO. I'm guessing this technically should deal with the URL before anything else - as long as vB gets there first I'm happy. Will changing execution order to 1 have any detremental effects?

that is what im thinking, and how do you change the execution order ^^
Maybe vbseo execution order could be changed a little higher, could be worth asking vbseo as well.

FleaBag 06-23-2007 11:12 PM

vBSEO is already at 5. You browse plugins in ACP and click edit to change the order.

I think I spoke too soon... I sucessfully posted a URL, but the next one I tried resulted in vBSEO replacing the string again. The only thing I did in between was to try and edit an old post, to see if it would have any effect. Maybe editing the post is causing the issue.

mfyvie 06-23-2007 11:14 PM

Quote:

Originally Posted by hornstar1337 (Post 1274948)
This looks truly awesome, but it is a shame that a feature in vbseo will need to be turned off first, hopefully there can be another solution for this.

Actually, I've just confirmed this with my own internal test, and if you download this mod in about 30 minutes it won't be an issue.

Quote:

Originally Posted by FleaBag (Post 1274952)
I changed the execution order of this hack, to 1, and it all works just fine now. Working with vBSEO. I'm guessing this technically should deal with the URL before anything else - as long as vB gets there first I'm happy. Will changing execution order to 1 have any detremental effects?

I've actually changed it to 3 - just in case there is something out there later than needs to get in earlier. Changing to 1 effectively locks any other mod from going before you if it needs to.

Quote:

Originally Posted by Lizard King (Post 1274953)
I think you missed that i edited my post and included the links.

Yes, after or during my reply. From looking at the links I can see that some were working, some were not. This is due to the - character in the youtube URLs (wasn't expecting that, my test URLs didn't have them). This will be fixed in a few minutes. Watch this thread.

Lizard King 06-23-2007 11:14 PM

Strange thing , After posting a metacafe link now youtube videos also started to work on my test server. However on live server metacafe videos work but youtube videos look like [YOUTUBEvid]C7V3WCy1Ozc[/youtubevid] , Here is the link for the thread http://www.ayyas.com/road-trip/18229...ur/#post313522
I have my execution order for this product set to 1 also.

FleaBag 06-23-2007 11:19 PM

Affirmative - YouTube's without URL's work just fine. Great work, good to hear the fix is coming! :D

If you could make it let us edit posts manually and work too, you'd really make my day. My month in fact.

aj8690 06-23-2007 11:19 PM

Works great. Hope we can fix that YouTube no www. problem.

AJ

mfyvie 06-23-2007 11:25 PM

PRODUCT FILE UPDATED

All users who have downloaded and installed this mod prior to the date stamp on this post (which is after all a couple of hours after the release) should redownload and reinstall the .xml file included with this release.

This should resolve all issues reported on this to date (that I have control over).

Those who have reported issues so far, please retest to see if they are resolved after you reinstall, and raise them again if they are.

PRODUCT FILE UPDATED

mfyvie 06-23-2007 11:33 PM

Quote:

Originally Posted by aj8690 (Post 1274964)
Works great. Hope we can fix that YouTube no www. problem.

Now fixed. Also loosened the logic for all the other services in case this happens to them in the future.

Quote:

Originally Posted by FleaBag (Post 1274963)
If you could make it let us edit posts manually and work too, you'd really make my day. My month in fact.

Well I want to avoid duplicating the entire code at another hook, or using a file (I hate it when I have to upload a file). Remember that when you edit you can manually use the BBCode tags, you just won't get an automatic conversion.

If your issue is that you want to go and convert all your EXISTING posts, then I'm going to make a script to do this for you - so you wouldn't need the edit feature you are asking for.

Quote:

Originally Posted by Lizard King (Post 1274961)
Strange thing , After posting a metacafe link now youtube videos also started to work on my test server. However on live server metacafe videos work but youtube videos look like [YOUTUBEvid]C7V3WCy1Ozc[/youtubevid] , Here is the link for the thread http://www.ayyas.com/road-trip/18229...ur/#post313522
I have my execution order for this product set to 1 also.

If you are seeing the bbcode tags like that then my mod has done its work. You may be having some kind of other issue related to the bbcode itself - I'd look into that separately.

Please don't set execution order to 1, I'm now using 3. Use 1 only to verify that there isn't something sitting at 3 or lower, but nothing else should be.

Quote:

Originally Posted by FleaBag (Post 1274957)
vBSEO is already at 5. You browse plugins in ACP and click edit to change the order.

I think I spoke too soon... I sucessfully posted a URL, but the next one I tried resulted in vBSEO replacing the string again. The only thing I did in between was to try and edit an old post, to see if it would have any effect. Maybe editing the post is causing the issue.

I don't use any of the hooks for post editing, but vbseo may well be doing so. However, if the mod has already converted it to bbcode, then vbseo won't be able to touch it in the edit (since it won't see it as a link).

Quote:

Originally Posted by hornstar1337 (Post 1274954)
that is what im thinking, and how do you change the execution order ^^
Maybe vbseo execution order could be changed a little higher, could be worth asking vbseo as well.

Not needed. My mod is now at 3, vbseo default is at 5, which is also fine. Provided you've reinstalled my mod - everything should now be working.

Lizard King 06-23-2007 11:35 PM

The - problem has been solved. My other problem [YOUTUBEvid]C7V3WCy1Ozc[/youtubevid] was a conflict with another Youtube video bbcode i disabled this to test and now it works. However i have tons of messages using this tag.

mfyvie 06-23-2007 11:35 PM

Quote:

Originally Posted by nfn (Post 1274914)
Here is the first contribution.

http://videos.sapo.pt

Just to let you know - this is now included in the current version. I loosened the logic on the regular expression a little in line with some changes I made to all the others. Seems to work fine on my board.

Alibass 06-23-2007 11:36 PM

Seems this hack does not work with vbAnonymizer installed https://vborg.vbsupport.ru/showthrea...131292&page=16

mfyvie 06-23-2007 11:39 PM

Quote:

Originally Posted by Lizard King (Post 1274970)
The - problem has been solved. My other problem [YOUTUBEvid]C7V3WCy1Ozc[/youtubevid] was a conflict with another Youtube video bbcode i disabled this to test and now it works. However i have tons of messages using this tag.

That can't be possible - that other mod uses [youtube]. I used [youtubevid] because I anticipated that other people may have already created tags for youtube.

If you really did have a conflict then the original installer would have bombed out and you would have got no bbcode imported from my mod. I've changed the installer now so that it doesn't touch existing bbcode if there is a name conflict, but will still import the other items.

Even if there is a conflict it shouldn't matter, since someone else's bbcode for these videos should basically work the same way as mine, in that it expects the unique identifier to be wrapped up between the tags.

mtlcore 06-23-2007 11:40 PM

Working great with vbSEO

Lizard King 06-23-2007 11:42 PM

Quote:

Originally Posted by Lizard King (Post 1274970)
The - problem has been solved. My other problem [YOUTUBEvid]C7V3WCy1Ozc[/youtubevid] was a conflict with another Youtube video bbcode i disabled this to test and now it works. However i have tons of messages using this tag.

I edited the plugin and solved this problem by changing youtube bbcode to another.

Thanks great mod.

mfyvie 06-23-2007 11:42 PM

Quote:

Originally Posted by Alibass (Post 1274972)
Seems this hack does not work with vbAnonymizer installed https://vborg.vbsupport.ru/showthrea...131292&page=16

See post #47 - yes it should. That hack is at execution order 5, mine is now at 3. This should have resolved that issue, just like it did for the vbseo issue and others.

rjmjr69 06-23-2007 11:43 PM

https://vborg.vbsupport.ru/external/2007/06/18.jpg

Thats what I get after install

mfyvie 06-23-2007 11:50 PM

Quote:

Originally Posted by rjmjr69 (Post 1274980)
Thats what I get after install

rjmjr69 - That looks like I've introduced a problem into the installer, this will only have affected new installs in the last 15 minutes. I've removed the file until I can fix that, then when it appears again you can download it and reinstall it.

In the meantime, you can safely delete all those rubbish bbcode entries (which end with the number 2 after each tag).

FleaBag 06-23-2007 11:52 PM

I didn't realise that I could manually use the BB codes when I edited the threads. On top of your converter you plan (or even without) I am now sorted. Thanks a lot! :)

rjmjr69 06-24-2007 12:01 AM

Thank you sir I will delete them now and eagerly await the next attempt. Keep up the great work

Might I make a suggestion and I am not sure this matters or not but would a check of the BB codes that are already installed be something you could put into your installer to either overwrite the ones that are present or delete them and redo them with your code?

mfyvie 06-24-2007 12:07 AM

Quote:

Originally Posted by rjmjr69 (Post 1274991)
Thank you sir I will delete them now and eagerly await the next attempt. Keep up the great work

Might I make a suggestion and I am not sure this matters or not but would a check of the BB codes that are already installed be something you could put into your installer to either overwrite the ones that are present or delete them and redo them with your code?

Ok, the file is back - please download and reinstall.

Actually in the first version you had there was a check to not install if field was already present. Since it was a new install you got those fields. This is why yours didn't work, when all the others did.

The logic now deletes all the records and reinstalls them to be safe. I'll remove the delete statements for the next version (unless updating).

Sorry about that - it's 3am and I should be in bed. Late night and last minute code changes are always a bad idea :rolleyes:

Please let me know ASAP whether that has resolved the issue for you so that I can go to bed...:erm:

FleaBag 06-24-2007 12:19 AM

Latest version works well for me! All issues are gone. I love it so much. I'll get this into action ASAP, see how I can combine it with GARS.

Thanks a lot, when pay day comes around I hope to make a donation. I would easily buy this hack. I hope you realise how popular this is going to be!

Nominated for MOTM. :)

Edit: And go to bed sir! Good work!

TheBlackPoet 06-24-2007 12:20 AM

it works goodexcept 4 when there is a = at the end...


http://youtube.com/watch?v=YrzqBREP0...elated&search=
all the kink copies except that... breaking the whole link......

still i installed

mfyvie 06-24-2007 12:24 AM

Quote:

Originally Posted by TheBlackPoet (Post 1274998)
it works goodexcept 4 when there is a = at the end...


http://youtube.com/watch?v=YrzqBREP0...elated&search=
all the kink copies except that... breaking the whole link......

still i installed

Ok, that's another youtube condition I haven't seen before... Ok, here's a quick fix for that condition. Go into the plugin and find the bit for youtube and replace it with this:

Code:

// youtube.com
array_push($replace, '[youtubevid]$2[/youtubevid]');
array_push($patterns, '~\[URL\]http://(www\.)?youtube\.com/watch\?v=([\w-]*)[^\[]*\[/URL\]~i');

That should resolve your issue. I think I'll update all the other links to allow stuff to be appended onto the end of the URL just in case that happens in other cases where I haven't anticipated it....

mfyvie 06-24-2007 12:26 AM

Quote:

Originally Posted by FleaBag (Post 1274997)
Latest version works well for me! All issues are gone. I love it so much. I'll get this into action ASAP, see how I can combine it with GARS.

Thanks a lot, when pay day comes around I hope to make a donation. I would easily buy this hack. I hope you realise how popular this is going to be!

Nominated for MOTM. :)

Edit: And go to bed sir! Good work!

No problem, glad you appreciate it, and of course donations are always welcome :-)

I've got a few other mods waiting in the wings which fit into the "Why on earth didn't someone do that before?" category :-)

mfyvie 06-24-2007 12:34 AM

Quote:

Originally Posted by TheBlackPoet (Post 1274998)
it works goodexcept 4 when there is a = at the end...

Ok, I've now loosened the logic for all of the video services to allow extra rubbish to be appended onto the end of any URL. That should hopefully nip any such issues in the bud before they happen.

I've updated the file again and put a "b" on the end of the filename.

rjmjr69 06-24-2007 12:34 AM

YOUR THE MAN...!!!!!!!!!!! thanks all works just fine now... goto bed get some rest

mfyvie 06-24-2007 12:38 AM

Ok, it looks like most of the issues with this have been resolved so I'm off to bed. Will get back to this thread in about 6 hours to answer more questions.

I'm glad that so many of you appreciate this mod. So if you like it - why not help out to make it better?

How to help improve this mod

Check out the list at the top of the mod - I've listed all the supported services, as well as unsupported services. Let's make both of these lists bigger! Do you know of any other video services? If not, why not spend some time looking for some? Surely there must be a lot more out there, but I need your help to find them, and my time is also limited! You can also read the guide I included in post 1 for more information about how this mod can be expanded.

The bottom line is that if everyone helps to expand the range of services covered by this mod - everyone benefits!

rjmjr69 06-24-2007 12:43 AM

Will do.... Now go get some rest so you can give us all more fun toys to play with :)

Looks like someone else just release a very simular mod I think just a tad bit late but this is what his supports.


google
Youtube (and es.youtube)
vsocial
ifilm
mteacafe
dailymotion
currenttv
vimeo
sharkle
vidiac
myvideoDE
myspace
break
filecabi
pornotube

You can find the new mod in the new modifications under search button

Nathan2006 06-24-2007 01:03 AM

Thank you Mark this is just what I have been looking for :D

Install

Alibass 06-24-2007 01:07 AM

1.0b has corrected my issue with vbAnonymizer. Thanks!

DieselMinded 06-24-2007 02:00 AM

Installed THANKS !!!!!!

katie hunter 06-24-2007 02:04 AM

I put it on but when i insatlled put a veoh url , it says data is not available =/ do i have to add something else ?

http://forum.nihonomaru.com/site-hel...html#post16268

the video is there btw

http://www.veoh.com/videos/v448414RTx2kCZp?confirmed=1
http://www.veoh.com/videos/v448414RTx2kCZp

I allowed youtube as well and it didn't show up at all ;s

Nathan2006 06-24-2007 02:48 AM

Updated Thank you

Would there be anyway to exclude some forums from this?

I have a forum for video ripping and the links
that members post will get converted :(

Thank you for any help :)

jasculs 06-24-2007 04:17 AM

I use custom bbcode permissions and when someone who does not have permission to use the bbcode puts in a link the unparsed bbcode shows up instead of the link. Is there anyway to fix this or change it?

kollam003 06-24-2007 05:13 AM

Thanks for this

Hornstar 06-24-2007 05:18 AM

Actually forum pemessions would be cool, enable and disable this in certain forums would be great for the next update. installing the new version now. Thanks for the great hack!

Ren? Kunze 06-24-2007 05:45 AM

If I find class, is only unfortunate which he no German sides supported.
One can also make which it supported:

http://video.google.de/
http://www.myvideo.de/
http://www.videotube.de/
http://www.clipfish.de/

That would be class if one to still insert could.

mfyvie 06-24-2007 08:12 AM

Quote:

Originally Posted by rjmjr69 (Post 1275015)
Will do.... Now go get some rest so you can give us all more fun toys to play with :)

Looks like someone else just release a very simular mod I think just a tad bit late but this is what his supports.

You can find the new mod in the new modifications under search button

I've taken a look - it's a very different kind of mod, and many more steps to install. It also needs users to click a button on the links they post in. In my experience many users can't be bothered to click buttons. But I've PM'd the author so that we can maybe share information on adding different file types to our respective mods.

Quote:

Originally Posted by katie hunter (Post 1275056)
I put it on but when i insatlled put a veoh url , it says data is not available =/ do i have to add something else ?

http://www.veoh.com/videos/v448414RTx2kCZp?confirmed=1
http://www.veoh.com/videos/v448414RTx2kCZp

I allowed youtube as well and it didn't show up at all ;s

You haven't given me anywhere near enough information for me to begin to help you. However, I did paste those links you gave into my forum, and they were automatically converted and the videos played.

Quote:

Originally Posted by Nathan2006 (Post 1275070)
Updated Thank you

Would there be anyway to exclude some forums from this?

I'll work on this today, it will probably be ready in about 8 hours or so. Stay tuned to this thread.

Quote:

Originally Posted by jasculs (Post 1275097)
I use custom bbcode permissions and when someone who does not have permission to use the bbcode puts in a link the unparsed bbcode shows up instead of the link. Is there anyway to fix this or change it?

I'll simulate this issue on my own forum and see if there is a way to deal with this. If there is, it will be in the next update. Stay tuned to this thread.

Quote:

Originally Posted by Ren? Kunze (Post 1275152)
If I find class, is only unfortunate which he no German sides supported.
One can also make which it supported:

http://video.google.de/
http://www.myvideo.de/
http://www.videotube.de/
http://www.clipfish.de/

That would be class if one to still insert could.

I'll make sure that google.* is supported in the next update, and I'll try to include those other sites, if it is possible to do so.

Does anyone know of any other video sites that operate under multiple domains? If so, I need to loosen the logic to incorporate these other domains (like, .de, .es) but I'll need some helping in finding out which sites do this!

vwdforum 06-24-2007 09:20 AM

Youtube have recently introduced a uk section. an example of their link is below.

http://uk.youtube.com/watch?v=HOfKOEaVOpY

would it be possible to include the above in a working version that converts this?

I've found it works if I change it to

http://www.youtube.com/watch?v=HOfKOEaVOpY

great mod by the way, much appreciated!

mfyvie 06-24-2007 09:38 AM

Quote:

Originally Posted by vwdforum (Post 1275242)
Youtube have recently introduced a uk section. an example of their link is below.

http://uk.youtube.com/watch?v=HOfKOEaVOpY

Damn it - they keep changing this stuff... I'll loosen up the logic for youtube a little and consider doing so for the other services as well just in case. This change will be in the next version.


All times are GMT. The time now is 06:52 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01666 seconds
  • Memory Usage 1,862KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (24)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete