vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   End-User Options - Mark All Forums Read Confirmation (https://vborg.vbsupport.ru/showthread.php?t=142376)

Dismounted 03-22-2007 10:33 AM

FYI, QuickLinks doesn't refresh the page, it's ajax. But I'll have a look at it.

EDIT: Are you sure your found ALL the edits? You must copy & paste the ones from the files as they are because there are many instances of parts of the code. Anyway, I've found a few errors in the readme. For you curious ones, I forgot & parses as & when the page is displayed. I have updated the zip.

TrIn@dOr 03-22-2007 12:22 PM

Quote:

Originally Posted by Dismounted (Post 1209376)
Sorry about that, I forgot to make a change in the readme. I have updated the zip. You can just do the following to get it to work.

In the template 'headinclude', find:
PHP Code:

function mark_all_read() 

Replace With:
PHP Code:

function mark_all_read(type


Still continue the issue the same way Tralala described...

Quote:

Originally Posted by Tralala (Post 1209410)
Okay, I bit the bullet.

I just removed version 1.0 completely, then installed version 1.1. I went to my templates and removed the previous code, then replaced with new code.

The "Mark Forums Read" link on forumhome works properly with the new confirmation. But the QuickLinks menu option does not.

When I choose "Mark Forums Read" from the QuickLinks pulldown, the confirmation dialog pops up... but when I click OK, it goes away and nothing happens. No page refresh, no threads marked as "read..." nothing.

This is on the default vBulletin style.


TrIn@dOr 03-22-2007 12:41 PM

I'm not a coder, but perhaps the problem is here...

navbar template
PHP Code:

<tr><td class="vbmenu_option"><a href="forumdisplay.php?$session[sessionurl]do=markread" onclick="return mark_all_read('ajaxstyle');">$vbphrase[mark_forums_read]</a></td></tr

After doing a click on OK, the "mark_all_read" is not executed...

Tralala 03-22-2007 02:45 PM

Quote:

Originally Posted by Dismounted (Post 1209480)
EDIT: Are you sure your found ALL the edits?

Yes.
Quote:

Originally Posted by Dismounted (Post 1209480)
Anyway, I've found a few errors in the readme. For you curious ones, I forgot &amp; parses as & when the page is displayed. I have updated the zip.

Which template does this refer to? So that I may update properly and try again, please?[/quote]

Doctor Death 03-23-2007 03:18 AM

I installed per the directions...

When it asked if I really wanted to mark read I answered yes but it wouldnt mark them.

I then uninstalled and now I am all hosed up... After editing templates and then removing the XML, here is what I get when I click on the MARK THIS FORUM READ...

Would appreciate expert advice on how to fix this as my forums are critical.

Thanks much

Doc
www.ddsog.com

Dismounted 03-23-2007 09:10 AM

Quote:

Originally Posted by Tralala (Post 1209590)
Which template does this refer to? So that I may update properly and try again, please?

Forumdisplay
Quote:

Originally Posted by Doctor Death (Post 1210082)
I installed per the directions...

When it asked if I really wanted to mark read I answered yes but it wouldnt mark them.

I then uninstalled and now I am all hosed up... After editing templates and then removing the XML, here is what I get when I click on the MARK THIS FORUM READ...

Would appreciate expert advice on how to fix this as my forums are critical.

Thanks much

Doc
www.ddsog.com

You didn't remove the template edits.

Doctor Death 03-23-2007 06:35 PM

I followed the instructions to the word....

I really need some assistance on this one... Can you help please?

I do NOT know how to fix the templates...

Doc

Doctor Death 03-23-2007 07:33 PM

Ok, I got it, thanks anyway!!

Doc

Dismounted 03-24-2007 02:23 AM

If anybody wants me to prove that this works, PM me and I'll install it on your forums for you.

Smoothie 03-24-2007 03:52 AM

gonna give it a go right now

Smoothie 03-24-2007 04:18 AM

Slight problem, I think it's because my links are in the header, not the navbar.

First edit says to find this in forum home, but when I search, it appears in forum home, header and navbar:
Code:

<a href="forumdisplay.php?$session[sessionurl]do=markread" rel="nofollow">$vbphrase[mark_forums_read]</a>
Second edit is fine. Third edit says to find this in navbar, but it's not there:
Code:

<a href="forumdisplay.php?$session[sessionurl]do=markread">$vbphrase[mark_forums_read]</a>

Dismounted 03-24-2007 04:23 AM

Quote:

Originally Posted by Smoothie (Post 1210811)
First edit says to find this in forum home, but when I search, it appears in forum home, header and navbar:
Code:

<a href="forumdisplay.php?$session[sessionurl]do=markread" rel="nofollow">$vbphrase[mark_forums_read]</a>

Only the modification of FORUMHOME is required.
Quote:

Originally Posted by Smoothie (Post 1210811)
Second edit is fine. Third edit says to find this in navbar, but it's not there:
Code:

<a href="forumdisplay.php?$session[sessionurl]do=markread">$vbphrase[mark_forums_read]</a>

As you said before, this is probably caused by the dropdown being in your header.

Smoothie 03-24-2007 04:28 AM

So, I'm a bit confused. Besides replacing the forum home in the first edit and the forum display in the second edit, what do i find and replace in the navbar?

Dismounted 03-24-2007 04:29 AM

Do you have a 'Quick Links' drop-down in your navbar?

Smoothie 03-24-2007 04:34 AM

Quote:

Originally Posted by Dismounted (Post 1210821)
Do you have a 'Quick Links' drop-down in your navbar?

The QL's are in the header. The code I believe is in the navbar.

Actually I just looked, the QL's are in the header and this bit of code is in the QL's:
Code:

<a href="forumdisplay.php?$session[sessionurl]do=markread" rel="nofollow">$vbphrase[mark_forums_read]</a>

Dismounted 03-24-2007 04:41 AM

That's the one, edit that one :p.

Smoothie 03-24-2007 04:46 AM

Quote:

Originally Posted by Dismounted (Post 1210830)
That's the one, edit that one :p.

And replace with?? :)

Dismounted 03-24-2007 04:47 AM

The navbar edit.

Smoothie 03-24-2007 04:58 AM

Confirmed, installed and working on all pages.

BTW, when searching for this code, it appears in header, navbar and forum home as mentioned above and it does need to be replaced in all 3 instances.
Code:

<a href="forumdisplay.php?$session[sessionurl]do=markread" rel="nofollow">$vbphrase[mark_forums_read]</a>

Tralala 03-25-2007 03:59 PM

Thanks for your continued work and improvement on this, Dismounted. I did all the edits/updates you've shared here, and it now appears to be working for me everywhere (in both the default vB skin as well as my custom skin.) As the original requester, I certainly appreciate this enhancement!

There's one last location to "Mark All Forums Read" though that could use the confirmation pop-up, though. New in vBulletin 3.6.x is the ability to double-click the icon to the right of a Forum name... that marks that particular forum as "read."

See here:
https://vborg.vbsupport.ru/attachmen...2&d=1145289561

I'd like to get a confirmation pop-up there too, to keep things consistent.

Smoothie 03-25-2007 04:05 PM

Quote:

Originally Posted by Tralala (Post 1211894)
Thanks for your continued work and improvement on this, Dismounted. I did all the edits/updates you've shared here, and it now appears to be working for me everywhere (in both the default vB skin as well as my custom skin.) As the original requester, I certainly appreciate this enhancement!

There's one last location to "Mark All Forums Read" though that could use the confirmation pop-up, though. New in vBulletin 3.6.x is the ability to double-click the icon to the right of a Forum name... that marks that particular forum as "read."

See here:
https://vborg.vbsupport.ru/attachmen...2&d=1145289561

I'd like to get a confirmation pop-up there too, to keep things consistent.

https://vborg.vbsupport.ru/showpost....2&postcount=20 ;)

Tralala 03-25-2007 04:10 PM

Quote:

Originally Posted by Smoothie (Post 1211896)

Your post was made 6 days ago, before Dismounted actually updated it to work in more locations that just Forum Home. Therefore, your comment didn't make much sense back then. Nor did your resolve to "uninstall until this gets fixed," because... well... you obviously didn't.

Smoothie 03-25-2007 04:20 PM

Quote:

Originally Posted by Tralala (Post 1211900)
Your post was made 6 days ago, before Dismounted actually updated it to work in more locations that just Forum Home. Therefore, your comment didn't make much sense back then. Nor did your resolve to "uninstall until this gets fixed," because... well... you obviously didn't.

What has any of that have to do with the request to include that feature?

And how would you know what I did or did not do regarding installing or uninstalling?

Tralala 03-25-2007 04:47 PM

Quote:

Originally Posted by Smoothie (Post 1211907)
What has any of that have to do with the request to include that feature?

When you first posted, it wasn't worded as a "request," but rather as a bug report that was compelling you to "uninstall." That kind of knee-jerk reaction can be frustrating to coders gracious enough to share their work. Dismounted has been generous here... and strong-arming him to make the code work precisely the way YOU initially expect isn't necessarily the most tactful approach, that's all.

(FWIW, I wouldn't have bothered to comment further, but your snarky post/link with the little winky was petty and misguided, IMHO.)

Quote:

Originally Posted by Smoothie (Post 1211907)
And how would you know what I did or did not do regarding installing or uninstalling?

Anyone reading this thread is aware of your travails; you've posted every single step of the way.

And when you first posted and said "works fine," it was I who logged into your forum and demonstrated that it didn't. Re-read the thread, kemosabe.

Smoothie 03-25-2007 05:17 PM

You seem to be having this "knee-jerk" reaction after I posted a link showing you I asked politely for this feature to be included, if possible. What I did or did not do before, during or after is none of your business. Not sure what your problem is, kemosabe.

Tralala 03-25-2007 07:32 PM

LOL! We're on the same page, dude. We both want to see the new feature introduced, yes?

Crikey... it's no wonder so many coders get discouraged and disappear around here.

Doctor Death 03-25-2007 08:14 PM

Quote:

Originally Posted by Dismounted (Post 1210771)
If anybody wants me to prove that this works, PM me and I'll install it on your forums for you.


Dismounted installed on my forums and it is SWEET... works flawlessly....

I guess I am just a bonehead when it comes to installing.

Thanks much Dismounted again, that was very good of you to take the time and help out.

Doc
www.ddsog.com

Smoothie 03-26-2007 01:25 AM

Quote:

Originally Posted by Tralala (Post 1212077)
LOL! We're on the same page, dude. We both want to see the new feature introduced, yes?

Who's got the popcorn? Top notch support!

Dismounted 03-26-2007 11:10 AM

I'm trying to figure out this AJAX stuff and get it to work inline with my mod :p.

Dismounted 09-19-2007 07:58 AM

Hack Updated!

19/09/2007 - Version 1.2
- Automatic Template Edits
- Added Confirm When Double-Clicking Forum Icon
- Updated ReadMe

Doctor Death 09-19-2007 10:16 AM

Dismounted.... The upgrade instructions show what to remove from HeadInclude, but all other templates that you list dont have anything in the data blocks to find and remove.

Can you check this and repost it so I can finish the upgrade?

Thanks!

Dismounted 09-19-2007 11:53 AM

I've updated the ReadMe as I forgot that we had to put the original things back :p. And to answer your query, all the "Finds" were copied directly from the 1.1 ReadMe, so I don't know why you can't find them. In that case, take a fragment of the search string and look for that.

Doctor Death 09-19-2007 10:20 PM

Quote:

Originally Posted by Dismounted (Post 1342395)
I've updated the ReadMe as I forgot that we had to put the original things back :p. And to answer your query, all the "Finds" were copied directly from the 1.1 ReadMe, so I don't know why you can't find them. In that case, take a fragment of the search string and look for that.


Understand but I was not willing to make that assumption...

Appreciate the feedback.

Did you actually LOOK at your readme? It is not quite right :)

Dismounted 09-20-2007 06:32 AM

What's not quite right? The banner? I know about that issue :).

yoyoyoyo 09-22-2007 10:00 PM

This mod does not work on my 3.6.8 forum. The confirmation pops up, but no forums are being marked read,

athlon64bit 04-01-2008 12:39 AM

When viewing a category of forums, you don't get a prompt/confirmation to mark individual forums as read.:(

athlon64bit 01-24-2010 09:27 PM

Any plans for a vb 4 version of this? :) Anyone tested it on vb 4?


All times are GMT. The time now is 01:31 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01499 seconds
  • Memory Usage 1,838KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_code_printable
  • (3)bbcode_php_printable
  • (18)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (37)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete