vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Mini Mods - Email reminder for inactive users (https://vborg.vbsupport.ru/showthread.php?t=138946)

djbaxter 02-10-2007 07:04 PM

In the product XML file, what is this:

Quote:

<phrase name="setting_frequency_desc" date="1171120632" username="Chris" version="1.0.0"><![CDATA[How often to send a reminder email once a member has become inactive.]]></phrase>
Who is "Chris"?

C Braithwaite 02-10-2007 07:31 PM

Quote:

Originally Posted by djbaxter (Post 1179339)
In the product XML file, what is this:



Who is "Chris"?

That would be me.

Chadi 02-10-2007 08:34 PM

I just installed, manually ran scheduled task "emailreminders" and for some reason it only sent to about 20 people. I have 7,300 members and many have not logged in for a long time. How can this be?

rezapci 02-10-2007 08:59 PM

thanks for hack, but dude, how this ting works? I just installed it, what should I do next?

I cant find any Option on vbOption!

carpefile 02-10-2007 09:22 PM

Thanks a ton! Works a charm! *Installs

Chadi 02-10-2007 09:31 PM

This makes no sense. It even emails banned users. Please fix that. Thank you.

djbaxter 02-10-2007 10:17 PM

Quote:

It even emails banned users.
Yeah, that would not be good.

"We miss you. Please come back."

"Oops! You're banned. Just joking! :D"

rezapci 02-10-2007 10:22 PM

Quote:

Originally Posted by djbaxter (Post 1179476)
Yeah, that would not be good.

"We miss you. Please come back."

"Oops! You're banned. Just joking! :D"

hahahahah , what A JOKE :D

But how can I fix the YOURSITE? how can I edite the msg?

rezapci 02-10-2007 10:29 PM

god, someone tell how to fix this, it keep sending this to all memmbers as:

We've noticed that you've not been active on mished for quite some time now, and we miss you!
Could we not tempt you back?
If you don't remember your password, you can request it here: http://www.mished.co.uk/forum/login.php?do=lostpw
We hope to see you soon

Kindest Regards
YOURSITE


What a unprofessional Hack Installations Directions

what the world you don't explain right to all user step by step what the heck we should do man.!

crab

sdphotoforum 02-10-2007 10:29 PM

Anyway to send a test e-mail to myself? Just to make sure everything is working right?

sdphotoforum 02-10-2007 10:31 PM

Quote:

Originally Posted by rezapci (Post 1179485)
god, someone tell how to fix this, it keep sending this to all memmbers as:

We've noticed that you've not been active on mished for quite some time now, and we miss you!
Could we not tempt you back?
If you don't remember your password, you can request it here: http://www.mished.co.uk/forum/login.php?do=lostpw
We hope to see you soon

Kindest Regards
YOURSITE


What a unprofessional Hack Installations Directions

what the world you don't explain right to all user step by step what the heck we should do man.!

crab

Go to the Admin CP, Vbulletin Options, Inactive User Reminder E-Mails. You can edit it in there.

djbaxter 02-10-2007 10:36 PM

Quote:

Originally Posted by chadi
This makes no sense. It even emails banned users. Please fix that. Thank you.

Would this do it?

Find:

Code:

$result = $vbulletin->db->query_read("SELECT * FROM " . TABLE_PREFIX . "user WHERE lastactivity < '$datetime[lastpost]' AND emailDate < '$datetime[lastemail]' LIMIT $quantity");
$vbulletin->db->query_write("UPDATE " . TABLE_PREFIX . "user SET emailDate = '$now' WHERE lastactivity < '$datetime[lastpost]' AND emailDate < '$datetime[lastemail]' LIMIT $quantity");

Change to:

Code:

$result = $vbulletin->db->query_read("SELECT * FROM " . TABLE_PREFIX . "user WHERE lastactivity < '$datetime[lastpost]' AND . TABLE_PREFIX . "usergroup != 20 AND emailDate < '$datetime[lastemail]' LIMIT $quantity");
$vbulletin->db->query_write("UPDATE " . TABLE_PREFIX . "user SET emailDate = '$now' WHERE lastactivity < '$datetime[lastpost]'  AND . TABLE_PREFIX . "usergroup != 20 AND emailDate < '$datetime[lastemail]' LIMIT $quantity");


rezapci 02-10-2007 10:36 PM

Quote:

Originally Posted by djbaxter (Post 1179476)
Yeah, that would not be good.

"We miss you. Please come back."

"Oops! You're banned. Just joking! :D"

Quote:

Originally Posted by sdphotoforum (Post 1179488)
Go to the Admin CP, Vbulletin Options, Inactive User Reminder E-Mails. You can edit it in there.

Thank you , he supossed to explain it in first place which is he didn't!:down: :down: :down:

djbaxter 02-10-2007 10:40 PM

Quote:

Originally Posted by rezapci
What a unprofessional Hack Installations Directions

what the world you don't explain right to all user step by step what the heck we should do man.!

That's why I said earlier "not ready for prime time".

I think this addon has possibilities but it is just not ready for a live forum yet.

C Braithwaite 02-11-2007 04:26 AM

Quote:

Originally Posted by chadi (Post 1179413)
I just installed, manually ran scheduled task "emailreminders" and for some reason it only sent to about 20 people. I have 7,300 members and many have not logged in for a long time. How can this be?

it send emails out in small batches which can be amended in the options

Quote:

Originally Posted by rezapci (Post 1179423)
thanks for hack, but dude, how this ting works? I just installed it, what should I do next?

I cant find any Option on vbOption!

it's there.

Quote:

Originally Posted by rezapci (Post 1179485)
god, someone tell how to fix this, it keep sending this to all memmbers as:

We've noticed that you've not been active on mished for quite some time now, and we miss you!
Could we not tempt you back?
If you don't remember your password, you can request it here: http://www.mished.co.uk/forum/login.php?do=lostpw
We hope to see you soon

Kindest Regards
YOURSITE


What a unprofessional Hack Installations Directions

what the world you don't explain right to all user step by step what the heck we should do man.!

crab

I've given what i thought are ample instructions. upload, import, edit options. tell ya what - write you're own then eh?

Quote:

Originally Posted by djbaxter (Post 1179492)
Would this do it?

Find:

Code:

$result = $vbulletin->db->query_read("SELECT * FROM " . TABLE_PREFIX . "user WHERE lastactivity < '$datetime[lastpost]' AND emailDate < '$datetime[lastemail]' LIMIT $quantity");
$vbulletin->db->query_write("UPDATE " . TABLE_PREFIX . "user SET emailDate = '$now' WHERE lastactivity < '$datetime[lastpost]' AND emailDate < '$datetime[lastemail]' LIMIT $quantity");

Change to:

Code:

$result = $vbulletin->db->query_read("SELECT * FROM " . TABLE_PREFIX . "user WHERE lastactivity < '$datetime[lastpost]' AND . TABLE_PREFIX . "usergroup != 20 AND emailDate < '$datetime[lastemail]' LIMIT $quantity");
$vbulletin->db->query_write("UPDATE " . TABLE_PREFIX . "user SET emailDate = '$now' WHERE lastactivity < '$datetime[lastpost]'  AND . TABLE_PREFIX . "usergroup != 20 AND emailDate < '$datetime[lastemail]' LIMIT $quantity");


that is something i never thought of - i will update that in the php later today. cheers

C Braithwaite 02-11-2007 04:29 AM

Quote:

Originally Posted by rezapci (Post 1179493)
Thank you , he supossed to explain it in first place which is he didn't!:down: :down: :down:

if you read the first post:

Quote:


Ive updated the mod so all the settings are editable in the AdminCP
it's a simple plugin, not rocket science!

i designed it for my own forum, and it does the job i wanted it to do and i thought it may be useful for other people (which i might add, has beenk) so if anyone doesn't like it then just lump it.

WEBDosser 02-11-2007 05:28 AM

there are still some settings to change in product-remindermail.xml

Lines 61,64 & 68 need attention before uploading..

Masiello 02-11-2007 10:36 AM

Good idea, *clicked install*

Masiello 02-11-2007 10:58 AM

Hey, anobody can confirm please if this mod works too on a vB version 3.5.3?

djbaxter 02-11-2007 11:56 AM

Quote:

Originally Posted by C Braithwaite (Post 1179665)
that is something i never thought of - i will update that in the php later today. cheers

At the risk of telling you something you already know, I don't believe there is a "Banned" group by default in vBulletin - mine is ID=20 but it may be different for others so you'll need to make that a variable.

Chadi 02-11-2007 01:43 PM

I only want to email to usergroup ID 2 and 3. How can I set this up?

carpefile 02-11-2007 01:44 PM

Quote:

Originally Posted by djbaxter (Post 1179836)
At the risk of telling you something you already know, I don't believe there is a "Banned" group by default in vBulletin - mine is ID=20 but it may be different for others so you'll need to make that a variable.

I also got a parsing error when making that change. I only edited the usergroup to match my board's banned id.

@C Braithwaite- I'm not sure the cron job is running, it doesn't show in the log even though logging is enabled. It runs manually when you push the run button, but nothing in the log indicates it ran. I set it to run every ten minutes for 1 hour every night 100 mails per (just till it catches up with the 1500 or so inactive members, then will set it to run once weekly).

Also noticed there is no title, description, or log phrase listed in the scheduled task.

It may be running without making any log entries, I don't know.

Thanx again, once the bugs are ironed out, this will be extremely useful to a ton of peeps.

djbaxter 02-11-2007 02:14 PM

Quote:

Originally Posted by carpefile (Post 1179890)
I also got a parsing error when making that change. I only edited the usergroup to match my board's banned id.

OK. Good to know. I haven't actually yet tried my suggested modification yet - my first attempt at installing the addon (original version) crashed my email server - my fault for setting the number of emails too high but I'm now waiting for some of these bugs to be fixed before I reinstall.

Can you tell me what the parsing error was? What did it object to?

Quote:

Originally Posted by carpefile (Post 1179890)
once the bugs are ironed out, this will be extremely useful

It will indeed.

carpefile 02-11-2007 03:38 PM

unexpected t string error in line 19.

C Braithwaite 02-11-2007 03:42 PM

what i hope to do is create a list of usergroups and let you select which you send to.

i hope to iron out all bug, and ill look into the cron to see if it is running.

bazzup 02-11-2007 03:47 PM

installed tody and already got one lost member back good job

djbaxter 02-11-2007 04:40 PM

Quote:

Originally Posted by carpefile (Post 1179963)
unexpected t string error in line 19.

Of course. Sorry - left out a quotation mark. Try this (my example excludes two member groups for my forums) and uses lastactivity instead of lastpost:

Code:

$result = $vbulletin->db->query_read("SELECT * FROM " . TABLE_PREFIX . "user WHERE lastactivity < '$datetime[lastpost]' AND ". TABLE_PREFIX . "usergroup != 20  AND ". TABLE_PREFIX . "usergroup != 23 AND emailDate < '$datetime[lastemail]' LIMIT $quantity");
$vbulletin->db->query_write("UPDATE " . TABLE_PREFIX . "user SET emailDate = '$now' WHERE lastactivity < '$datetime[lastpost]'  AND ". TABLE_PREFIX . "usergroup != 20  AND ". TABLE_PREFIX . "usergroup != 23 AND emailDate
< '$datetime[lastemail]' LIMIT $quantity");

Edit: Sorry - that SQL syntax is also incorrect.

My head hurts - any SQL gurus here?

WEBDosser 02-11-2007 07:32 PM

cool.. uninstalled and re-installed the new version, looks a lot better :)

projectego 02-11-2007 09:57 PM

Thanks for the update. :)

BobbyBig 02-11-2007 10:01 PM

I took a look at your code - now I uninstalled this Mod. The frequency which can be set in the admincp is a lie.

Frequenzy just inceases the Time when the Email will be send again. It doesnt mean for "1" that it only will be send 1 time, but thats how you wrote it...

That means Inactive Users will receive the email every X days of not posting when Y days are over.

Also you ever thought about one thing: 15 Days Inactivity, Frequenzy 1, Emails Send: 50.
15*50 = 750

That means in this Period only 750 Inactive Users get the email, after this OTHER inactive users are not effected by this rule, instead the Users which allready received emails will receive email AGAIN.

You should work on the logic for that.

regards

C Braithwaite 02-12-2007 06:07 AM

Quote:

Originally Posted by BobbyBig (Post 1180226)
I took a look at your code - now I uninstalled this Mod. The frequency which can be set in the admincp is a lie.

Frequenzy just inceases the Time when the Email will be send again. It doesnt mean for "1" that it only will be send 1 time, but thats how you wrote it...

That means Inactive Users will receive the email every X days of not posting when Y days are over.

Also you ever thought about one thing: 15 Days Inactivity, Frequenzy 1, Emails Send: 50.
15*50 = 750

That means in this Period only 750 Inactive Users get the email, after this OTHER inactive users are not effected by this rule, instead the Users which allready received emails will receive email AGAIN.

You should work on the logic for that.

regards

i have no idea what you are talking about. there is a setting to set the inactivity period, how frequent the emails are sent once the inactivity period is entered, and how many emails to send at once.

for example, set the inactivity period to 7 days, then frequency to 3 days, once a person becomes inactive they will be sent an email every 3 days.

or you can set the inactivity period to 1 month, and set the reminder email to 90 days, and thus would send the reminder email every 90 days once a member had entered the inactivity period.

there is no lie. the plugin does exactly what it is supposed to do. the plugin description for frequency says "How often to send a reminder email once a member has become inactive."

"how often" being the operative words here, not "how many".

if you wish to send the email less than once a day set it to higher than 1.

idiot.

djbaxter 02-12-2007 06:16 AM

If you specify more than one usergroup ID, it sends out nothing.

C Braithwaite 02-12-2007 06:30 AM

Quote:

Originally Posted by djbaxter (Post 1180420)
If you specify more than one usergroup ID, it sends out nothing.

how are you writing the usergroups? 1,2,3,4 or 1, 2, 3, 4 etc?

C Braithwaite 02-12-2007 06:34 AM

Quote:

Originally Posted by djbaxter (Post 1180420)
If you specify more than one usergroup ID, it sends out nothing.

try it now, make sure it's x,y,z etc not z, y, x etc

HOST-KSA.COM 02-12-2007 03:22 PM

Hi,, I've a questuion..

If I have more than 20 thousands of members are inactive .. will this reminder affect my server ?

djbaxter 02-12-2007 03:29 PM

Quote:

Originally Posted by C Braithwaite (Post 1180423)
how are you writing the usergroups? 1,2,3,4 or 1, 2, 3, 4 etc?

I was using 1,2,3,4

djbaxter 02-12-2007 03:30 PM

Quote:

Originally Posted by C Braithwaite (Post 1180424)
try it now, make sure it's x,y,z etc not z, y, x etc

"Try it now" meaning you've updated the add-on? If so, what or which file has changed?

C Braithwaite 02-12-2007 03:31 PM

Quote:

Originally Posted by HOST-KSA.COM (Post 1180692)
Hi,, I've a questuion..

If I have more than 20 thousands of members are inactive .. will this reminder affect my server ?

I have designed it so you can limit the ammount of emails sent. 1, 5, 10, 100 - whatever you want.

It uses the mail function.

rezapci 02-12-2007 03:32 PM

Quote:

Database error in vBulletin 3.6.4:

Invalid SQL:

INSERT INTO setting
(varname, grouptitle, value, defaultvalue, datatype, optioncode, displayorder, advanced, volatile, validationcode, blacklist, product)
VALUES
(
'onoff',
'remindermail',
'1',
'no',
'free',
'yesno',
1,
0,
1,
'',
0,
'remindermail'
),
(
'inactivity',
'remindermail',
'7',
'7',
'number',
'',
1,
0,
1,
'',
0,
'remindermail'
),
(
'frequency',
'remindermail',
'3',
'3',
'number',
'',
2,
0,
1,
'',
0,
'remindermail'
),
(
'quantity',
'remindermail',
'3',
'3',
'number',
'',
12,
0,
1,
'',
0,
'remindermail'
),
(
'subject',
'remindermail',
'$username! We miss you!',
'$username! We miss you!',
'free',
'',
22,
0,
1,
'',
0,
'remindermail'
),
(
'message',
'remindermail',
'<p>Hello, $username!</p>\r\n<p>We\'ve noticed that you\'ve not been active on $bbtitle for quite some time now, \r\n and we miss you!</p>\r\n<p>Could we not tempt you back?</p>\r\n<p>If you don\'t remember your password, you can request it here: <a href=\"$forumurl/login.php?do=lostpw\">$forumurl/login.php?do=lostpw</a></p>\r\n<p>We hope to see you soon</p>\r\n<p>&nbsp;</p>\r\n<p>Kindest Regards</p>\r\n$bbtitle\r\n<p><a href=\"$homeurl\">$homeurl</a></p>',
'<p>Hello, $username!</p>\r\n<p>We\'ve noticed that you\'ve not been active on $bbtitle for quite some time now, \r\n and we miss you!</p>\r\n<p>Could we not tempt you back?</p>\r\n<p>If you don\'t remember your password, you can request it here: <a href=\"$forumurl/login.php?do=lostpw\">$forumurl/login.php?do=lostpw</a></p>\r\n<p>We hope to see you soon</p>\r\n<p>&nbsp;</p>\r\n<p>Kindest Regards</p>\r\n$bbtitle\r\n<p><a href=\"$homeurl\">$homeurl</a></p>',
'free',
'textarea',
32,
0,
1,
'',
0,
'remindermail'
),
(
'usergroups',
'remindermail',
'2',
'2',
'free',
'',
42,
0,
1,
'',
0,
'remindermail'
);

MySQL Error : Duplicate entry 'onoff' for key 1
Error Number : 1062
Date : Monday, February 12th 2007 @ 09:01:01 PM
Script : http://www.alshiatalk.com/vb/admincp...=productimport
Referrer : http://www.alshiatalk.com/vb/admincp...?do=productadd
IP Address : 70.252.137.29
Username : alghadeer
Classname : vb_database
whats wrong with this!? why cant I update or reinstall it?

C Braithwaite 02-12-2007 03:32 PM

Quote:

Originally Posted by djbaxter (Post 1180696)
"Try it now" meaning you've updated the add-on? If so, what or which file has changed?

reupload the php file - it was a bug in the coding.


All times are GMT. The time now is 01:02 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02165 seconds
  • Memory Usage 1,860KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_code_printable
  • (28)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete