vb.org Archive
Page 2 of 9 1 2 34 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Moderators Functions - Moderation Auto-PM v2.0.1 (https://vborg.vbsupport.ru/showthread.php?t=115677)

mat64 05-16-2006 02:47 PM
Love it, Installed.

Alan @ CIT 05-16-2006 04:38 PM
Moderation Auto-PM v1.0.1 has been released!

This version fixes the bug with the exclude forums list.

To upgrade, please upload the 3 PHP files, making sure to overwrite the old ones. There is no need to re-import the Product XML.

Thanks,
Alan.

P.S: Thanks to everyone who's installed the mod so far, and thanks to everyone for their kind words! :)

TheEDIGuy 05-16-2006 04:42 PM
I'd like to install this, but for very large boards, I think it needs some additional work. Anyone feel like taking this on?

1) PM sender is the moderator who actually did the action (there's no way I'm having every pm come from me).

2) Option, somehow, to not send them, especially for post deletions. And I'd love to see that option restricted by usergroups. So, for example, admins could delete posts without sending pm's, and forum mods couldn't.

3) A phrased paragraph to include, for each type of action. For example, for deletions we'd want to include an explanation of why posts are commonly deleted, who to address in case of questions, and a link to our FAQ. For moves, something different, and so on.

Also, I'd be interested in hearing whether this sends a user a PM if they have their PM's turned off, especially if they have their "receive administrative notices" turned off. And also, what it does if the user's PM box is full.

Alan @ CIT 05-16-2006 04:46 PM
Hi,

Quote:
Originally Posted by TheEDIGuy
1) PM sender is the moderator who actually did the action (there's no way I'm having every pm come from me).
That's the default setting with this mod :) If you don't specifiy a username, it sends it from the moderators.

Quote:
Originally Posted by TheEDIGuy
2) Option, somehow, to not send them, especially for post deletions. And I'd love to see that option restricted by usergroups. So, for example, admins could delete posts without sending pm's, and forum mods couldn't.
Adding a "Send PM" popup is on the todo list for a later version - don't quote me on that though :)

Quote:
Originally Posted by TheEDIGuy
3) A phrased paragraph to include, for each type of action. For example, for deletions we'd want to include an explanation of why posts are commonly deleted, who to address in case of questions, and a link to our FAQ. For moves, something different, and so on.
Each action / type is an individual phrase, so you could do that now just by editing the phrases.

Quote:
Originally Posted by TheEDIGuy
Also, I'd be interested in hearing whether this sends a user a PM if they have their PM's turned off, especially if they have their "receive administrative notices" turned off. And also, what it does if the user's PM box is full.
The only time it doesn't send a PM is if PM's are globally turned off in the vB options. Other than that, it forces the PM through whether they have PM's turned off, or their inbox is full.

Edit: Actually, I'm not sure on that last part about forcing the PM through. It will force the PM through, but if they've got PM's turned off, I don't believe it will as they'll never see it. I'll have to test it and see.

Thanks,
Alan.

TheEDIGuy 05-16-2006 04:49 PM
Thanks, Alan. That helps a lot. If that pop-up did appear in a later version, you couldn't get me to click install fast enough :)

For now, I'm going to have to weigh the pros and cons, because we do a lot of small maintenance that we really don't want notices going out for.

JD45 05-16-2006 04:55 PM
Quote:
Originally Posted by EvilHawk
[high]* EvilHawk clicks "Nominate for Mod of the month"[/high]
ditto and installed..:D

Acers 05-16-2006 04:56 PM
umm does it work for soft deletes?
i don' seem to get any pm's for soft deleted threads

Stop 05-16-2006 05:12 PM
It works for all.
Works very fine after the update.
Thanks loads MR. No doubt it will be the hack of the month.

Alan @ CIT 05-16-2006 05:29 PM
Quote:
Originally Posted by Acers
umm does it work for soft deletes?
i don' seem to get any pm's for soft deleted threads
Yep, seems to work ok here.

Are you certain the forum you are deleting the thread in, isn't in the Exclude Forums list?

Also, does it do anything if you hard-delete the thread?

Thanks,
Alan.

Harley77 05-16-2006 07:40 PM
When moving a thread, if the thread is moved to a forum the user cannot see or access, does it still send them a PM showing where it was moved to?

Alan @ CIT 05-16-2006 07:42 PM
It will still send them a PM telling them the thread was moved, but does not tell them where it was moved to.

The same applies if they cannot see the forum the thread was in (ie, you moved it to an admin area, and are moving it back to public), it will tell them the destination forum, but not the forum it was in (the admin one).

Thanks,
Alan.

Sidewindr 05-16-2006 11:15 PM
Thanks for the update, I have uploaded it and will test later today :D

Acers 05-17-2006 12:59 AM
Quote:
Originally Posted by Alan @ CIT
Yep, seems to work ok here.

Are you certain the forum you are deleting the thread in, isn't in the Exclude Forums list?

Also, does it do anything if you hard-delete the thread?

Thanks,
Alan.
hi..
well thread soft delete works fine

in the posts both the soft and physically remove are not working, all are set to yes in admincp options.
i have no forums in excluded forums list

thanks for support m8 btw.. good job
(using 1.01 version although vb is 3.5.2 so maybe that can be the issue if yours working)

Alan @ CIT 05-17-2006 06:46 AM
Hi Acers,

Hmm.. I'm at a bit of a loss I'm afraid. All seems to be working ok here.

How are you deleting the posts? Are you selecting them with the tickbox then using the inline moderation menu to delete them? Or some other way?

Also, if you get a chance, could you check your AdminCP -> Plugins for me please, and check that you have one called:

Mod Auto-PM :: Inline :: Post :: Delete

This should be using the hook inlinemod_start. Are there any other plugins listed that use that hook?

Thanks,
Alan.

Boofo 05-17-2006 08:13 AM
Alan, is there a way to includes all the setting under one main setting group. It would be easier than going to 4 different settings group to set this up. Maybe like a main setting group and 4 setting groups under that. ;)

And excellent job, by the way. ;)

Alan @ CIT 05-17-2006 08:15 AM
That's how it was originally, but as I added more and more settings, it became unmanagable :)

All settings are by default set to yes, and in theory you should only have to visit each setting once, and that's only if you want to set it to No, so it shouldn't be too bad :D

Boofo 05-17-2006 08:24 AM
Maybe having them set to No as default would be better in case someone installed this and didn't do the settings right off the bat. I know when I installed it I had like a zillion IM windows open (I use Trillian) and was working on adding forums and threads on the site all at the same time. ;)

Also, I use Andreas' auto-moderation hack for posts. Will this send notices for any posts that hack sends to moderation? I would like to have the option for that, if at all possible, unless it already does it. Then that would make this request kind a moot. ;)

Alan @ CIT 05-17-2006 09:59 AM
Quote:
Originally Posted by Boofo
Also, I use Andreas' auto-moderation hack for posts. Will this send notices for any posts that hack sends to moderation? I would like to have the option for that, if at all possible, unless it already does it. Then that would make this request kind a moot. ;)
Do you have a link to that hack?

Thanks,
Alan.

Acers 05-17-2006 01:04 PM
Quote:
How are you deleting the posts? Are you selecting them with the tickbox then using the inline moderation menu to delete them? Or some other way?
thats it.. no i am using the edit post method. the post i wanna delete.. click edit(opens the quick reply ajax based editor) then click delete)(soft delete) and it fails this way.

Attachment 47668


anyway the fix is to add this plugin also
(tested and working)

in hook location: editpost_delete_complete
add
PHP Code:
if ($_POST['do'] == 'deletepost')
{
    $vbulletin->input->clean_array_gpc('p', array(
        'reason'    => TYPE_STR
    ));

    // Fetch posts
    $post = $db->query_first("
        SELECT post.postid, post.threadid, post.parentid, post.visible, post.title,
            thread.forumid, thread.title AS thread_title, thread.postuserid, thread.firstpostid, thread.visible AS thread_visible
        FROM " . TABLE_PREFIX . "post AS post
        LEFT JOIN " . TABLE_PREFIX . "thread AS thread USING (threadid)
        WHERE postid = $postid
    ");


    include_once(DIR . '/includes/class_autopm_checker.php');
    include_once(DIR . '/includes/class_autopm_parser.php');
    include_once(DIR . '/includes/functions_autopm.php');

    mod_autopm($postid, 'delete', 'post', $post['threadid'], 0, $vbulletin->GPC['reason']);

} 
;)

Alan @ CIT 05-17-2006 01:38 PM
Ahh, I see. It currently only has support for the Thread Tools menu, and the Inline Moderation dropdown. I'll see about adding support for other options in a future version.

Glad to see you've got it working though :)

Thanks,
Alan.

Boofo 05-17-2006 01:44 PM
Quote:
Originally Posted by Alan @ CIT
Do you have a link to that hack?

Thanks,
Alan.
Here you go, sir. ;)

https://vborg.vbsupport.ru/showthread.php?t=93934

Alan @ CIT 05-17-2006 01:49 PM
Moderation Auto-PM won't send PMs for changes made by Kirby's hack, but I'll see what I can do to add support for it in a future version - no promises though :D

Thanks,
Alan.

Boofo 05-17-2006 01:55 PM
Quote:
Originally Posted by Alan @ CIT
Moderation Auto-PM won't send PMs for changes made by Kirby's hack, but I'll see what I can do to add support for it in a future version - no promises though :D

Thanks,
Alan.
I would appreciate it, sir. ;)

Thank you. ;)

Boofo 05-17-2006 01:56 PM
Quote:
Originally Posted by Alan @ CIT
Ahh, I see. It currently only has support for the Thread Tools menu, and the Inline Moderation dropdown. I'll see about adding support for other options in a future version.

Glad to see you've got it working though :)

Thanks,
Alan.
Is it ok to add that code then?

Boofo 05-17-2006 01:58 PM
Quote:
Originally Posted by Acers
thats it.. no i am using the edit post method. the post i wanna delete.. click edit(opens the quick reply ajax based editor) then click delete)(soft delete) and it fails this way.

Attachment 47668


anyway the fix is to add this plugin also
(tested and working)

in hook location: editpost_delete_complete
add
PHP Code:
if ($_POST['do'] == 'deletepost')
{
$vbulletin->input->clean_array_gpc('p', array(
'reason' => TYPE_STR
));
 
// Fetch posts
$post = $db->query_first("
SELECT post.postid, post.threadid, post.parentid, post.visible, post.title,
thread.forumid, thread.title AS thread_title, thread.postuserid, thread.firstpostid, thread.visible AS thread_visible
FROM " . TABLE_PREFIX . "post AS post
LEFT JOIN " . TABLE_PREFIX . "thread AS thread USING (threadid)
WHERE postid = $postid
");
 
 
include_once(DIR . '/includes/class_autopm_checker.php');
include_once(DIR . '/includes/class_autopm_parser.php');
include_once(DIR . '/includes/functions_autopm.php');
 
mod_autopm($postid, 'delete', 'post', $post['threadid'], 0, $vbulletin->GPC['reason']);
 
} 
;)
Does this cover both hard-delete and soft-delete?

Acers 05-17-2006 03:08 PM
its covering only soft delete as of now.. thats cos i added it to delete_complete hook

you can add to editpost_delete_start
to cover for hard deletes also but then add the can_moderate checks also as it might..(i use the word might) happen that the pm might be sent when the actual deletion errors out due to say a permission prob.. highly unlikely but well on my board i give only soft delete permissions so i didn't take the chance.

but yeah inserting above code to editpost_delete_start should cover for both the soft and hard deletes :)

Boofo 05-17-2006 03:18 PM
Quote:
Originally Posted by Acers
its covering only soft delete as of now.. thats cos i added it to delete_complete hook

you can add to editpost_delete_start
to cover for hard deletes also but then add the can_moderate checks also as it might..(i use the word might) happen that the pm might be sent when the actual deletion errors out due to say a permission prob.. highly unlikely but well on my board i give only soft delete permissions so i didn't take the chance.

but yeah inserting above code to editpost_delete_start should cover for both the soft and hard deletes :)
I'll stick with the way you are doing it then. I only want Admins to be able to hard delete on my site anyway, so we should be all set with your code. And thank you for posting it, sir. ;)

Not to sound ignorant here, but how do I set it so only Admins can hard-delete posts and threads? I don't think I've ever bothered with that before, to tell you the truth, or I don't remember dealing with it, anyway.

Acers 05-17-2006 03:35 PM
forum manager->add moderator->see the screen ;)
Attachment 47681

Gaskell 05-17-2006 03:43 PM
I like the look of this mod and will have a play around with it :)

Use it alongside vBPunch for quick warnings on things that dont need an edit (or whatever) and it will make moderating canny easy :)

Cheers.

Noonster 05-17-2006 03:46 PM
This doesnt work with the following hack
- "Adv. Editing Options for Mods and Admins"

:(

Tralala 05-17-2006 04:09 PM
Quote:
Originally Posted by Noonster
This doesnt work with the following hack
- "Adv. Editing Options for Mods and Admins"
This one?
https://vborg.vbsupport.ru/showthread.php?t=98737

What happens when you try it?

Alan @ CIT 05-17-2006 06:40 PM
Quote:
Originally Posted by Noonster
This doesnt work with the following hack
- "Adv. Editing Options for Mods and Admins"

:(
I've just looked at the code for the hack you mentioned, and there is no code in that hack that would stop this one working. The same is true of the code in my hack - it shouldn't stop that hack working.

As previously mentioned, this hack won't send a PM when the post is edited, whether that hack is installed or not I'm afraid.

Thanks,
Alan.

devilrulez 05-18-2006 05:44 AM
Thanks... nice one

Keyser S?ze 05-18-2006 06:12 AM
that is a sweet hack, seems to work great

almqdad 05-18-2006 11:39 AM
Hi

forum name in the pm comes as garbej

the rest of the pm txt is fine

my forum is arabic

popowich 05-18-2006 04:57 PM
Would it be possible to add an exclude groups in the future?

Similar to exclude forums, but so I can exclude admins and moderators from receiving PM's from each other.

-Raymond

Alan @ CIT 05-18-2006 06:29 PM
Raymond,

I'll add it to the list for a future version, no pomises though :)

Thanks,
Alan.

bada_bing 05-18-2006 06:59 PM
This looks great.... I will install this week..

Xajel 05-20-2006 09:26 AM
I was waiting for this update for a long time

thanks Alan ;)


INSTALL clicked ;)

kartik786 05-20-2006 07:40 PM
works on 3.5.3 ?


All times are GMT. The time now is 12:53 PM.
Page 2 of 9 1 2 34 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01616 seconds
  • Memory Usage 1,853KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php_printable
  • (16)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete