Not necessarily, a user with an id 0 is by definition unregistered. A guest goes in the appropriate usergroup but they still have a userid of 0.

well he decided he wanted the usercp to hide so I moded my working script to this:

//regbutton
$regbutton="<a href=\"usercp.php?s=$session[sessionhash]\"><img src=\"{imagesfolder}/top_profile.gif\" alt=\"Here you can view your subscribed threads, work with private messages and edit your profile and preferences\" border=\"0\"></a>";
if ($bbuserinfo['userid']<"1") {
$regbutton="<a href=\"register.php?s=$session[sessionhash]&action=signup\"><img src=\"darkblue/top_register.gif\" alt=\"Registration is free!\" border=\"0\"></a>";
}
//end

I might use your else.. code thx for your guys help

The else is just my style of coding, ive always done it like that. And no problem :)