vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Advanced Warning System (AWS) (https://vborg.vbsupport.ru/forumdisplay.php?f=105)
-   -   Warning Bug - 3.4.6 (https://vborg.vbsupport.ru/showthread.php?t=80573)

sv1cec 05-31-2005 05:41 PM

Exitilus, have you defined any warning types? And have you specified which one of them are non-post related?

Rgds

Exitilus 05-31-2005 08:37 PM

Aye. I created a Warning Called Bot. With 5 Warning Points (Which is the # set to Ban a User) and set Perma Ban to Yes

I set the Alert to NO. Even if I Disable Alerts. It still won't work and gives the same error message :|

sv1cec 06-01-2005 03:11 AM

I am not sure what to tell you. This error is coming from the hack files, not the ones of vB that you have edited, so it appears that either (a) something is wrong with the file or (b) something is wrong with your settings. If you want, give me access to your system and I'll try to figure it out (if it is not too well hidden).

To be on the safe side, please upgrade to the latest version.

Rgds

zell_11 06-04-2005 07:22 AM

I am getting the exact same problem

sv1cec 06-04-2005 11:18 AM

Please be a little more specific. What problem? And which version of AWS are you currently running? If you are not running the latest, please upgrade to the latest version first and then see if the problem persists.

Rgds

kmike 06-07-2005 06:02 AM

Well, I see that the handling of alerts in the code is very prone to errors. It's in fact so broken that I don't even know how to start fixing it. I just put some bandaid hacks which disabled alerts altogether for us, as we don't need them.

First of all, the "alert" hidden form field in WarnUserNoPost and WarnUser forms (warn_addwarn and warn_addwarn_nopost templates) is never initialized at all, if alerts are disabled. It is supposed to be set to $_GET['alert'], but if alerts are disabled, no &alert=... parameter is being passed in URL to the forms, so "alert" form field stays empty.

So following the chain of events, this causes $alert global variable to be always empty in Warn.php script, in DoWarnUser and DoWarnUserNoPost sections. This in turn sets "if ($alert=='No')" condition in warn_calculations() function to true ($alert is empty, so it's not equal to "No"), and the execution of the script follows completely wrong code path from here, causing that bogus "This Warning Type does not allow you to issue an Alert." error.

All checks for $alert=='No' which are sprinkled all over the code are susceptible to this, too.
Part of the problem is an initial extremely bad database design decision - instead of using integer for a flag type db fields (alert, ban, etc), these fields are strings, and defaults to NULL, so in fact they could be in the 3 states: "Yes", "No" and NULL (or empty). This causes many problems and greatly encumbers the code as checks for empty values should be added everywhere.

sv1cec 06-07-2005 06:35 AM


kmike 06-07-2005 07:02 AM


sv1cec 06-07-2005 07:04 AM

Yes, it would, but I need time to change the code. I wanted to bring out a release which would fix the errors the users encountered. I plan to do a code-maintenance release in the next few days, where several areas of the code will be improved. If you have any other comments, I would appreciate if you could let me know.

Rgds


All times are GMT. The time now is 04:01 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02361 seconds
  • Memory Usage 1,722KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (9)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete