vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   RPG Integration Hack (https://vborg.vbsupport.ru/forumdisplay.php?f=102)
-   -   Bug or install error? (https://vborg.vbsupport.ru/showthread.php?t=76427)

Revan 02-26-2005 03:28 PM

Armor (please note the difference between Armor and Shield type) are currently not being prohibited, yes.
The fix is hassle to test, so I didn't, but you feel free to test it for me.

File: battleupdate.php
Find (BOTH instances of):
PHP Code:

                    rpgrace

Add BELOW:
PHP Code:

                    rpgtype

Find:
PHP Code:

                    $defense $DB_site->query_first("SELECT damage FROM " TABLE_PREFIX "rpg_items WHERE itemid='$opparmor[id]'");
                    if (
$defense['damage'] > 0
                    {
                        
$armor $armor $defense['damage'];
                    } 

Replace with:
PHP Code:

                    $defense $DB_site->query_first("SELECT damage, type FROM " TABLE_PREFIX "rpg_items WHERE itemid='$opparmor[id]'");
                    if (
$defense['damage'] > 0
                    {
                        
$opparmortype explode(' '$defense['type']);
                        if (
in_array($opponent['rpgtype'], $opparmortype))
                        {
                            
$armor $armor $defense['damage'];
                        }
                    } 

IMPORTANT: To test this fix, do the following BEFORE doing the above:
  1. Set $battledebug to 1 in battleupdate.php
  2. Make yourself have armor your not supposed to have
  3. Let both combatants have weapons they ARE supposed to have
  4. Let your opponent attack you (thus having your illegal armor reduce the damage
  5. Note down the second last Debug Variable under Damage Done
  6. Apply the fix
  7. Upload the file
  8. Let your opponent attack you (thus in theory having the armor not count)
  9. Compare the second last Debug Variable under Damage Done to the value you saw before
If the fix worked, the Armor should have no effect.

PS: I will add an error message like the "your weapon is for a different class" in v3.

Thanks for helping me make this hack better :)


//peace

Cyricx 02-28-2005 04:59 PM

Nope, didn't do the trick, didn't get an error or anything, but the debugs stayed the same.

Before the fix -

Debug Variables:
Anger ($anger): 1
Hit Chance ($hitchance): 0.49279003035213
Random Number ($randnum): 35
Regular Attack Bonus ($regattbonus): 6.0456592223288
Regular Defense Minus ($regdefminus): 3.145988105131
Damage Done ($damagedone): -1 == [floor((28 + 6.0456592223288) * 0.5 * 1 + 0 - 14 - 3.145988105131)]
Random Mad ($randmad): 10

After the fix -
Debug Variables:
Anger ($anger): 1
Hit Chance ($hitchance): 0.49279003035213
Random Number ($randnum): 22
Regular Attack Bonus ($regattbonus): 6.0456592223288
Regular Defense Minus ($regdefminus): 3.145988105131
Damage Done ($damagedone): -1 == [floor((28 + 6.0456592223288) * 0.5 * 1 + 0 - 14 - 3.145988105131)]
Random Mad ($randmad): 8

Revan 02-28-2005 07:36 PM

Goddamit!
Ok guess I have tomorrow's work cut out for me then :p
I'll either edit this post or make a new reply
because Im gonna fuggen do this even if it's the last thing I do! :p

Cyricx 03-01-2005 01:12 AM

Hehe, I'll happily test out anything you need bro :)

I can add in hacks like crazy, but when it comes to writting arrays and explode and all that my mind fragments into a trillion pieces ;)

Revan 03-01-2005 03:17 PM

Well I can say that the fix works.
I just applied it, and here's the results:

BEFORE the fix:
Damage Done ($damagedone): 166 == [floor((82 + 839.48094618951) * 1 * 1 + 0 - 0 - 756.75105588525)]


AFTER the fix:
Damage Done ($damagedone): 109 == [floor((82 + 839.48094618951) * 1 * 1 + 0 - 54 - 756.75105588525)]

And 54 IS indeed the buff value I set the Armor I tested it with to be.

Cyricx 03-01-2005 04:13 PM

I'll double check my values on test. See if I can find out what I did wrong incase someone else repeats my mistake.


All times are GMT. The time now is 08:00 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02390 seconds
  • Memory Usage 1,741KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (6)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete