vb.org Archive - search.php - help needed

Page 2 of 3

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)

- - search.php - help needed - "getdaily" (https://vborg.vbsupport.ru/showthread.php?t=73834)

amykhar

01-06-2005 12:46 AM

For one thing, your equation is wrong. If you were trying to find posts from 2 days and 3 hours ago, which is possible to do, you would end up with
2*3*60*60, which isn't right.

What you need to do is to say that if hours, minutes, days, etc. aren't set, they are equal to 0.

Then, your math looks like (days *24*60*60) + (hours *60*60) + (minutes*60) + seconds.

trevelyn1015

01-06-2005 01:34 AM

so, amy, why does everything work fine, but minutes?

www.ranger-forums.com/forum2

amykhar

01-06-2005 02:07 AM

It won't work for seconds.

You got lucky with hours, because days is set to 1.

The equation for hours is TIMENOW - ($hours *60*60)

because there are 60 minutes in an hour and 60 seconds in a minute.

Anything bigger than an hour isn't a problem because your math holds true. The problem is with the minutes and seconds.

trevelyn1015

01-06-2005 02:43 AM

so what should i do, amy?

the original string of code for that section looked like this:

Code:

// #############################################################################

if ($_REQUEST['do'] == 'getnew' OR $_REQUEST['do'] == 'getdaily')

{

        globalize($_REQUEST, array(

                'forumid' => INT,

                'days' => INT,

                'exclude' => STR

        ));



        // get date:

        if ($_REQUEST['do'] == 'getnew' AND $bbuserinfo['lastvisit'] != 0)

        {

                // if action = getnew and last visit date is set

                $datecut = $bbuserinfo['lastvisit'];

        }

        else

        {

                $_REQUEST['do'] = 'getdaily';

                if ($days < 1)

                {

                        $days = 1;

                }

                $datecut = TIMENOW - (24 * 60 * 60 * $days);

        }

sabret00the

01-06-2005 08:40 AM

PHP Code:


		
			
     if ($_REQUEST['do'] == 'getnew' AND $bbuserinfo['lastvisit'] != 0)

     {

          // if action = getnew and last visit date is set

          $datecut = $bbuserinfo['lastvisit'];

     }

     else

     {

          $_REQUEST['do'] = 'getdaily';

          if ($days < 1)

          {

               $days = 1;

          }



          if (!$hours)

          {

               $hours = 0;

          }



          if (!$minutes)

          {

               $minutes = 0;

          }

          $datecut = TIMENOW - ($hours * $minutes * 0 * $days);

     }

ok if i half understood what amy's saying, she's saying try that :)

Dean C

01-06-2005 10:21 AM

You can't default the variables to 0, that'll make it TIMENOW - 0 when you multiply anything by it. :)

amykhar

01-06-2005 10:53 AM

Quote:

Originally Posted by Dean C

You can't default the variables to 0, that'll make it TIMENOW - 0 when you multiply anything by it. :)

Exactly, Dean. That's what you want to happen.

And, no Saber. That's not what I was saying :) My board is down right now so I can't test this, but I imagine it would look like this:

Code:

        else

        {

                $_REQUEST['do'] = 'getdaily';

                if (($days < 1)AND(!$hours)AND(!$minutes)AND(!$seconds))

                {

                        $days = 1;

                        $hours = 0;

                         $minutes = 0;

                         $seconds = 0;

                        

                }

                elseif($days < 1) {

                       $days = 0;

                }

                $datecut = TIMENOW - (($days*24*60*60) + ($hours*60*60) + ($minutes*60) + $seconds);

                

        }

Doing it this way doesn't mess up the original usage - if no variables are set, it should default to 1 day. If any combination of days, hours or minutes are set though, it should work.

Within that elseif block, you should check to see if the hours, minutes and seconds are properly set and initialize them to 0 if not.

amykhar

01-06-2005 01:02 PM

my site's back up, and it seems like it works as I posted it.

trevelyn1015

01-06-2005 05:11 PM

amykhar is my hero!!!

sabret00the

01-06-2005 05:13 PM

Quote:

Originally Posted by amykhar

my site's back up, and it seems like it works as I posted it.

your smarts >>>>>>>>>>> mine :p

All times are GMT. The time now is 12:22 AM.

Page 2 of 3

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01927 seconds Memory Usage 1,748KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (1)bbcode_php_printable (2)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (2)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: