vb.org Archive
Page 2 of 15 1 2 3412 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.0 Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=33)
-   -   MultiQuote (https://vborg.vbsupport.ru/showthread.php?t=59702)

Chroder 01-05-2004 05:17 AM
Quote:
Originally Posted by mtellin
I already un-installed it without thinking, but I got a SQL error when I clicked the quote button, then unclick it and hit the post reply button...anyone else get this?
Your fast :p I was right in the middle of fixing it when you posted ;) Anyway, see first post and you can download the new file. Only the code in newreply.php was updated. (You'll see an 'updated' text next to it in the HTML instructions).

mtellin 01-05-2004 05:41 AM
Quote:
Originally Posted by Chroder
Your fast :p I was right in the middle of fixing it when you posted ;) Anyway, see first post and you can download the new file. Only the code in newreply.php was updated. (You'll see an 'updated' text next to it in the HTML instructions).
:) thanks, did the trick

NuclioN 01-05-2004 09:00 AM
When quoting (after the updated file) and reply with quick reply another mysql error:

Database error in vBulletin 3.0.0 Release Candidate 1:

Invalid SQL: SELECT postid, username, pagetext FROM vb3_post WHERE postid IN(6566,6568) AND postid <> ORDER BY postid ASC
mysql error: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY postid ASC' at line 1

mysql error number: 1064

Chroder 01-05-2004 10:03 PM
Another update that deals with these things more cleanly. I'm working on an addition that'll allow the "go advance" in the QR to also have all the quotes.

Change the newreply.php code to the following:

PHP Code:
//############################################################################
 //# START MULTI QUOTE                                                     #
  //############################################################################
  if(isset($_COOKIE[COOKIE_PREFIX . 'mq']))
  {
      $pids = $_COOKIE[COOKIE_PREFIX . 'mq'];
      $pids = urldecode($pids);
  
      if(!empty($pids) && preg_match("/^[0-9,]+$/", $pids))
      {
         $mq_postid = (empty($_REQUEST['noquote']) ? "AND postid <> {$postinfo['postid']}" : '');
          
         $q = $DB_site->query("SELECT postid, username, pagetext FROM ".TABLE_PREFIX."post WHERE postid IN($pids) $mq_postid ORDER BY postid ASC LIMIT 20");
          while($row = $DB_site->fetch_array($q))
          {
             $originalposter = fetch_quote_username($row['username']);
              $pagetext = htmlspecialchars_uni($row['pagetext']);
              $pagetext = trim(strip_quotes($pagetext));
          eval('$newpost[\'message\'] .= "' . fetch_template('newpost_quote', 1, 0) . '\n";');
          }
      }
  
     setcookie(COOKIE_PREFIX . 'mq', '', time() - 3600, $vboptions['cookiepath'], $vboptions['cookiedomain']);
  }
  //############################################################################
 //# END MULTI QUOTE                                                         #
  //############################################################################ 
This should fix all mysql errors recieved above, on my test board it seemed to do fine :) It also now checks that the $pids is only numbers/commas so there are no tricky users trying to screw up the board.

[Updated file uploaded in first post]

mtellin 01-05-2004 10:22 PM
I still get one error with this, when I click the multi quote button and then click go advanced I get this:

Database error in vBulletin 3.0.0 Release Candidate 1:

Invalid SQL: SELECT postid, username, pagetext FROM post WHERE postid IN(19123) AND postid <> ORDER BY postid ASC LIMIT 20
mysql error: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY postid ASC LIMIT 20' at line 1

mysql error number: 1064

EDIT: looks like NuclioN already posted this

Chroder 01-05-2004 11:43 PM
I can't recreate this problem on my localhost, so I asume this was prior to the Jan05-2 update? So its fixed -- correct?

mtellin 01-05-2004 11:49 PM
Quote:
Originally Posted by Chroder
I can't recreate this problem on my localhost, so I asume this was prior to the Jan05-2 update? So its fixed -- correct?
in my case it wasnt, thats with your latest version that you have :(

BillaBongUSA 01-06-2004 12:01 AM
Yeah, I just updated everything with the new code that you just posted, and I'm getting the same error when I click on the "Go Advanced" button.

NuclioN 01-06-2004 12:20 AM
The go advanced button is producing this error but after your last update the quick reply gives that error again. I hope you can fix it because this is a great addition. :)

Chroder 01-06-2004 01:43 AM
Ok, clicking MQ button followed by a "Go Advanced" in the QR gives an error? I think I've found it, forgot a '!' on a line. But before I make an 'update' would someone please try it? :p

PHP Code:
//############################################################################
 //# START MULTI QUOTE                                                     #
  //############################################################################
  if(isset($_COOKIE[COOKIE_PREFIX . 'mq']))
  {
      $pids = $_COOKIE[COOKIE_PREFIX . 'mq'];
      $pids = urldecode($pids);
  
      if(!empty($pids) && preg_match("/^[0-9,]+$/", $pids))
      {
         $mq_postid = (!empty($_REQUEST['noquote']) ? "AND postid <> {$postinfo['postid']}" : '');
          
         $q = $DB_site->query("SELECT postid, username, pagetext FROM ".TABLE_PREFIX."post WHERE postid IN($pids) $mq_postid ORDER BY postid ASC LIMIT 20");
          while($row = $DB_site->fetch_array($q))
          {
             $originalposter = fetch_quote_username($row['username']);
              $pagetext = htmlspecialchars_uni($row['pagetext']);
              $pagetext = trim(strip_quotes($pagetext));
          eval('$newpost[\'message\'] .= "' . fetch_template('newpost_quote', 1, 0) . '\n";');
          }
      }
  
     setcookie(COOKIE_PREFIX . 'mq', '', time() - 3600, $vboptions['cookiepath'], $vboptions['cookiedomain']);
  }
  //############################################################################
 //# END MULTI QUOTE                                                         #
  //############################################################################ 
Sorry if even this doesn't work. Not thinking clearly today. :tired:

// edit. yep, the correct code..


All times are GMT. The time now is 07:31 AM.
Page 2 of 15 1 2 3412 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01797 seconds
  • Memory Usage 1,775KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php_printable
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete