vb.org Archive
Page 2 of 3 1 2 3
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 2.x Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=4)
-   -   Attachments show up as links if larger than a certain size. (https://vborg.vbsupport.ru/showthread.php?t=36828)

freakyshiat 04-02-2002 10:07 PM
I think it still adds another query per attachment Zzed.. but its cool for now, more than what I had before :)

Zzed 04-03-2002 07:33 AM
I think that given the fact that not every post has an attachment, the query in showthread.php will have to make an unnecessary hit to the database for every post.

FireFly's idea to use the LENGTH() function was quite ingenious because what comes back from the query within the hack is an integer and not a block of data.

freakyshiat 05-12-2002 06:09 PM
Quote:
Originally posted by FireFly
Very nice. :)
Although, I think you should use LENGTH() directly in MySQL as I think it will be faster than catching the data for PHP. And, you should also do this query in showthread.php, in that huge query that gets all the info. That way you don't need to add another query for every attachment you have in the thread. Good job nonetheless! :)
could you tell me how do to do that? :o

Smoothie 05-12-2002 10:32 PM
question, so if what you have set as an attachment limit on file size in your admin cp, this over rides that, and shows a link to the attached file? Say for example I have a larger file size limit set in the admin cp than what is allowed in this hack.

freakyshiat 05-13-2002 03:19 PM
I have it set to 100k in the CP ; in the hack it is set to 50k ; so files under 50k shows up as pic, over 50k and under 100k as a link

Firefly, Help :o

Mutt 05-13-2002 07:28 PM
i've been thinking about installing a version of this, but instead of checking the lenght every time, I was going to add a new row to the attachment table and storing the size there when the file is attached. dimensions are checked then anyway. then just check the stored value in the db when the page is loaded. would there be any down side to doing it this way?

Boofo 06-07-2002 01:31 PM
Yes, I would be VERY intersted on making the size configurable. This is almost excatly what I have been looking for. Is there any way to maybe have it show the size of the attachment in the message itself right next to the word "Attachment"? Like in kb size? :)

Quote:
Originally posted by Zzed
Note: I have revised this hack to use the MySql LENGTH() function.

This hack alters the attachment view property. If the size of the attached
image is larger than a specified size, the attachment will show up as a
hyperlink as opposed to the actual image.

The size limit for the time being is hardcoded at 50000. I know I should
have made it configurable. My apologies. :( I will work on it if anyone is
interested.

This hack was requested by Fzale.

Here are the instructions on how to implement it.

In admin/functions.php, look for the following text:
PHP Code:
        if ($post[attachmentid]!=0 and $post[attachmentvisible]) {
                $post[attachmentextension]=strtolower(getextension($post[filename]));
                if ($post[attachmentextension]=="gif" or $post[attachmentextension]=="jpg" or $post[attachmentextension]=="jpeg" or $post[attac\
hmentextension]=="jpe" or $post[attachmentextension]=="png") {
                        if (($viewattachedimages) and ($bbuserinfo[userid]==0 or $bbuserinfo[showimages])) {
                                eval("\$post[attachment] = \"".gettemplate("postbit_attachmentimage")."\";");
                        } else {
                                eval("\$post[attachment] = \"".gettemplate("postbit_attachment")."\";");
                        }
                } else {
                        eval("\$post[attachment] = \"".gettemplate("postbit_attachment")."\";");
                }
        } else {
                $post[attachment]="";
        } 
And replace it with the following:
PHP Code:
//
// Attachment size hack
//
                        global $DB_site;
                        $attachinfo=$DB_site->query_first("SELECT LENGTH(filedata) as ATTLEN from attachment where attachmentid = '$post[attachmentid]'");
                        if($attachinfo[ATTLEN] > 50000) {
                                $ok_to_watch=0;
                        }
                        else {
                                $ok_to_watch=1;
                        }
                        if (($ok_to_watch) and ($viewattachedimages) and ($bbuserinfo[userid]==0 or $bbuserinfo[showimages])) {
                                eval("\$post[attachment] = \"".gettemplate("postbit_attachmentimage")."\";");
                        } else {
                                eval("\$post[attachment] = \"".gettemplate("postbit_attachment")."\";");
                        }
                } else {
                        eval("\$post[attachment] = \"".gettemplate("postbit_attachment")."\";");
                }
        } else {
                $post[attachment]="";
        } 
Your feedback will be appreciated. :)

nuno 06-09-2002 11:11 AM
this hacks adds an extra query per attachment :o

Sadie Frost 07-30-2002 02:15 AM
A great idea :) Something I would like to see (and I am not complaining I swear) is to have this work for picture size in pixels. I hate seeing the horozontal scroll, but I also like to be able to view attachments. :) Just a suggestion for the future :)

Martin64 07-31-2002 08:11 PM
Sounds like an excellent hack, but I would also like to see a "pixel" add-on for it. :)


All times are GMT. The time now is 09:45 PM.
Page 2 of 3 1 2 3
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01148 seconds
  • Memory Usage 1,782KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (2)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete