Also check your per forum permissions where usergroup settings can be overridden.

Thanks, these are default as well and unregistered users are allowed to download attachments, see thumbnails, etc.. No change there.

--------------- Added [DATE]1491416478[/DATE] at [TIME]1491416478[/TIME] ---------------

Thought I fixed this because it does not seem constant. Some images go up no problem and others just do not show for guests. I just do not understand it.

The ones that don't show for guests.... do they show if you are logged in?

Can we get a link to an example post that shows an image for guests and a post that isn't showing the image for guests?

Yes, as soon as I log in I see the image.

Sure, I do not want to post the link publically though but I will pm it if ok with you.

--------------- Added 05 Apr 2017 at 16:47 ---------------

A couple other clues..

It is not just unregistered users that cannot see the images. It is other usergroups as well..

I post the images as admin and can only see them using admin..

If the attachment manager is used there are no problems at all..

PS - This was working before I did the 4.2.5 Beta 4

--------------- Added 05 Apr 2017 at 17:06 ---------------

Using debug:

guest:
REPLACE INTO postparsed (postid, dateline, hasimages, pagetext_html, styleid, languageid) VALUES (3201450, 1491425387, 0, 'Nice in this topic.https://vborg.vbsupport.ru/external/2017/04/1.orghttps://vborg.vbsupport.ru/external/2017/04/1.orghttps://vborg.vbsupport.ru/external/2017/04/1.org', 39, 1),(3208226, 1491425387, 2, 'Test
\n[ATTACH=CONFIG]13581[/ATTACH]', 39, 1)



admin
REPLACE INTO postparsed (postid, dateline, hasimages, pagetext_html, styleid, languageid) VALUES (3201450, 1491425387, 0, 'Nice in this topic.https://musclemecca.com/%22http://mu...resent.gif/%22https://musclemecca.com/%22http://mu...ourage.png/%22https://musclemecca.com/%22http://mu.../hello.gif/%22', 39, 1),(3208226, 1491425387, 2, 'Test
\n[ATTACH=CONFIG]13581[/ATTACH]', 39, 1)

Dave tracked it down to patches/vbforum/attach/post.php:

if ($this->attachmentinfo['contentid'] == 0)
{
if ($this->registry->userinfo['userid'] != $this->attachmentinfo['userid'] AND !can_moderate($postinfo['forumid'], 'caneditposts'))
{
return false;
}
}