vb.org Archive - Is the vB4 thread structure broken

Quote:

Originally Posted by MarkFL (Post 2582860)

All I can tell you for sure is that with that code in place, when a reply is made without replying to or quoting a specific post, then the "parentid" for that post will be set to zero. :)

Actually, the fix needed a slight tweak on our Message Board. Apparently the 'p' index does not test false unless you use isset to test it.

I was a bit confused when it did not work on the first try, but I decided it could not possibly harm to make it.

PHP Code:


		
			
if (!isset($_REQUEST['p'])) {
$this->post['parentid'] = 0;
}

The only effect except eliminating the thread reference (that we find troubling) is that in hybrid or threaded view, the link graphics show a broken line for each new reference to the thread. It seems to me that is a benefit rather than a problem.

--------------- Added [DATE]1488068167[/DATE] at [TIME]1488068167[/TIME] ---------------

I do not think it is possible to make this "feature" retroactive.

In my opinion, the current vB4 behavior is broken. Clearly the reply to thread should set previous post to the starting thread post . There is no way to know what the poster intended or which button was used to create a new post since both point to the most recent post.

This fix does eliminate the problem. If one wanted the feature to actually reference the first post in the thread, that could be done or, retroactively in the future a query could be executed to set all the 0 parent postid values to the value of the first postid in the thread.

--------------- Added [DATE]1488080917[/DATE] at [TIME]1488080917[/TIME] ---------------

I thought I had this fixed but when I went to install it on the live site, it did not actually work and when I checked again on the test site the result was the same.

I hacked the plugin to insert a print_r on the $_REQUEST global and got this result for both reply from the border and reply with the button.

PHP Code:


		
			
capture vBulletin $_REQUEST for post thread at postdata_presave hook

Array ([do] => postreply [t] => 139871 [message_backup] => one more [message] => one more 
[wysiwyg] => 0 [signature] => 1 [fromquickreply] => 1 [s] => [securitytoken] => nnnnnnnnn
[p] => 1087469 [specifiedpost] => 1 [parseurl] => 1 [loggedinuser] => 2 [posthash] => nnnnnnnnn
[poststarttime] => 1488076181 [ajaxqrfailed] => 1 [threadid] => 139871 [postid] => 1087469 [styleid] => 
[langid] => [api] => [refererid] => [a] => [nojs] => [forumid] => [pollid] => [dofbredirect] => 
[pagenumber] => [noquote]=>) [quoteall] =>)

'p' and 'postid' are both set to the same value and not missing or 0, etc.

Is there a different hook that will work, or is one of my other mods busting this. I notice that there is a jquery flag that looks like it may be bad.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01022 seconds Memory Usage 1,735KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_php_printable (1)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (2)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: