vb.org Archive - 4.2.2 Upgraders, Check your Advanced Search

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB4 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=251)

- - 4.2.2 Upgraders, Check your Advanced Search (https://vborg.vbsupport.ru/showthread.php?t=303430)

Just upgrade to 4.2.2 Pl1 and found this bug almost immediately. Fortunately a quick search turned up this fix. However, given that this has been around since last October shouldn't this already be in the relevant PHP files for the latest updates?

Quote:

Originally Posted by Old-Git (Post 2489509)

My thoughts exactly. But the fix worked after updating the 2 files.

Quote:

Originally Posted by quincyy (Post 2524150)

My thoughts exactly. But the fix worked after updating the 2 files.

This fix is already in 4.2.3

So this bug/fix was October 2013 and was apparent in 4.2.2 PL1.
I'm running 4.2.2 PL3 and seen this error pop up in a few places, so why has VBulletin not got a patch for this after soo long. I guess the upgrades fix many issues, but I do find every upgrade I'm chasing fixing of bugs from that upgrade. Thanks for posting the fix.
This forum is very handy for fixing things and great mods too.

Quote:

Originally Posted by TransAmDan (Post 2528808)

I'm running 4.2.2 PL3 and seen this error pop up in a few places, so why has VBulletin not got a patch for this after soo long.

Bugs dont generally get patched (unless they are very serious) they get fixed in the next version, and as already stated above, its fixed in 4.2.3

Quote:

Originally Posted by findingpeace (Post 2453562)

Yesterday, we upgraded from 4.2.1 to 4.2.2 - we did this after extensive testing in a separate environment, to get all of our other plugins playing nice. The upgrade went smoothly, and we love the new version! Much faster on PHP 5.4, so we're really happy about that.

One quick thing I wanted to share, unrelated to plugins. Click the "Advanced Search" button on your site. (http://www.yoursite.com/search.php). Do you have errors at the top of the page?

I did, and it frustrated me because we had carefully followed all upgrade steps. It persisted, even with hooks off.

The solution? See below:

http://www.vbulletin.com/forum/forum...93#post4000793

Code:

1. - edit the files "socialgroupmessage.php" and "socialgroupdiscussion.php" found in "packages/vbforum/item/"



2. - The original function reads:



protected function getLoadQuery($required_query, $force_rebuild = false)



3. - Change the function to this:



protected function getLoadQuery($required_query = self::QUERY_BASIC, $force_rebuild = false)

I personally much prefer this method, since I don't think turning off error messages is a very good way of dealing with errors. Just wanted to share, in case anyone saw the same issue!

Thanks for the fix!

Just a FYI, this is fixed in 4.2.3

Thanks for the heads up OP and fix. I just upgraded a site to the latest version in the members area, which is 4.2.2 PL4.
It sure would be nice if it was fixed in the download package..

As long as we're talking errors, here's one I fixed today for Who's Online

in includes/functions_online.php , line 516, find

Code:

else if ($userinfo['values']['do'] == 'editfolders' OR $userinfo['action']['do'] == 'updatefolders')

and change it to

Code:

  

else if ($userinfo['values']['do'] == 'editfolders' OR $userinfo['values']['do'] == 'updatefolders')

I didn't research this or test it but it's so obvious it has to be correct. But if I'm wrong, so what? It doesn't throw an error message. I looked at what I have left of an old vB 4.0.5 dev site and it was the same then and that was downloaded over 2 years ago. It's probably been that way for ages. Couldn't they have fixed this instead of hiding error/warning messages????

--------------- Added [DATE]1421724977[/DATE] at [TIME]1421724977[/TIME] ---------------

Quote:

Originally Posted by pityocamptes (Post 2463668)

..........

These are in admincp:

Warning: Declaration of vB_Database_Alter_MySQL::add_index() should be compatible with that of vB_Database_Alter::add_index() in ..../includes/class_dbalter.php on line 882

Warning: Declaration of vB_Database_Alter_MySQL::add_field() should be compatible with that of vB_Database_Alter::add_field() in ..../includes/class_dbalter.php on line 882

Warning: Declaration of vB_Database_Alter_MySQL::drop_field() should be compatible with that of vB_Database_Alter::drop_field() in ..../includes/class_dbalter.php on line 882

Warning: Declaration of vB_Database_Alter_MySQL::query() should be compatible with that of vB_Database_Alter::query() in ..../includes/class_dbalter.php on line 882

..............

Under what circumstances do these warnings occur? Anyone know? I'm almost certain I know what the problem is but I would want to be able to test it

Quote:

Originally Posted by Brandon Sheley (Post 2533446)

It sure would be nice if it was fixed in the download package..

As has been repeated several times now, it is fixed, in 4.2.3.

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code_printable (6)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (3)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.02369 seconds Memory Usage 1,749KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code_printable (6)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (3)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: