Yes, i tested for a client, thats why i posted what i did & thats why it was rewrote because of that issue.

Is the rewrite in the latest download?
Or did you rewrite it for your client?
(and if so could you point me to the area to be rewritten?)

No, sorry its a private script rewrite that wasnt released here.

I see. It's IN (1, 2, 3) to check for one of a number of values, but = just checks one.

I'm quite sure that you just want to remove the word NOT from the existing case 3. (But I don't know anything about the other issue you guys were discussing).

No biggie. I will keep an eye out whilst I test this. So far I have it working but if something crops up, I am sure I can figure it out.

Thanks kh99. Since I can only test this on a daily basis (on a test usergroup, without bothering going into the database to backdate test pm's), I am going to test it (since I have already implemented it in test) by combining case 1 contents with case 2 contents into case 3 removing the old case 3 contents, and changing the phrase in the template for acp. This may not be the most effecient use, but I know the cron runs atm with this change without error. I will just have to wait till tomorrow to find out if it indeed operated as desired as I dont have enough time today to force the issue. If it doesnt work, I will try your suggestion and then report back. If it does, then eureka!!

Thanks again.

If you're talking about trying the last code you posted above, that won't work because the only way the condition would be true is if pm.folderid was equal to -1 and to 0. If you wanted to do it that way you'd need an OR (and add parens), like:


But that's actually equivalent to "AND pm.folderid IN (0, -1)", which is what you get by removing the NOT.

Check the PM folders after it runs on its own for PM's that got deleted, but left the msg in the box, you will no longer be able to click or delete via the forum.

Forgot to return to this, but yes you are correct. My attempt didnt work as you suggested. Didnt prune anything in tests.

I will try your suggestion next and report back the results.

Is there a preferred methed? Use the OR or use the AND without the NOT?

No, it's just two different ways of expressing the same condition.

That did the trick on a manual run of the cron. I will be testing it on auto cron tonight, but it looks like it worked perfect.

Thank you once again kh99
(I will likely post these changes on the original 3.7 thread)
(if it says reusable code, does that mean I can submit this in my name with original credits as a new 4.x mod?)