vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Requests/Questions (Unpaid) (https://vborg.vbsupport.ru/forumdisplay.php?f=112)
-   -   Allow all members to edit first post of a thread if it has certain prefix (https://vborg.vbsupport.ru/showthread.php?t=279337)

0lly 03-09-2012 09:05 AM

Thanks for the replies guys, I actually managed to do it a week or so ago (forgot to update here since I've been busy and working on a games wiki section which will also end up using this, so I kinda forgot about this thread :o)

Basically, what I did, was duplicate editpost.php, and called it wikiedit.php. Then, from the wikiedit.php file I removed all of this;

PHP Code:

// ############################### start permissions checking ###############################
if ($_REQUEST['do'] == 'deletepost')
{
    
// is post being deleted? if so check delete specific permissions
    
if (!can_moderate($threadinfo['forumid'], 'candeleteposts'))
    {
        if (!
$threadinfo['open'])
        {
            
$vbulletin->url 'showthread.php?' $vbulletin->session->vars['sessionurl'] . "t=$postinfo[threadid]";
            eval(
print_standard_redirect('redirect_threadclosed'));
        }
        if (!(
$forumperms $vbulletin->bf_ugp_forumpermissions['candeletepost']))
        {
            
print_no_permission();
        }
        else
        {
            if (
$vbulletin->userinfo['userid'] != $postinfo['userid'])
            {
                
// check user owns this post since they failed the Mod Delete permission check for this forum
                
print_no_permission();
            }
        }
    }
}
else
{
    
// otherwise, post is being edited
    
if (!can_moderate($threadinfo['forumid'], 'caneditposts'))
    { 
// check for moderator
        
if (!$threadinfo['open'])
        {
            
$vbulletin->url 'showthread.php?' $vbulletin->session->vars['sessionurl'] . "t=$threadinfo[threadid]";
            eval(
standard_error(fetch_error('threadclosed')));
        }
        if (!(
$forumperms $vbulletin->bf_ugp_forumpermissions['caneditpost']))
        {
            
print_no_permission();
        }
        else
        {
            if (
$vbulletin->userinfo['userid'] != $postinfo['userid'])
            {
                
// check user owns this post
                
print_no_permission();
            }
            else
            {
                
// check for time limits
                
if ($postinfo['dateline'] < (TIMENOW - ($vbulletin->options['edittimelimit'] * 60)) AND $vbulletin->options['edittimelimit'] != 0)
                {
                    eval(
standard_error(fetch_error('edittimelimit'$vbulletin->options['edittimelimit'], $vbulletin->options['contactuslink'])));
                }
            }
        }
    }


and then from lines 91-97, I replaced this;
PHP Code:

// get permissions info
$_permsgetter_ 'edit post';
$forumperms fetch_permissions($threadinfo['forumid']);
if (!(
$forumperms $vbulletin->bf_ugp_forumpermissions['canview']) OR !($forumperms $vbulletin->bf_ugp_forumpermissions['canviewthreads']) OR (!($forumperms $vbulletin->bf_ugp_forumpermissions['canviewothers']) AND ($threadinfo['postuserid'] != $vbulletin->userinfo['userid'] OR $vbulletin->userinfo['userid'] == 0)))
{
    
print_no_permission();



with this;
PHP Code:

// get permissions info
if ($threadinfo['prefixid'] != wiki OR is_member_of($vbulletin->userinfo41382) OR ($threadinfo['firstpostid'] != $postinfo['postid']))
{
    
print_no_permission();



I did have it do that any member could edit the first post, but decided to only allow it to people with over 15 posts (which is obviously what the is_member_of($vbulletin->userinfo, 4, 1, 3, 8, 2) bit is for)

I'm sure there's a better way of doing it, but I'm just happy I managed to get it working :p

You can see the thread at the bottom of this page comes up as a "WikiEdit" post - http://www.nintendolounge.com/forum/...er=desc&page=3

BirdOPrey5 03-09-2012 10:14 AM

very cool. Great idea to put a notice with new edit link in it... Solves the issue I was having with quick edit permissions and looks great on your forum. :up:

Paul M 03-09-2012 12:48 PM

Removing the delete permission checks is very unwise.

BirdOPrey5 03-09-2012 01:18 PM

If the entire if ($_REQUEST['do'] == 'deletepost') is removed how could anyone delete a post even if they tried?

Paul M 03-09-2012 01:25 PM

It isnt removed, thats just the permission check. The delete code is way further down.

0lly 03-09-2012 07:53 PM

Quote:

Originally Posted by BirdOPrey5 (Post 2307822)
very cool. Great idea to put a notice with new edit link in it... Solves the issue I was having with quick edit permissions and looks great on your forum. :up:

Thanks! :)

Quote:

Originally Posted by Paul M (Post 2307905)
It isnt removed, thats just the permission check. The delete code is way further down.

Ah, I thought I had disabled the ability to delete it, but I hadn't seen the code at the bottom. I see it now;
PHP Code:

// ############################### start delete post ###############################
if ($_POST['do'] == 'deletepost')
{

    
$vbulletin->input->clean_array_gpc('p', array(
        
'deletepost'      => TYPE_STR,
        
'reason'          => TYPE_STR,
        
'keepattachments' => TYPE_BOOL,
    ));

    (
$hook vBulletinHook::fetch_hook('editpost_delete_start')) ? eval($hook) : false;

    if (!
can_moderate($threadinfo['forumid'], 'candeleteposts'))
    {    
// Keep attachments for non moderator deletes (post owner)
        
$vbulletin->GPC['keepattachments'] = true;
    }

    if (
$vbulletin->GPC['deletepost'] != '')
    {
        
//get first post in thread
        
$getfirst $db->query_first_slave("
            SELECT postid, dateline
            FROM " 
TABLE_PREFIX "post
            WHERE threadid = 
$postinfo[threadid]
            ORDER BY dateline
            LIMIT 1
        "
);
        if (
$getfirst['postid'] == $postinfo['postid'])
        {
            
// delete thread
            
if ($forumperms $vbulletin->bf_ugp_forumpermissions['candeletethread'] OR can_moderate($threadinfo['forumid'], 'canmanagethreads'))
            {
                if (
$vbulletin->GPC['deletepost'] == 'remove' AND can_moderate($threadinfo['forumid'], 'canremoveposts'))
                {
                    
$removaltype true;
                }
                else
                {
                    
$removaltype false;
                }

                
$threadman =& datamanager_init('Thread'$vbulletinERRTYPE_STANDARD'threadpost');
                
$threadman->set_existing($threadinfo);
                
$threadman->delete($foruminfo['countposts'], $removaltype, array('userid' => $vbulletin->userinfo['userid'], 'username' => $vbulletin->userinfo['username'], 'reason' => $vbulletin->GPC['reason'], 'keepattachments' => $vbulletin->GPC['keepattachments']));
                unset(
$threadman);

                if (
$foruminfo['lastthreadid'] != $threadinfo['threadid'])
                {
                    
// just decrement the reply and thread counter for the forum
                    
$forumdm =& datamanager_init('Forum'$vbulletinERRTYPE_SILENT);
                    
$forumdm->set_existing($foruminfo);
                    
$forumdm->set('threadcount''threadcount - 1'false);
                    
$forumdm->set('replycount''replycount - 1'false);
                    
$forumdm->save();
                    unset(
$forumdm);
                }
                else
                {
                    
// this thread is the one being displayed as the thread with the last post...
                    // so get a new thread to display.
                    
build_forum_counters($threadinfo['forumid']);
                }

                (
$hook vBulletinHook::fetch_hook('editpost_delete_complete')) ? eval($hook) : false;

                
$vbulletin->url 'forumdisplay.php?' $vbulletin->session->vars['sessionurl'] . "f=$threadinfo[forumid]";
                eval(
print_standard_redirect('redirect_deletethread'));
            }
            else
            {
                
print_no_permission();
            }
        }
        else
        {
            
//delete just this post
            
if ($vbulletin->GPC['deletepost'] == 'remove' AND can_moderate($threadinfo['forumid'], 'canremoveposts'))
            {
                
$removaltype true;
            }
            else
            {
                
$removaltype false;
            }

            
$postman =& datamanager_init('Post'$vbulletinERRTYPE_SILENT'threadpost');
            
$postman->set_existing($postinfo);
            
$postman->delete($foruminfo['countposts'], $threadinfo['threadid'], $removaltype, array('userid' => $vbulletin->userinfo['userid'], 'username' => $vbulletin->userinfo['username'], 'reason' => $vbulletin->GPC['reason'], 'keepattachments' => $vbulletin->GPC['keepattachments']));
            unset(
$postman);

            
build_thread_counters($threadinfo['threadid']);

            if (
$foruminfo['lastthreadid'] != $threadinfo['threadid'])
            {
                
// just decrement the reply counter
                
$forumdm =& datamanager_init('Forum'$vbulletinERRTYPE_SILENT);
                
$forumdm->set_existing($foruminfo);
                
$forumdm->set('replycount''replycount - 1'false);
                
$forumdm->save();
                unset(
$forumdm);
            }
            else
            {
                
// this thread is the one being displayed as the thread with the last post...
                // need to get the lastpost datestamp and lastposter name from the thread.
                
build_forum_counters($threadinfo['forumid']);
            }

            (
$hook vBulletinHook::fetch_hook('editpost_delete_complete')) ? eval($hook) : false;

            
$url unhtmlspecialchars($vbulletin->url);
            if (
preg_match('/\?([^#]*)(#.*)?$/s'$url$match))
            {
                
parse_str($match[1], $parts);

                if (
$parts['postid'] == $postinfo['postid'] OR $parts['p'] == $postinfo['postid'])
                {
                    
// we've deleted the post that we came into this thread from
                    // blank the redirect as it will be set below
                    
$vbulletin->url '';
                }
            }
            else if (
$removaltype OR !can_moderate($threadinfo['forumid'], 'candeleteposts'))
            {
                
// hard deleted or not moderating -> redirect back to the thread
                
$vbulletin->url '';
            }

            if (!
stristr($vbulletin->url'showthread.php')) // no referring url?
            
{
                
$vbulletin->url 'showthread.php?' $vbulletin->session->vars['sessionurl'] . 't=' $threadinfo['threadid'];
            }

            eval(
print_standard_redirect('redirect_deletepost'));
        }
    }
    else
    {
        (
$hook vBulletinHook::fetch_hook('editpost_delete_complete')) ? eval($hook) : false;

        
$vbulletin->url 'showthread.php?' $vbulletin->session->vars['sessionurl'] . "p=$postinfo[postid]#post$postinfo[postid]";
        eval(
print_standard_redirect('redirect_nodelete'));
    }



Is it ok to just delete that then?

BirdOPrey5 03-09-2012 08:43 PM

I would think it is safer to delete it than leave it. ;)

0lly 03-09-2012 10:09 PM

Hehe yeah :p Well I've deleted it now. Just thought there might be a safer way to disable it in the code or something, feels a bit weird deleting so much :p

Niak_Judge 03-14-2012 07:16 PM

Hello,
is this possible in vb 4 ?
Would be great :) !

BirdOPrey5 03-15-2012 03:33 AM

It is possible using the same basic procedures... a lot of file edits... I am working on trying to make this into a mod for VB4... no promises...


All times are GMT. The time now is 07:56 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01332 seconds
  • Memory Usage 1,877KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_php_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (2)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete