vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   BB Code Enhancements - BBCode: Resize Image with Text Wrap (https://vborg.vbsupport.ru/showthread.php?t=248863)

midnz 08-19-2010 01:24 AM

Quote:

Originally Posted by Hippy (Post 2086031)
Nice mod there midnz
thanks for your efforts
Seemed interesting so I test it out..

seems if you add the image to a post with a couple lines. ..
it over laps down wards into the sig area..
Not sure if any one noticed it yet
I sure will use it if this could be fixed ..

Thanks for noticing that issue. I'll have a look at fixing the problem tonight when I get back from my travels.

EDIT: I've spent a few hours trying different remedies with limited results so far. It seems that images and tables with align=left or align=right don't appear to work in posts any more without interfering with signatures whereas using align=center, align=top & align=bottom do work without interfering with signatures. [S]I'll have to ask over at vB.com to look further in to the problem.[/S] Problem solved.

midnz 08-19-2010 11:57 PM

Quote:

Originally Posted by Hippy (Post 2086031)
Nice mod there midnz
thanks for your efforts
Seemed interesting so I test it out..

seems if you add the image to a post with a couple lines. ..
it over laps down wards into the sig area..
Not sure if any one noticed it yet
I sure will use it if this could be fixed ..

If you view the demo link posted in the first post of this thread you'll see that the second post of my demo thread shows that this BBCode works with minimal text added and without interfering with the posted signature.

The problem of signature interference appears to arise when you use image or table align="left or right" after editing your postbit.css with the instructions placed in this mod.

I've replaced

Admin CP -> Style & Templates -> Style Manager -> CSS Templates -> Postbit.css

PHP Code:

.postbitlegacy .after_content {
clear:right !important;


with
PHP Code:

.postbitlegacy .after_content {
    
positionrelative;
    
width100%;
    
clear:both;


...and your reported signature interference error has vanished.

BirdOPrey5 08-20-2010 02:57 PM

FYI, the warning message isn't 'bogus' at least not in this case... for various security reasons it's better to always enclose the {param} tags in double quotes rather then single quotes... while I highly doubt anyone will have a problem the following codes will not display the error and is technically a bit safer. (I swapped the single and double quotes):

Code:

<img src="{param}" width="200" height="150" ondblclick='this.src="{param}";this.height=450;this.width=600' onclick='this.src="{param}";this.height=150;this.width=200' align="left" hspace="10">
Also I'm not sure what the purpose of "<!{param}>" is- I don't know what it does and it seems to work fine for me without it. :confused:

djbaxter 08-20-2010 03:37 PM

I meant to come back and comment on this, too. In fact, the errors I was receiving with a couple of other BBCodes were valid errors - some I could fix and some I couldn't.

As Bird of Prey says, don't ignore such errors - they do mean something and may create a vulnerability if ignored.

midnz 08-20-2010 07:18 PM

Quote:

Originally Posted by BirdOPrey5 (Post 2086890)
FYI, the warning message isn't 'bogus' at least not in this case... for various security reasons it's better to always enclose the {param} tags in double quotes rather then single quotes... while I highly doubt anyone will have a problem the following codes will not display the error and is technically a bit safer. (I swapped the single and double quotes):

Also I'm not sure what the purpose of "<!{param}>" is- I don't know what it does and it seems to work fine for me without it. :confused:

Thanks very much for the advice and assistance. I've edited in the double quotes where they should have been. The "<!{param}>" was unnecessary and should've been removed after I'd finished testing. That's done now, cheers :).

Quote:

Originally Posted by djbaxter (Post 2086899)
I meant to come back and comment on this, too. In fact, the errors I was receiving with a couple of other BBCodes were valid errors - some I could fix and some I couldn't.

As Bird of Prey says, don't ignore such errors - they do mean something and may create a vulnerability if ignored.

Thanks for that advice. All fixed :).

djbaxter 08-20-2010 07:41 PM

1 Attachment(s)
Another issue: You've defined fixed values for height and width, both for the "thumbnail" and for the "enlarged" images.

If the image doesn't conform to the proportions of those sizes, you end up with a distorted image - in fact, both the thumbnail and the enlarged images are distorted in the test example - see attachment.

Also, this is still forcing the signature to wrap around the image along with the text, which isn't ideal.

midnz 08-20-2010 09:43 PM

Quote:

Originally Posted by djbaxter (Post 2087020)
Another issue: You've defined fixed values for height and width, both for the "thumbnail" and for the "enlarged" images.

If the image doesn't conform to the proportions of those sizes, you end up with a distorted image - in fact, both the thumbnail and the enlarged images are distorted in the test example - see attachment.

As explained in my first post here "The size/resize dimensions can easily be altered to suit your individual requirements. Just change the width= and height= dimensions in the code below."
I've used this BBCode to display large local images of fixed proportions. Ideally there might be {option}s included for proportions however that is beyond the abilities of this learner driver I'm sorry. I'd be happy for anyone with the skills to improve the dimension constraints.

Quote:

Originally Posted by djbaxter (Post 2087020)
Also, this is still forcing the signature to wrap around the image along with the text, which isn't ideal.

If you've made edits to your postbit.css as explained in this thread then you will have signature interference with image or table align="left or right". It's covered in post#12 above. If you check out my demo (second post in that thread) you'll see that this BBCode doesn't force the signature to wrap around the image and text unless you've made those postbit.css edits.
Also, the Preview Post will show the signature wrapping around the image and text, however when posted, it should display properly.

BirdOPrey5 08-20-2010 10:29 PM

I don't know if it would work in this case but did you ever try using max-height and max-width tags instead? This isn't exactly my specialty but I know they exist.

You could add an {option} but either the small or large image would still be out of proportion, you can't have two options.

midnz 08-20-2010 10:35 PM

Quote:

Originally Posted by BirdOPrey5 (Post 2087102)
I don't know if it would work in this case but did you ever try using max-height and max-width tags instead? This isn't exactly my specialty but I know they exist.

I was hopeful that using percentages might work but that was a failed test. I'll do some research/testing to see if/how your suggestion might work. Thanks for that :).

Quote:

Originally Posted by BirdOPrey5 (Post 2087102)
You could add an {option} but either the small or large image would still be out of proportion, you can't have two options.

Awesome! You've saved me a few hours of researching that idea :). Cheers :)

djbaxter 08-20-2010 11:11 PM

Quote:

Originally Posted by midnz (Post 2087087)
If you've made edits to your postbit.css as explained in this thread then you will have signature interference with image or table align="left or right". It's covered in post#12 above. If you check out my demo (second post in that thread) you'll see that this BBCode doesn't force the signature to wrap around the image and text unless you've made those postbit.css edits.

I have NOT made those edits and it is still wrapping the sig. See the attachment in my post above.

I use postbit, not postbit_legacy, as you can see from the screen capture in the attachment.


All times are GMT. The time now is 10:45 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01192 seconds
  • Memory Usage 1,762KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (2)bbcode_php_printable
  • (9)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete