vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Forum Home Enhancements - Members who have visited today. (https://vborg.vbsupport.ru/showthread.php?t=221579)

Andreas 08-24-2009 10:33 AM

Quote:

Originally Posted by Paul M (Post 1873223)
I have no way of testing that since I dont use memcache, but could you be a little more specific than "does not work" :)

Hehe, sure ;)
(In fact I didn't test it, I just looked at the code):
You are calling do_fetch(), which does work just fine for connectionless caches like APC, XCache, eAccelerator.

Memcache however does need a connection, and do_fetch() does not check if there is one - so you end up with an error (or a segfault in worst case).

Paul M 08-24-2009 11:23 AM

So this is a bug in vbulletin, the memcache class should check/create a connection when do_fetch() is used. :)

As it happens, that code only runs if maxloggedin does not exist, which should never be the case on the forumhome, it was a backup in case the code was run on other pages (which used to be an option, but got removed in the 3.8 version). So even if you run memcache, this should actually always work.

In fact, I think I can take out the datastore fetch, as the reason for it being there no longer exists.

Paul M 08-24-2009 11:24 AM

Quote:

Originally Posted by veenuisthebest (Post 1873268)
Obviously, so like I have XCache installed. How do I test now?

Sorry, I dont really understand what you are asking.

Andreas 08-24-2009 11:41 AM

Nope, as do_fetch() is a "private" method that really only gets called from within the class - you are abusing it by calling it from the outside ;)

Marco van Herwaarden 08-24-2009 12:08 PM

Then it should be set as private so it can't be used from outside the class.

Paul M 08-24-2009 12:08 PM

Abusing it, lol, a bit extreme :)

I havent looked at that for a couple of years, since I first played with it, but yes, I presume fetch() should be used.

Paul M 08-26-2009 02:34 PM

Build 13 - added the collapse option back.

Andreas 08-26-2009 08:39 PM

Quote:

Originally Posted by Marco van Herwaarden (Post 1873312)
Then it should be set as private so it can't be used from outside the class.

If it was PHP 5 code - sure.
But it is PHP 4 code still.

Paul M 09-09-2009 07:09 PM

Build 16 uploaded.

Various changes based on testing and learning of vb4.

Charlie98902 11-15-2009 03:05 PM

Thanks Paul this is one of the many mods I use :)


All times are GMT. The time now is 10:38 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01460 seconds
  • Memory Usage 1,732KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete