vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   New Posting Features - Quick Nick & Quote in QR (https://vborg.vbsupport.ru/showthread.php?t=215418)

nohuhu 06-24-2009 02:38 PM

Psionic Vision,

ok, now i got it. sorry for me being stupid. :)

nohuhu 06-24-2009 06:13 PM

Psionic Vision,

got it working. have an issue though: when editor is set to wysiwyg mode, using either "insert name" or "quick quote" functions produces an extra line break before inserted text. i took a look at your code and this behaviour seems to be expected as you check length of existing editor contents before inserting your own but somehow it doesn't work as expected with wysiwyg mode. in simple editor mode it works ok and only inserts extra line break when there is already some content in editor field. can you check this please?

also i have a feature request of a sorts: can you make your script to set focus on editor field after inserting either quote or username? that would be logical i think, usually i want to start writing my message immediately after quoting or addressing someone. i tried to append "this.focus()" call after "this.set_editor_contents()" but somehow it doesn't work. sorry i'm no javascript expert...

akanevsky 06-24-2009 07:21 PM

Quote:

got it working. have an issue though: when editor is set to wysiwyg mode, using either "insert name" or "quick quote" functions produces an extra line break before inserted text. i took a look at your code and this behaviour seems to be expected as you check length of existing editor contents before inserting your own but somehow it doesn't work as expected with wysiwyg mode. in simple editor mode it works ok and only inserts extra line break when there is already some content in editor field. can you check this please?
That is a known bug. In WYSIWYG, there's some hidden formatting that causes the message length function to report a random non-zero number when the message area is empty - and I don't know how to work around the problem at this time.

Quote:

also i have a feature request of a sorts: can you make your script to set focus on editor field after inserting either quote or username? that would be logical i think, usually i want to start writing my message immediately after quoting or addressing someone. i tried to append "this.focus()" call after "this.set_editor_contents()" but somehow it doesn't work. sorry i'm no javascript expert...
A lot of people want to quote multiple things before starting to type a reply. If the focus kept jumping to message area every time, that would be very annoying to those people.

nohuhu 06-25-2009 08:28 AM

Quote:

Originally Posted by Psionic Vision (Post 1836638)
That is a known bug. In WYSIWYG, there's some hidden formatting that causes the message length function to report a random non-zero number when the message area is empty - and I don't know how to work around the problem at this time.

ok then, i'll have to advise my users not to use wysiwyg mode for quick reply.

Quote:

A lot of people want to quote multiple things before starting to type a reply. If the focus kept jumping to message area every time, that would be very annoying to those people.
i got your point but my users got used to phpbb behaviour and it focused on message area after clicking on username. i myself find it convenient too. is it possible to make it configurable? if not and you don't want to include this feature in your mod, can you advise me on how to do it then? i have no trouble running customized mods. :)

nohuhu 06-25-2009 08:44 AM

Psionic Vision,

never mind that, i already figured it out myself.

nohuhu 06-25-2009 09:43 AM

Psionic Vision,

also i think it would do a lot of good to extract all html code from your postbit_factory plugin into separate template. this way it'd be much easier to change visual appearance of postbit.

akanevsky 06-25-2009 03:47 PM

Quote:

Originally Posted by nohuhu (Post 1836947)
i got your point but my users got used to phpbb behaviour and it focused on message area after clicking on username. i myself find it convenient too. is it possible to make it configurable? if not and you don't want to include this feature in your mod, can you advise me on how to do it then? i have no trouble running customized mods. :)

I could make it customizable on a per-user basis...

Quote:

Originally Posted by nohuhu (Post 1836972)
Psionic Vision,

also i think it would do a lot of good to extract all html code from your postbit_factory plugin into separate template. this way it'd be much easier to change visual appearance of postbit.

Thank you for the suggestion.

nohuhu 06-25-2009 06:21 PM

Quote:

Originally Posted by Psionic Vision (Post 1837159)
I could make it customizable on a per-user basis...

yes, that would be very helpful.

Quote:

Thank you for the suggestion.
well, upon closer look i turned this plugin off and made manual changes to my templates. it isn't that helpful either way 'cause it worked for vanilla postbit template but didn't work for customized postbit_legacy template, it didn't insert "quick quote" button. most probably it just couldn't find the piece of text that you chose as a placeholder for inserting new button. adding code from that plugin to the template worked like charm.

lordnara 10-10-2009 07:04 AM

i'm using tech forum templates, the button don't show :(
and yes.. i upload the quickquote.gif :)

thanks.... great mod :)

psychonikeo 11-25-2009 12:51 PM

nevermind..


All times are GMT. The time now is 01:55 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02013 seconds
  • Memory Usage 1,741KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (8)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (2)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete