vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   Mini Mods - Sort Memberlist by Usergroup (https://vborg.vbsupport.ru/showthread.php?t=206295)

R-D 02-23-2009 12:48 PM

Here's a couple more things you may want to correct before re-uploading the attachment.

Although you clean the groupid variable at the memberlist_start hook, you never use that version, instead you redeclare $groupid later on, using the unclean version.

At memberlist_start
Code:

$groupid = $vbulletin->input->clean_gpc('r', 'groupid', TYPE_UINT);
At memberlist_query_userscount
Code:

if (intval($_REQUEST['groupid']) > 0)
{
        $groupid = intval($_REQUEST['groupid']);
        $condition .= ' AND (FIND_IN_SET(\''.$groupid.'\', membergroupids) OR user.usergroupid = '.$groupid.')';
}


That final part should be:
Code:

if (intval($groupid) > 0)
{
        $condition .= ' AND (FIND_IN_SET(\''.$groupid.'\', membergroupids) OR user.usergroupid = '.$groupid.')';
}



Also, although the $do_not_include variable hides the defined usergroups from the options list, members can still randomly try numbers and pull the memberlist for all those usergroups, regardless of the $do_not_include setting (apart from usergroups that are set in the AdminCP to be hidden from the memberlist).

If you move the $do_not_include declaration to the top of the plugin, it can also be checked when you check if $groupid > 0.

puertoblack2003 02-23-2009 07:13 PM

good job hassan works great:up:

goyo 02-23-2009 07:56 PM

Hasann or somebody else...

Could you send me the file download link via PM or reupload the modified version ?

I'm looking this hack for ages... :rolleyes:

kaptanblack 02-23-2009 07:58 PM

Thanks hasann..

Hasann 02-23-2009 09:30 PM

in next version will improve this product just wait ;)

Ramsesx 02-24-2009 12:31 PM

Cool hack, thanks. If there are no file edits I'll install it.

EvilJohn 02-25-2009 10:41 AM

Looks nice. Going to install. Anyway to sort members in the user groups by join date?

Thanks. :up:

celikforum 02-25-2009 11:37 AM

<div align="left">been good thanks, although I have not tried, but nice sharing</div>

OcR Envy 03-12-2009 02:32 PM

How about adding usergroup styling to this? :)

FFTFTCEd 03-21-2009 11:21 PM

Great mod, thanks, it was just what I needed.


All times are GMT. The time now is 02:13 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01022 seconds
  • Memory Usage 1,726KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete