vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   End-User Options - Mark All Forums Read Confirmation (https://vborg.vbsupport.ru/showthread.php?t=142376)

Ziki 03-18-2007 05:44 PM

I suggest to remove the link from there because it won't ever work

Quote:

Originally Posted by Tralala (Post 1206601)
Actually, this works for me everywhere, except the QuickLinks pulldown in the standard vBulletin skin. I select the "Mark Forums Read" menu option, confirm the dialog that pops up, then nothing happens; no page refresh like I am used to.

(Ironically enough it works fine in my custom skin, in the QuickLinks pulldown, and all the other spots.)

Any clues? Here's the code:

Before:
Code:

<tr><td class="vbmenu_option"><a href="forumdisplay.php?$session[sessionurl]do=markread">$vbphrase[mark_forums_read]</a></td></tr>
After:
Code:

<tr><td class="vbmenu_option"><a href="forumdisplay.php?$session[sessionurl]do=markread" rel="nofollow" onclick="return mark_all_read()">$vbphrase[mark_forums_read]</a></td></tr>


Tralala 03-18-2007 06:48 PM

Quote:

Originally Posted by Ziki (Post 1206618)
I suggest to remove the link from there because it won't ever work

Yeah, since I discovered the code mod wasn't working there I removed it and put it back to the "original" way. I also moved the "Mark Forums Read" to a different position of the QuickLinks menu, so it would be less likely to be selected by user mistake.


The confirmation mod DOES work properly in the QuickLinks pulldown of my other (customized) skin... at least, when I am in forumhome. (The confirmation dialog doesn't seem to pop up when I choose it from UserCP, or Threadview, or Search. But even with that, the menu command still works, just no confirmation dialog.) It didn't work in vBulletin at all.

Why is there no way to get it to work as desired in the the QuickLinks pulldown? Why can it work (somewhat, ie: in forumhome, but not elsewhere) in one skin... but not in vB skin at all? I tried making a seperate "Mark Forums Read" link in navbar template, and noticed the same weirdness. The confirmation dialog only appears when accessing it from forumhome.

Just wondering, trying to learn.



Would it make sense to introduce this confirmation dialog into the "do=markread" command instead? That way it'd be universal to it's invocation everywhere. Make a preference option in UserCP so visitors could choose whether or not they get the Confirmation dialog... and I'd nominate this for MOTM. :D

HMBeaty 03-18-2007 07:39 PM

Awesome, never thought to do this. Nice job

/me clicks Install

Doctor Death 03-18-2007 07:49 PM

Great idea. Installed.

Smoothie 03-18-2007 08:06 PM

So wait, this works, but it don't in the QL?

Smoothie 03-18-2007 08:16 PM

works fine here.

Tralala 03-18-2007 08:55 PM

Quote:

Originally Posted by Smoothie (Post 1206802)
works fine here.

Test it further, kemosabe. It works on your forumhome's QuickLink menu only... but NOT when you try it from anywhere else (ie: inside a forum, a thread, UserCP, etc.)

I just checked on your forum (macfora.com) and see it doesn't work. In fact, choosing the command from those other places does nothing on your forum... it breaks the menu item completely.

Smoothie 03-19-2007 12:36 AM

Quote:

Originally Posted by Tralala (Post 1206845)
Test it further, kemosabe. It works on your forumhome's QuickLink menu only... but NOT when you try it from anywhere else (ie: inside a forum, a thread, UserCP, etc.)

I just checked on your forum (macfora.com) and see it doesn't work. In fact, choosing the command from those other places does nothing on your forum... it breaks the menu item completely.

That's funny, because I never thought to check those. I only checked forumhome. And you're correct, it no worky on those other pages.

Smoothie 03-19-2007 12:39 AM

So, we have a half working mod here. Works only from forumhome and not anywhere else.

Smoothie 03-19-2007 12:42 AM

One other thang. When clicking forum icons to "mark this forum and contents as read", you should get a confirmation box for that too, no? I gotta uninstall until this gets fixed.


All times are GMT. The time now is 03:19 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01198 seconds
  • Memory Usage 1,740KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete