vb.org Archive - FreshBlue Fixed Template

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.5 Styles (https://vborg.vbsupport.ru/forumdisplay.php?f=161)

- - FreshBlue Fixed Template (https://vborg.vbsupport.ru/showthread.php?t=114104)

Quote:

Originally Posted by psalzmann

Great! I tried poking around but I got lost pretty quick :) I think it's adding some extra <div> where it shouldn't be..

Thanks

You'd be right, spacer_close needed a fourth </div>. How the hell I managed to take that out and not notice the side effects I don't know. :surprised: Anyway, I've updated and tested both templates now, having made a few other small changes. As an additional bonus it now validates throughout on a default vB installation (which mine isn't, so it's not perfect). All of the original download links have been updated and...

Quote:

Sorry, please attach the hack here within 24 hours of this notice, all hack threads must have their hacks attached.

... I've attached the new .zip to my first post as well.

I've checked as many pages as is possible in the space of a few minutes and it all looks good, but will use the templates myself for a while to make sure it is perfect. If anyone does spot a problem, just post here.

(Oh and I just spotted the 3.6 beta is out - I will release updated versions of the FB templates in a while, but for the time being my live and debugging forums are staying on 3.5)

Quote:

Originally Posted by Dom.S

You'd be right, spacer_close needed a fourth </div>.

As I'd love to say it's working, it's really not. Let me explain:

FORUMHOME and FORUMISPLAY work fine.
SHOWTHREAD does not.

You had mentioned that you did find issue in the spacer_close, but that would also mean you would have had to make changes in the spacer_open which you hadn't really mentioned anything about.

spacer_open has 3 opening divs, spacer_close has 3 ending divs. Thats fine, and that is most likely why the FORUMHOME and FORUMDISPLAY work fine.

Now, if I'm not mistaken, I think your "SHOWTREAD" template could be messing up somewhere. I'm not a VB skin expert, so I cannot tell what the problem is, but I think you could easily help me fix this.

Here is the URL with the issue.

As you can see, the other templates/areas look fine.

Could you please advise what I need to do so this SHOWTHREAD template works as designed?

Thanks in advance :)

I did not modify spacer_open at all to fix this issue. However it is possible that I have updated it on a previous occasion as I did update the .zip within a couple of days of releasing the template when I found a few small bugs. Anyway, here is how spacer_open should look:

Code:

<div class="fbcontent">

<!-- open content container -->

<if condition="$show['old_explorer']">

        <table cellpadding="0" cellspacing="0" border="0" width="$stylevar[outertablewidth]" align="center"><tr><td class="page" style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">

<else />

<div align="center">

        <div class="page" style="width:$stylevar[outerdivwidth]; text-align:$stylevar[left]">

                <div style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">

</if>

As you can see, four opening <div> tags (note the fbcontent one at the very top). spacer_close should then be:

Code:

<if condition="$show['old_explorer']">

        </td></tr></table></div>

<else />

                </div>        

        </div>

</div>

</div>

</if>

<!-- / close content container -->

That is the code currently included in the template downloads and should work fine, as you can see at the demo site.

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (3)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (3)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.03058 seconds Memory Usage 1,727KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (3)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (1)post_thanks_navbar_search (1)printthread (3)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: