vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   Show Thread Enhancements - [AJAX] Post Thank You Hack (https://vborg.vbsupport.ru/showthread.php?t=165673)

MedellinStyle 02-07-2010 10:32 PM

Any Idea How I Can See Post Thank Stats, For Example To Give Prizes To Most Thanked User Of The Week ????????????????

jGas 02-08-2010 07:39 AM

hi, and thanks for this mod!
i'm wondering if there's a way to display the most thanked post of my whole board... can you help me?
thanks!

Makc666 02-08-2010 05:14 PM

As this one died on page 114.
I am posting this one again here.
The bug is also in version for 4.* as the core part was not changed.

BUG

There is a serious bug which has effect on forums which have several languages on them.

The problem is with actions:
  • Remove Your Thanks
  • Remove All

The effected file is:
Code:

./includes/functions_post_thanks.php
Function is:
PHP Code:

function delete_all_thanks($postinfo$remove_users_thanks_count true)
{
...


Code is:
PHP Code:

        if ($vbulletin->options['post_thanks_reputation'] && ($remove_users_thanks_count == true || $vbulletin->options['post_thanks_delete_remove_thanks_count']))
        {
            
$vbulletin->db->query_write("DELETE FROM "TABLE_PREFIX ."reputation WHERE postid = '$postinfo[postid]' AND reason = '$vbphrase[post_thanks_thanked_post]'");

            if (
$vbulletin->db->affected_rows() != 0)
            {
                
$total_rep_got $vbulletin->options['post_thanks_reputation'] * $nb;
                
$set_user_got .= ", reputation = reputation - $total_rep_got";
            }
        } 

Line:
PHP Code:

$vbulletin->db->query_write("DELETE FROM "TABLE_PREFIX ."reputation WHERE postid = '$postinfo[postid]' AND reason = '$vbphrase[post_thanks_thanked_post]'"); 

Problem part:
PHP Code:

AND reason '$vbphrase[post_thanks_thanked_post]' 

As you can see you use $vbphrase[post_thanks_thanked_post].

But for every language it has it's own "variable".

For English it will be "Thanked Post".
For German it will be "Dankte Post".
For Russian it will be "Сообщение с благодарностью".
etc.

So if Admin uses English and will hit 'Remove All' then only English reputation comments with points will be deleted. All other languages reputation comments with points will not be deleted.

The same for normal user.
The biggest problem is here!!!
  1. Normal user give "Thanks You" in one Language
  2. Then he switches to another language
  3. He hits remove his "Thanks You"
  4. And the reputation comment with points will not be deleted!!!
  5. So the user can give "Thanks You" Points again and again!!!

I am thinking for two days how to fix this one.

Of course we can try to search for all languages variables but the problem is that language variables can be changeable.
So this is not a clear decision.

We can also remove
PHP Code:

AND reason '$vbphrase[post_thanks_thanked_post]' 

But this will delete normal reputation comments.

The only "fix" for this one I see is to have another table with comments' IDs which where given by pressing "Thank You" button.

This will be the best and as I can see the only one correct variant.

P.S. The same problem (BUG) is for [AJAX] Post Groan Hack.

PHP Code:

function delete_all_groans($postinfo$remove_users_groan_count true)
{
...
$vbulletin->db->query_write("DELETE FROM "TABLE_PREFIX ."reputation WHERE postid = '$postinfo[postid]' AND reason = '$vbphrase[post_groan_groaned_post]'");
...



twista46 02-11-2010 09:47 AM

Sry for my bad english

I have a quest too Reputation and Hide Hack

I would like if you would like to thank the user a certain number reputation is subtracted. How can the setting?

kmoh 02-13-2010 08:13 PM

how do i show my thanked/thanks count on the postbit? Its already activated at the admin cp but its not showing there.

hamidpark 02-14-2010 09:41 PM

can we restore post thank from a database backup ? i want just restore post thanks tables . what i should do ?

twista46 02-15-2010 06:42 AM

Sry for my bad english

I have a quest too Reputation and Hide Hack

I would like if you would like to thank the user a certain number reputation is subtracted. How can the setting?

twista46 02-16-2010 03:44 PM

no idea? :(:(

bahrame 02-16-2010 09:03 PM

i install for vb 3.8.4
but............................

pls help me

Code:

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/init.php on line 55

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/init.php on line 107

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/init.php on line 111

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/init.php on line 119

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/init.php on line 130

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/init.php on line 134

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/init.php on line 142

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/init.php on line 211

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/init.php on line 389

Deprecated: Assigning the return value of new by reference is deprecated in /home/sat/public_html/forum/includes/class_core.php on line 2552

why??????????????????

weindians 02-17-2010 01:56 PM

this worst supported mod in here... the coder hasnt been answering any of the questions here....


All times are GMT. The time now is 03:14 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02691 seconds
  • Memory Usage 1,764KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (6)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete