vb.org Archive - Miscellaneous Hacks - Rotating Banner System

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)

- - Miscellaneous Hacks - Rotating Banner System (https://vborg.vbsupport.ru/showthread.php?t=188328)

hi,
I am trying to validate my site and getting this error:

general entity "userid" not defined and no default entity
?.s-maof.com/Forum/rbs_banner.php?id=1&userid=0" target="_blank"><img src="http?

I am trying to replace it to

?.s-maof.com/Forum/rbs_banner.php?id=1&userid=0" target="_blank"><img src="http?

where in the code could I find that? :D

never mind - I managed - it's in the - dbtech/vbnavtabs/includes/functions.php

Quote:

Originally Posted by ohadpartuck (Post 2331378)

never mind - I managed - it's in the - dbtech/vbnavtabs/includes/functions.php

I don't think so ... vbtech isn't rbs :)

Please verify after the changes, the banners are still cliccable, since a some servers don't accept "amped" URL's without side effects.

Great mod. Thank you very much

-------------

In next release you may improve this:

In the file (includes/functions_rbs.php)

Replace this:

Code:

$url = sprintf('%s/rbs_banner.php?id=%d&userid=%d', $bburl, $rs['id'], $rbs_userid);

With:

Code:

$url = sprintf('%s/rbs_banner.php?id=%d&userid=%d', $bburl, $rs['id'], $rbs_userid);

Before:

https://vborg.vbsupport.ru/attachmen...1&d=1337679644

After:

https://vborg.vbsupport.ru/attachmen...1&d=1337679823

:)

thanks. they are.
you are wright,btw, I changed it in the mods now that I think about it..

Yeah ... we have this problem handled for many times, and all I can tell about is, once again: not all web servers accept "amp"-ed & symbols. The unamped version is however handled everywhere and I prefer to have always cliccable banners than rather some not.

by servers you mean browsers? becasuse if you mean servers I have only one and I am not going to change it any time soon . I think getting rid of the validation errors is a noble enough cause.

I mean servers. Since not all are Apache nor IIS, and not all redirect mechanisms work the same way, some of the web servers redirect "amp"-ed URL's to nowhere.

I agree with you, that most servers should by now adhere to the standards, but since the problem has happened in the past and still there are strange things in the wild, you maybe are better off with changing this piece of code yourself ;)

Quote:

Originally Posted by Videx (Post 2331353)

So, a non-technical explanation: It's highly unlikely that those hourly attacks are anything more than bots trying to find an easy way in. Don't worry - as long as you keep vb and the server updated they really aren't too much of a worry.

I don't think "check your access rights" is the same as saying "set all your file permissions to allow yourself to be hacked". In general, vb files should all be 644 and directories 755.

I missed the part where you explained what error(s) you're getting, and where you gave us a link and test login (if required) to look at things. Have you already simply asked your tech people (your host's tech support?)? It's very common for them to set security in such a way that you can't run your own files. When that happens they can set exceptions. If you ask them nicely. :)

:)

No not the host's support, we have a dedicated server security admin as SEO forums attract a certain 'type' of web user. As soon as I put it in his hands, he had it running in under 5 minutes. The problem was unique to our server's configuration.

So that just goes to show you that I shouldn't handle these things...

But none the less, I wanted to apologize to anyone that may have been offended or misunderstood my previous posts. Sometimes I type things that end up sounding a lot different than how I meant them, so... I totally take the blame there.

Again, apologies. :)

Quote:

Originally Posted by y2ksw (Post 2328093)

No, they aren't. Impressions is the number of times a banner has been shown. The more active banners you have in your database, the less will be the impression count on each, provided they are evenly distributed.

Thanks for the reply y2ksw. But I do not understand exactly the difference CMS to charge for my sponsors:confused:.

I did not understand this part, may explain it a little more?

Quote:

Originally Posted by y2ksw (Post 2328093)

The more active banners you have in your database, the less will be the impression count on each, provided they are evenly distributed.

thanks

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (4)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (5)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.02839 seconds Memory Usage 1,746KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (4)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (5)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: