vb.org Archive
Page 19 of 240 « First 91718 19 20212969119 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   Show Thread Enhancements - [AJAX] Post Thank You Hack (https://vborg.vbsupport.ru/showthread.php?t=165673)

Namaless 01-27-2008 01:51 PM
Quote:
Originally Posted by Abe1 (Post 1429712)
It would be possible but wouldn't that slow down the forum?
I have added and the sistem not have problem. Without is very horrible, and if you use "fetch_musername function" get from cache and not use more system power.

Abe1 01-27-2008 04:15 PM
Quote:
Originally Posted by Namaless (Post 1430068)
I have added and the sistem not have problem. Without is very horrible, and if you use "fetch_musername function" get from cache and not use more system power.
I know about fetch_musername. I just did wasn't sure where it pulled all the infor for the so many different users.

Abe1 01-27-2008 04:35 PM
Quote:
Originally Posted by Namaless (Post 1430068)
I have added and the sistem not have problem. Without is very horrible, and if you use "fetch_musername function" get from cache and not use more system power.
This is what I found, let me know if you have a better idea:

I changed:
PHP Code:
$cache[$thank['postid']][$thank['userid']]['username'] = $thank['username']; 
to
PHP Code:
$cache[$thank['postid']][$thank['userid']]['username'] = fetch_musername(fetch_userinfo($thank['userid'])); 
In order for musername to work, you need to send the whole userinfo.

I ran this on a page that had well over a thousand thanks. I ended up runing over 1400 quesries and it taking 8 seconds to load!

Let me know if you have another way. This is NOT good.

takworld 01-27-2008 04:37 PM
thanks for this hack , very good .

Namaless 01-27-2008 06:19 PM
I have used this code:
PHP Code:
$thanks = $vbulletin->db->query_read("SELECT * FROM " .TABLE_PREFIX. "post_thanks AS ps INNER JOIN " .TABLE_PREFIX. "user AS u ON (u.userid = ps.userid) WHERE ps.postid IN (" . $post_ids . ") ORDER BY ps.username ASC"); 
For query.

For get musername use this method:
PHP Code:
//$cache[$thank['postid']][$thank['userid']]['username'] = $thank['username'];
            // Get vBulletin User Group ID
            $UserGroupID = ( $thank['displaygroupid'] == 0 ) ? 'usergroupid' : 'displaygroupid';
            $cache[$thank['postid']][$thank['userid']]['username'] = fetch_musername($thank, $UserGroupID); 
Without this have 21 queries and after my edit give same 21 queries.

Please check your performance..

Thanks :)

saman 01-27-2008 07:03 PM
Quote:
Originally Posted by Abe1 (Post 1429636)
Make sure you removed any template edits you made. The current version requires no template edits.
I removed the edits (in posbits) but the thanks (button/option) is still not appearing LINK

blue6995 01-27-2008 07:51 PM
Since installing latest update I get this error when clicking on the Thanks button:

Warning: Invalid argument supplied for foreach() in /includes/functions_post_thanks.php on line 183

blue6995 01-27-2008 08:02 PM
Quote:
Originally Posted by blue6995 (Post 1430305)
Since installing latest update I get this error when clicking on the Thanks button:

Warning: Invalid argument supplied for foreach() in /includes/functions_post_thanks.php on line 183

Oops! I never uploaded the new post_thanks.php file.

jacki 01-27-2008 08:17 PM
hi
install post Thank you 7.2

post error

PHP Code:
Warning: Invalid argument supplied for foreach() in /includes/functions_post_thanks.php on line 183 
line 183 :




PHP Code:
foreach ($thanks AS $thank) 


And post eror :)

PHP Code:
''Cookielere eklenemedi, başlık (header) zaten g?nderildi.
Dosya: /home/********/public_html/includes/class_core.php
Line: 3142'' 

Abe1 01-27-2008 09:38 PM
Quote:
Originally Posted by Namaless (Post 1430256)
I have used this code:
PHP Code:
$thanks = $vbulletin->db->query_read("SELECT * FROM " .TABLE_PREFIX. "post_thanks AS ps INNER JOIN " .TABLE_PREFIX. "user AS u ON (u.userid = ps.userid) WHERE ps.postid IN (" . $post_ids . ") ORDER BY ps.username ASC"); 
For query.

For get musername use this method:
PHP Code:
//$cache[$thank['postid']][$thank['userid']]['username'] = $thank['username'];
            // Get vBulletin User Group ID
            $UserGroupID = ( $thank['displaygroupid'] == 0 ) ? 'usergroupid' : 'displaygroupid';
            $cache[$thank['postid']][$thank['userid']]['username'] = fetch_musername($thank, $UserGroupID); 
Without this have 21 queries and after my edit give same 21 queries.

Please check your performance..

Thanks :)
Not bad performance on that page. Just about .1 sec. longer to load. from .5 to .6 average to load.

Will look into now.


All times are GMT. The time now is 02:23 PM.
Page 19 of 240 « First 91718 19 20212969119 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02557 seconds
  • Memory Usage 1,778KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (9)bbcode_php_printable
  • (6)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete