vb.org Archive - vRewrite - SEOed URLs for vBulletin

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)

- - vRewrite - SEOed URLs for vBulletin (https://vborg.vbsupport.ru/showthread.php?t=104484)

That one is fine, there are a few queries in the plugin. You should have what I posted...

Thanks Derek....I'll update the plugin shortly. I was thinking of that, but since it was working just fine on my test board - I wasn't sure.

outright removing the code fixed it... error and code below... :ermm:

Quote:

Fatal error: Call to a member function on a non-object in /home/linkforc/public_html/forum/includes/functions.php(4320) : eval()'d code on line 139

PHP Code:


		
			
#------------------------------

# Replace Last Post User (Forum)

#------------------------------

$found = preg_match_all('#<a href="member\.php\?find=lastposter&amp;f=([0-9]+)"#i', $output, $matches);



if($found)

{

    // Build an array of ID's

    $ids = array();



    for($i = 0; $i < $found; $i++)

    {

        if(is_numeric($matches[1][$i]))

            $ids[] = $matches[1][$i];

    }

    $ids = implode(',', $ids);



    // Go through each

    $res = $vbulletin->db->query_read("SELECT lastposter, forumid FROM " . TABLE_PREFIX . "forum WHERE forumid IN($ids)");



    while($f = $vbulletin->db->fetch_array($res))

    {

        $lp = $f['lastposter'];



        $lpidinfo = $vbulletin->db->query_first("SELECT userid, username FROM " . TABLE_PREFIX . "user WHERE username='".$db->escape_string($lp)."'");

        $lp = urlize($lpidinfo['username']);

        $lpid = $lpidinfo['userid'];

        $fid = $f['forumid'];



        



        $output = str_replace("<a href=\"member.php?find=lastposter&amp;f=$fid\"", "<a href=\"u-$lp-$lpid.html\"", $output);

    }





}



#------------------------------

# Replace Last Post User (Thread)

#------------------------------

$found = preg_match_all('#<a href="member\.php\?find=lastposter&amp;t=([0-9]+)"#i', $output, $matches);



if($found)

{

    // Build an array of ID's

    $ids = array();



    for($i = 0; $i < $found; $i++)

    {

        if(is_numeric($matches[1][$i]))

            $ids[] = $matches[1][$i];

    }

    $ids = implode(',', $ids);



    // Go through each

    $res = $vbulletin->db->query_read("SELECT lastposter, threadid FROM " . TABLE_PREFIX . "thread WHERE threadid IN($ids)");



    while($f = $vbulletin->db->fetch_array($res))

    {

        $lp = $f['lastposter'];



        $lpidinfo = $vbulletin->db->query_first("SELECT userid, username FROM " . TABLE_PREFIX . "user WHERE username='".$db->escape_string($lp)."'");

        $lp = urlize($lpidinfo['username']);

        $lpid = $lpidinfo['userid'];

        $tid = $f['threadid'];



        



        $output = str_replace("<a href=\"member.php?find=lastposter&amp;t=$tid\"", "<a href=\"u-$lp-$lpid.html\"", $output);

    }





}

Wait, try making it this instead:

PHP Code:


		
			
$lpidinfo = $vbulletin->db->query_first("SELECT userid, username FROM " . TABLE_PREFIX . "user WHERE username='".$vbulletin->db->escape_string($lp)."'");

that did the trick.. but view first unread's kinda broken

Code:

http://www.site.com/forum/#post1814

It didn't do that before?

it didnt work at all until now.. it seems to be somthing to do with the template edit i did to install it because it does it with it disabled but if i remove the template modifications its fine again ... will it cause any problems just to leave the template modifications out?

removing the SHOWTHREAD modification did the trick with the plugin disabled.. im about to try it with it enabled... is there somthing wrong with my template?

heh.. removing the template modification is bad lol... any ideas on fixing the link?

I've seen issues where other mods take control of it ex:
title-of-thread-id.html0 I have no idea why it does that, so it may be a template modification or another hack that isn't working together right.

Edit...didn't see your edit. Is it possible for you to PM me a link so I can have a nosey around?

ok, so i got to the point where the arguments about whos vb seo thingy was bigger... i mean better and i stopped reading so i dont know if what i am going to say was covered or not. my thanks goes out to anyone whom is attempting to better this community. both immortal and dean alike.

- %20 should never be in a url... period

- filenames should never be longer(at max) than 31 charcters. its a mac thing

- does this hack have any way to actually prevent duplicate content being spidered by the search enginges?

and yes from what i have read about this hack is that the queries need to be reduced. but knowing that comes from having seen a vbforum die at about 500 users on at one time using a 512 server. mysql is a memory sucking beast. the less times you call upon the evil the better... period. if i were to install this hack on the 10k unique a day forums that i considered in the first place, it would crash the box or jsut slow everything down to a snails pace. even with the 4 gigs of ram that are now in that server.

it seemed like the dean guy was trying to offer some advice, perhaps he should have done so via pm instead of being a jerk and jsut tellign everyone not to install. that wasnt right.

my two cents... i will be looking back into this from time to time, thanks again for the work, i bet version 5 will be awesome ;) (and most likly paid :( )

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code_printable (2)bbcode_php_printable (1)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (4)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.02288 seconds Memory Usage 1,771KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code_printable (2)bbcode_php_printable (1)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (4)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: