vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - Yet Another Awards System (https://vborg.vbsupport.ru/showthread.php?t=232684)

blackberry 08-17-2015 06:51 PM

Quote:

Originally Posted by CAG CheechDogg (Post 2552918)
That is the fix right there ... for the icons used relative url: images/medals/icons/your_icon_file

For the image url use the full url: h t t p://www.your_domain.com/your_forum_root/images/medals/your_image_file

ahaan ok got it

and its fixed.:D

squidsk 08-17-2015 06:55 PM

Quote:

Originally Posted by blackberry (Post 2553078)
not using https.. but did renamed directories for security reasons. I would be better if we are able to edit path within any php file etc.

When you uploaded the most current version did you remember to rename the admincp/modcp folder in the upload folder to your renamed admincp/modcp names?

CAG CheechDogg 08-18-2015 02:16 AM

Quote:

Originally Posted by squidsk (Post 2553062)
I'm unable to reproduce this. If I use either an absolute or relative url I see the image in PMs that are issued.
Is your site running on https? Have you renamed your admincp and/or modcp directories?



I can't reproduce the error. I'm able to use both a relative url and an absolute url to display award images. Have you renamed your admincp and/or modcp directories? I also notice that your admincp/award.php page has also been customized since it's displaying the point value of the awards which isn't included by default, though really it should be, perhaps something with your customization is causing problems.

My site "IS" running on https, we discussed this months ago when I first installed this mod ...

I have also renamed my admincp and mocp, but this was happening before I installed BOP5's mod to rename the register.php which renames bot the admincp and modcp found here:https://vborg.vbsupport.ru/showthrea...ENAME+register

my adminc/award.php page only has css modifications, the point value I add it manually to the description lol ...

So no, none of my customizations are causing the problem, this was happening way before. I actually don't have any problem because the images appear everywhere except in the admincp when managing each award the way it shows in the screenshots I posted ... So really it's no big deal for me ....


Squidsk, this is what you posted when I first brought up the issue of the images and the urls:

Quote:

Originally Posted by squidsk (Post 2349060)
I don't see anything in the code that would cause absolute urls to fail. The default medals use absolute url and they display without a problem. As for relative urls not working, its because the [img] tag does not handle relative urls.

Here is the first time I posted about this issue:
https://vborg.vbsupport.ru/showpost....postcount=1182

Then you replied with this:

https://vborg.vbsupport.ru/showpost....postcount=1189

Then you replied with this lol ..:

https://vborg.vbsupport.ru/showpost....postcount=1199

Originally Posted by CAG CheechDogg View Post

Ah snaps! Makes sense..so If I enable html just in that forum it should be fine right?

No, because the post was created with the assumption that html would not work, so bbcode was used instead. The problem is that the bbcode does not handle relative links. A fix to the bbcode, no likely to be done, or a fix to the code to generate that post which prepends the site url to relative urls needs to be done. I can likely do the second, but wouldn't count on jelsoft doing the first. They may even have reasons for not doing it, which if I were to guess it would be because it is too difficult to determine what a valid relative url looks like.



Like I said no big deal really, I can live with this little bug because everything else works just fine ....

CAG CheechDogg 08-18-2015 02:22 AM

I have a request Squidsk ...

Is it possible to add a feature to approve more than one award request from the award request page instead of doing them one by one?

alcazarx 08-18-2015 05:59 PM

That could be done with a checkbox under "options" and two buttons below the list "grant selected awards" / "delete selected awards".
But this would require JavaScript me thinks and unfortunately me dont know JS :(

/* edit
CAG, you really have some nice medals/awards on your page :cool:
*/

/*
another edit:
*/
Dont know if this a bug or a feature :p ,but even when you set awards to not be recommended or requested you can by using the direct link (like ".../forum/request_award.php?award_id=6") and changing the award_id.
Maybe an oversight by master squidsk? :rolleyes:

squidsk 08-20-2015 06:31 PM

Quote:

Originally Posted by blackberry (Post 2553078)
not using https.. but did renamed directories for security reasons. I would be better if we are able to edit path within any php file etc.

Not sure what you mean, it would be pretty horrible to force people using yaas to have to edit every file just to change the path to an award. The path is set through admincp individually for each award and the path is stored with the award information in the database.

Quote:

Originally Posted by CAG CheechDogg (Post 2553128)
My site "IS" running on https, we discussed this months ago when I first installed this mod ...

I have also renamed my admincp and mocp, but this was happening before I installed BOP5's mod to rename the register.php which renames bot the admincp and modcp found here:https://vborg.vbsupport.ru/showthrea...ENAME+register

my adminc/award.php page only has css modifications, the point value I add it manually to the description lol ...

So no, none of my customizations are causing the problem, this was happening way before. I actually don't have any problem because the images appear everywhere except in the admincp when managing each award the way it shows in the screenshots I posted ... So really it's no big deal for me ....

It isn't the change the register.php mod because I added that to my test install and it causes no issues. The reason it's kind of confusing is that the code that shows the images for both the award icon and award image are the same. They are both done using calls to construct_img_html, see lines 1028/1029 for non-categorized awards and lines 1093/1094 for categorized awards. So if absolute is working for the icon image it should work for the other image. Similarly if relative urls are working for

Quote:

Squidsk, this is what you posted when I first brought up the issue of the images and the urls:
I'd forgot about that.

Quote:

Here is the first time I posted about this issue:
https://vborg.vbsupport.ru/showpost....postcount=1182

Then you replied with this:

https://vborg.vbsupport.ru/showpost....postcount=1189

Then you replied with this lol ..:

https://vborg.vbsupport.ru/showpost....postcount=1199
The first part is where I'm talking about the absolute urls in admincp, even then I couldn't find a reason why they weren't showing for you. The second part was about images not showing up in PMs because of how the image bbcode was parsed. I fully fixed the second issue in 4.0.7, but clearly the first is still there.

Quote:

Like I said no big deal really, I can live with this little bug because everything else works just fine ....
It might not be a big deal but it still bugs me that there's a problem somewhere in the code, or in compatibility with something else, and I can't figure it out.

Quote:

Originally Posted by CAG CheechDogg (Post 2553129)
I have a request Squidsk ...

Is it possible to add a feature to approve more than one award request from the award request page instead of doing them one by one?

I'll look into it.

Quote:

Originally Posted by alcazarx (Post 2553171)
That could be done with a checkbox under "options" and two buttons below the list "grant selected awards" / "delete selected awards".
But this would require JavaScript me thinks and unfortunately me dont know JS :(

That's how I'd do it.
Quote:

/*
another edit:
*/
Dont know if this a bug or a feature :p ,but even when you set awards to not be recommended or requested you can by using the direct link (like ".../forum/request_award.php?award_id=6") and changing the award_id.
Maybe an oversight by master squidsk? :rolleyes:
Definitely not a feature but an oversight.

akz645 08-20-2015 08:01 PM

Quote:

Originally Posted by squidsk (Post 2553340)
I'll look into it.

Did you see my suggestions?

Quote:

Originally Posted by akz645 (Post 2551912)
Suggestion:
- Option for awards to be stackable.
Example:
https://vborg.vbsupport.ru/external/2015/08/17.png

I would be ever so grateful, if you could make this possible :)

Edit:
Suggestion 2:
- Allow users to arrange which order they they wish to display their awards in their postbit via UserCP.
Example: Like the Navigation bar display order, they can assign numbers. The lower the number assigned, the higher up in the postbit the award they've earned will be displayed.


CAG CheechDogg 08-21-2015 01:12 AM

Quote:

Originally Posted by squidsk (Post 2553340)

It isn't the change the register.php mod because I added that to my test install and it causes no issues.

It might not be a big deal but it still bugs me that there's a problem somewhere in the code, or in compatibility with something else, and I can't figure it out.

I'll look into it.

Yeah I also don't believe it's the register.php mod at all ... I just mentioned it because you asked if I had renamed my admincp and that mod renames the admincp and modcp as well ...

Thanks for looking into possibly adding the mass approve feature that would be some awesomeness !!!

And yes I know what you mean about the "bug" ... it bugs the heck out of me as well when I can't figure something out as well ...

blackberry 08-21-2015 11:28 AM

Quote:

Originally Posted by squidsk (Post 2553340)
Not sure what you mean, it would be pretty horrible to force people using yaas to have to edit every file just to change the path to an award. The path is set through admincp individually for each award and the path is stored with the award information in the database.

Never mind tt is fixed now :)

squidsk 08-21-2015 08:19 PM

Quote:

Originally Posted by akz645 (Post 2553343)
Did you see my suggestions?

Yes. At this time only the second might get implemented at some point as the first would require a significant amount of work to change the mod to implement.


All times are GMT. The time now is 09:26 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.09691 seconds
  • Memory Usage 1,790KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (17)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete