vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - Product Review Forums ? Research, Review & Compare Items (https://vborg.vbsupport.ru/showthread.php?t=269808)

Morrus 08-31-2014 09:20 PM

Quote:

Originally Posted by Ted S (Post 2513280)
So how do you know there's no line breaks? There shouldn't be any review at all...

Whether or not there shouldn't be a review, there is one. I don't know what else to tell you! .)

You're welcome to try it out yourself. Post a review and you'll see what it does.

http://www.enworld.org/forum/productforums.php

Ted S 08-31-2014 09:27 PM

1 Attachment(s)
Quote:

Originally Posted by Morrus (Post 2513283)
Whether or not there shouldn't be a review, there is one. I don't know what else to tell you! .)

You're welcome to try it out yourself. Post a review and you'll see what it does.

http://www.enworld.org/forum/productforums.php

Ok, I think I'm starting to understand more of the issue though still not sure why. I'll keep apologizing for this but there's no other way to chase it down until we can figure out what setting you have (I'm sure it's a legitimate one) is breaking things.

Can you run this version of forum/productforums.php and see if the review saves to the database?

Nothing will change in your styling.

Morrus 09-01-2014 06:44 AM

Quote:

Originally Posted by Ted S (Post 2513285)
Ok, I think I'm starting to understand more of the issue though still not sure why. I'll keep apologizing for this but there's no other way to chase it down until we can figure out what setting you have (I'm sure it's a legitimate one) is breaking things.

Can you run this version of forum/productforums.php and see if the review saves to the database?

Nothing will change in your styling.

So good news: yes - that does now appear in the database.

The database entry contains the full text of the review, with all formatting stripped. I've double checked by copying and pasting it from PHPMYADMIN to Notepad, and there are no tags or breaks of any kind there.

(Also, somewhat unfortunately, the new file undoes some changes I made which allowed me to do the latest reviews page and show publisher names next to product names; that's not too serious for the moment though).

Ted S 09-01-2014 04:57 PM

1 Attachment(s)
Quote:

Originally Posted by Morrus (Post 2513324)
So good news: yes - that does now appear in the database.

The database entry contains the full text of the review, with all formatting stripped. I've double checked by copying and pasting it from PHPMYADMIN to Notepad, and there are no tags or breaks of any kind there.

(Also, somewhat unfortunately, the new file undoes some changes I made which allowed me to do the latest reviews page and show publisher names next to product names; that's not too serious for the moment though).

We're you able to update the new plugin version?

If not, try opening up the template prodforums_review_create and use this version:

These changes... were they hacks to the code and if so, at what points (so I can make them into hooks).

Morrus 09-01-2014 05:12 PM

Quote:

Originally Posted by Ted S (Post 2513396)
We're you able to update the new plugin version?

If not, try opening up the template prodforums_review_create and use this version:

I just uploaded the productforums.php file you posted above. Was there another thing?

Quote:

These changes... were they hacks to the code and if so, at what points (so I can make them into hooks).
A load of template changes and some alterations of productforums.php. Nothing big, mind you - I don't understand what I'm doing, so I just copy bits from elsewhere in the file and see if they work. The recent reviews thing was a copy/paste of the whole "list reviews by reviewer" with the reviewer matching criteria removed and a do=recent thingy (whatever that is called) added, and there are some changes to the way product ratings are calculated so that they get an overall % ranking based on the individual 1-5 ranks.

I can upload it if you're curious (or, hell, if anyone else wants to use it).

Ted S 09-01-2014 05:17 PM

Quote:

Originally Posted by Morrus (Post 2513399)
I just uploaded the productforums.php file you posted above. Was there another thing?



A load of template changes and some alterations of productforums.php. Nothing big, mind you - I don't understand what I'm doing, so I just copy bits from elsewhere in the file and see if they work. The recent reviews thing was a copy/paste of the whole "list reviews by reviewer" with the reviewer matching criteria removed and a do=recent thingy (whatever that is called) added, and there are some changes to the way product ratings are calculated so that they get an overall % ranking based on the individual 1-5 ranks.

I can upload it if you're curious (or, hell, if anyone else wants to use it).

The other thing was the complete XML plugin but while the template manager should keep your changes, let's not risk it... Just manually replace that one template in my previous post and let's see if that fixes the editor.

Morrus 09-01-2014 05:42 PM

Quote:

Originally Posted by Ted S (Post 2513400)
The other thing was the complete XML plugin but while the template manager should keep your changes, let's not risk it... Just manually replace that one template in my previous post and let's see if that fixes the editor.

Tried it, but it didn't help, sadly. Still no WYSIWYG editor toolbar and no linebreaks etc. saved.

Ted S 09-01-2014 06:03 PM

Quote:

Originally Posted by Morrus (Post 2513402)
Tried it, but it didn't help, sadly. Still no WYSIWYG editor toolbar and no linebreaks etc. saved.

What browser / os are you using?

Also, I've got a test account on your site... any sub-forums with reviews enabled that I can get too (it's "Ted S").

Morrus 09-01-2014 06:16 PM

Quote:

Originally Posted by Ted S (Post 2513404)
What browser / os are you using?

Also, I've got a test account on your site... any sub-forums with reviews enabled that I can get too (it's "Ted S").

The latest Firefox on Windows 7.

Also the same when I try iOS.

I turned off the automatic thread creation in forums (and that template change for the forum didn't seem to be working anyway). The reviews are at the default location, though.

Ted S 09-02-2014 11:55 PM

Quote:

Originally Posted by Morrus (Post 2513405)
The latest Firefox on Windows 7.

Also the same when I try iOS.

I turned off the automatic thread creation in forums (and that template change for the forum didn't seem to be working anyway). The reviews are at the default location, though.

One more request, this one very quick. Try turning off all your (other) plugins and load the write a review page. 99% sure it won't change anything but hey, it happens. Obviously best to do this at an off time and quickly.


All times are GMT. The time now is 09:34 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02288 seconds
  • Memory Usage 1,756KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (11)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (3)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete