vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Add-On Releases - Rewrite eBay Links (https://vborg.vbsupport.ru/showthread.php?t=144214)

ferreo 04-02-2008 02:15 PM

I fixed this by changing line 111 in the product-rewrite_ebay_links.xml file from

Code:

<validationcode><![CDATA[return (strlen($data) == 9);]]></validationcode>
to

Code:

<validationcode><![CDATA[return (strlen($data) == 10);]]></validationcode>
This took care of the admin CP error, but it wouldn't display the &campid=XXXXXXXXXX bit in the rewritten links. I just hardcoded my campaign ID in the XML file. Ready to keep on rocking.

Thanks for the quick update dismounted.

GoTTi 04-02-2008 03:54 PM

so u got it working ferreo?

creativepart 04-02-2008 04:08 PM

The campid is not being added. I changed the error look up to 10 so I'm not getting the error but it's not adding the campid to the link in the forum. It's just campid=&.....

I modifed the XML file by hard coding the CampID but I just wanted to let Dismounted know of this problem.

creativepart 04-02-2008 04:10 PM

I've made a donation to Dismounted for his great work on this. I think everyone else that's earned anything from this mod should do the same.

So, come on. Don't be selfish. It's time to reward the author.

There is a donation button above under his Avatar.

siliconfinance 04-02-2008 04:24 PM

Quote:

Originally Posted by Dismounted (Post 1480633)
Modification Updated!

2/04/2007 - Version 1.2
- Updated URL Format
- Updated ReadMe

The URL format is as specified in the developer documents. Please note that you MUST re-enter your Campaign ID in the options page!

Hi Dismounted,

Previously, someone tweaked your code on my site to work with vBseo. I would like to manually implement the changes you made to the script since the time that ebay changed its affiliate program.

Can you provide some sort of guidance?

Thank you in advance.

ferreo 04-02-2008 06:07 PM

Quote:

Originally Posted by creativepart (Post 1481053)
The campid is not being added. I changed the error look up to 10 so I'm not getting the error but it's not adding the campid to the link in the forum. It's just campid=&.....

I modifed the XML file by hard coding the CampID but I just wanted to let Dismounted know of this problem.

I modified line 57 of the XML file from

Code:

$newurl = 'http://rover.ebay.com/rover/1/711-1751-2978-71/1?toolid=10013&campid=' . $vbulletin->options['rewrite_ebay_links_pid'] . '&mpre=' . rawurlencode(str_replace('&amp;', '&', $url));
to

Code:

$newurl = 'http://rover.ebay.com/rover/1/711-1751-2978-71/1?toolid=10013&campid=XXXXXXXXXX' . '&mpre=' . rawurlencode(str_replace('&amp;', '&', $url));
and it's working fine now. Don't forget to replace XXXXXXXXXX with your 10 digit campaign ID.

I'm going to send a donation to dismounted as well, his plugin has done very well for me.

siliconfinance 04-02-2008 06:09 PM

Is that all I would need to do to make this work again?

ferreo 04-02-2008 06:12 PM

Quote:

Originally Posted by siliconfinance (Post 1481077)
Hi Dismounted,

Previously, someone tweaked your code on my site to work with vBseo. I would like to manually implement the changes you made to the script since the time that ebay changed its affiliate program.

Can you provide some sort of guidance?

Thank you in advance.


How does it conflict with vbseo? I use both dismounted's ebay rewrite and vbseo in parallel without any issues on my end.

ferreo 04-02-2008 06:17 PM

Actually, I found some discrepancy between dismounted's code and the one the link generator at EPN provides:


Code:

http://rover.ebay.com/rover/1/711-53200-19255-0/1?type=4&campid=XXXXXXXXXX&toolid=10001&customid=&mpre=
is the prefix that the generator spits out (eBay US Network),

Code:

http://rover.ebay.com/rover/1/711-1751-2978-71/1?toolid=10013&campid=XXXXXXXXXX&mpre=
is dismounted's code. I'll switch things around in the XML file, just to make sure. For now, I don't see any clicks or revenue tracked yet, this may be due to the reporting delay though.

ferreo 04-02-2008 06:23 PM

This is the file I am currently using. I have matched the prefix URL to the one from the generator for my campaign, the ID is hardcoded in line 57. Replace Xs with your campID.


All times are GMT. The time now is 11:36 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01370 seconds
  • Memory Usage 1,745KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_code_printable
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete