vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Major Additions - GRPS: Groups Commune 2.0.x (https://vborg.vbsupport.ru/showthread.php?t=127303)

vgevolution 06-01-2007 05:36 AM

hambil: I agree that the install instructions aren't perfect, but I'm not the one who said,
"I've looked in the product.xml, and everywhere else".
I called you out on your blatant exaggeration, simple as that. It was obvious you didn't look in all the files. Instead, you came here complaining about "how this has been installed 204 times" (error and all) and "this problem was pointed out 8 months ago" (that was fixed 13 minutes later, wasn't even the problem anyway).

That was awfully troll-like, and I took a defensive stance for some reason. I think the fact that you're a coder made it worse, since I'm sure you wouldn't like it if someone went into your product threads and started tossing around innuendo.

Despite that, I do apologize for being abrasive. I'm normally calmer than that. I would prefer that we all contribute constructive criticism to our favorite hacks, not go around bashing each other. I should have taken the high road and just answered your veiled question. I can admit when I've let my emotions get the better of me. I must remember to let my inner-Vulcan out during times like this. My bad. Being human sucks sometimes. :D

I guess I still answered your question, however rudely. :p

At least during the course of this pointless argument you did point out a valid flaw in the install instruction's logic, so hopefully sabe will fix it soon. Some good came out of this after all.

I'm not holding a grudge. You were abrasive, I was abrasive in response. You had your say. I've had my say, and admitted I was rude and apologized for that. Thus, I have nothing further to add regarding this. No need to drag this thread down. My apologies to those reading this as well. Let's get back to making suggestions and improving this mod.

Peace, Out.

hambil 06-01-2007 05:42 AM

Quote:

Originally Posted by vgevolution (Post 1258806)
You were abrasive

I don't intend to be, but I'm told I come across that way in email or online at times. I think I was just frustrated. Again, I apologize also. Thanks for being a sport :)

vgevolution 06-01-2007 07:03 AM

I saw this request was posted a long time ago, but not since. I'm wondering if anyone is still having trouble with, or doesn't like the way breadcrumbs work with GRPS, and would like to know how to change it to work like vBulletin's standard (my preference for viewthread.php):
WebsiteHome --> GroupsHome --> CategoryName --> GroupName
|
-->Function, Thread, Post, Edit, Moderate, etc.
Instead of this (the GRPS default for viewthread.php):
GroupsHome --> CategoryName --> GroupName
|
-->Function, Thread, Post, Edit, Moderate, etc.

If so, please let me know. The first crumb method shown is vBulletin-style crumb. The second method is more of a stand-alone crumb, as GRPS is meant to run mostly outside of vBulletin forums other than sharing the user database.

To maintain consistency throughout my site and the other hacks I have running, I had to modify the crumbs in GRPS to work more like the standard bread crumbs of vBulletin. This involves some minor edits to the php files' navbits. If anyone's interested, I'll send you a step-by-step. Obviously the steps would need to be repeated after every patch of GRPS, so if there's no interest, I'll understand. I've been testing it for a week now with no strange behavior, so I'm pretty sure it'll work for anyone.

I don't know if sabret00the would want me to post how to do it here or as an "addon", since this isn't a fix to a bug, but a change to a function that works as he intended.

sabret00the: any objections to me posting instructions on how to change the breadcrumbs to work like vBulletin crumbs here? Any chance of making this an option in v3.0 for those of us who want an integrated breadcrumb? It doesn't look like it would be hard to code the conditional. ;)

Anyway, I'm too tired to write it up tonight (3am!!), so g'nite!

hambil: Yep, no problem. I'm an irritable ol' coot sometimes too, especially when I get sleepy. :o

sabret00the 06-04-2007 03:30 PM

Quote:

Originally Posted by WDZaphod (Post 1257448)
Hi!
Is there a wishlist existing already for Version3? :D

whatever you'd like to see in version three, just post in here and it'll be considered.

vgrevolution: go ahead:

sabret00the 06-05-2007 04:03 PM

Quote:

Originally Posted by Endurer (Post 1251562)
No, I do not have any products/modifications installed that have anything to do with custom styles, and yes, It's happening within viewthread.php only.

I'll PM you the URL to the group now.

PS: Group description parses img vbcode but viewthread.php doesn't and instead displays the direct link to the image.

can you tell me if this fixes your style overwrite problems please.

sabret00the 06-05-2007 05:47 PM

Quote:

Originally Posted by vgevolution (Post 1251753)
I'm unable to use vBadvanced 3.0's integrate function on either browse.php or groups.php.

browse.php generates the following error:
Code:

PHP Fatal error:  Cannot redeclare fetch_avatar_url() (previously declared in /ideletedmypath/forums/includes/functions_user.php:259) in /ideletedmypath/forums/includes/functions_grps.php on line 32
It seems to be related to this line, specifically the "OR" part:

Code:

if (!function_exists('fetch_avatar_url') OR THIS_SCRIPT != 'groupshome')
I think it needs to use a different method to determine whether to pull the function without using the "OR" statement. By using vBa's integration code, the THIS_SCRIPT variable seems to allow the function to be called again. A nested if seems to work, but I'm not the expert on this code.

Now then, groups.php creates a blank page with no error related to the vBa integration.

This is all I see inside the generated html:

Code:

<!-- END TEMPLATE: navbar -->
<table class="page" align="center" cellpadding="0" cellspacing="0" width="100%">
<tbody>
<tr valign="top">
</tr>
</tbody>
</table>
<!-- BEGIN TEMPLATE: footer -->

I assume that something in the groups.php is unique that clears out the variables used by vBa so it thinks there's no content to insert.

Here's is the adv_portal template, and you can that there are three if statements that display content in three columns. I think those variables are lost, which would cause the error:

Code:

<table align="center" class="page" cellspacing="0" cellpadding="0" width="100%">
        <tr valign="top">
                <if condition="$show['left_column']">
                        <td width="$vba_style[portal_leftcolwidth]"<if condition="$show['center_column'] OR $show['right_column']"> style="padding-right: $vba_style[portal_colspacing]px"</if>>
                                $home[leftblocks]
                        </td>
                </if>
                <if condition="$show['center_column']">
                        <td valign="top">
                                $home[centerblocks]
                        </td>
                </if>
                <if condition="$show['right_column']">
                        <td valign="top" width="$vba_style[portal_rightcolwidth]"<if condition="$show['center_column'] OR $show['left_column']"> style="padding-left: $vba_style[portal_colspacing]px"</if>>
                                $home[rightblocks]
                        </td>
                </if>
        </tr>
</table>


Whew! I do, however, get this error in my error.log file with groups.php all the time, whether I'm using vBa or not:

Code:

script '/ideletedmypath/groups/cron.php' not found or unable to stat
It looks like the path to /ideletedmypath/forums/cron.php gets lost somewhere.

Any ideas?

I feel like I'm close to wrapping up my initial development and this is holding me up, so any help would be appreciated.

EDIT:

invitation.php, membership.php and viewmembers.php have the same blank page output as groups.php when vBa 3.0 integration is used.


EDIT: Blank page fix for vBa 3.0 Integration

I was able to solve the problem with groups.php, invitation.php, membership.php and viewmembers.php and vBa 3.0 Integration by adding the following line into the "PRE-CACHE TEMPLATES and DATA" area near the top of each affected script:

Code:

// get special data templates from the datastore
$specialtemplates = array();

I also moved the "get special phrase groups" code to the top of that "section" so they would mirror the layout of the other working php files.

EDIT: Possible fix for PHP Fatal error: Cannot redeclare fetch_avatar_url()

I think the nested if statement is working as a fix for the php fatal error from the functions_grps.php file:

I changed this:

Code:

if (!function_exists('fetch_avatar_url') OR THIS_SCRIPT != 'groupshome')
{
... some code ...
}

to this:
Code:

if (!function_exists('fetch_avatar_url'))
{
if (THIS_SCRIPT != 'groupshome')
{
... some code ...
}
}

So far, everything seems to be working. I may have been able to change the OR to an AND to achieve a similar effect. I'm still rusty. :D

i cut down the need for modification by renaming the function.

sabret00the 06-05-2007 05:47 PM

Quote:

Originally Posted by vgevolution (Post 1252321)
This is a different error. It's not the Leader Icon not showing up error. That's a path problem. The integration of vBadvanced wrapped around GRPS causes this error. I was just wondering if anyone else ran into it and had a fix. Essentially the function fetch_avatar_url() that generates the leader icon returns "Array" instead of the correct URL string when vBa is active. I've asked the same question in the vBa forums, looking for a solution. If I find one, I'll post it here as well.

EDIT: Oops, I quoted the wrong error (malformed avatar in postbit), but my error still isn't solved with post #2's suggestions. On a side note, I have another hack which has the same error, VB Image Host.

do you still have this error?

sabret00the 06-05-2007 05:48 PM

Quote:

Originally Posted by CHIPIT195 (Post 1253654)
I have my forums on a subdomain (myforums.mysite.com)...
However, the forums are in a sub-directory (myforums.mysite.com/forums/)

The groups are installed at myforums.mysite.com/groups/

The links are showing the forums root... (ie: the create group link is myforums.mysite.com/forums/?do=creategroup, when it should be myforums.mysite.com/groups/?do=creategroup )

How do I fix this?

are you running any seo mods?

sabret00the 06-05-2007 05:52 PM

Quote:

Originally Posted by Merriweather (Post 1254745)
Sabre ~ Just checking in to see where you're at with the new version. Really hoping email notifications of group posts and checking user group permissions and removing them from groups if their permissions change is in the near future. :)

working on the latter now and the former is in place in principal at the current moment in time.

sabret00the 06-05-2007 06:01 PM

Quote:

Originally Posted by Yours Truly (Post 1255681)
Everything is going smooth except the navbar pointing to the wrong links but i can sort them.

Only thing that isn't working right is the group tools on the GRPS navbar dropdown isn't working. I click it then it just does nothing.

Any ideas?

is it not working on any of the pages?


All times are GMT. The time now is 03:26 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02800 seconds
  • Memory Usage 1,793KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (8)bbcode_code_printable
  • (8)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete