vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - Product Review Forums ? Research, Review & Compare Items (https://vborg.vbsupport.ru/showthread.php?t=269808)

GCC LLC 06-20-2013 06:15 PM

I wrapped it around the XML in product_forums.xml and reinstalled the product into vbulletin. It appeared to update something in all skins and I saw no errors (I also saw nothing get echo'ed back - but it went by all very fast in the install).

Links in the product review forum still do not click through to the corresponding threads. It is not the default vb mobile style, it is another mobile style designed for vB Suite 4.1.x.

Ted S 06-20-2013 07:02 PM

Quote:

Originally Posted by GCC LLC (Post 2429404)
I wrapped it around the XML in product_forums.xml and reinstalled the product into vbulletin. It appeared to update something in all skins and I saw no errors (I also saw nothing get echo'ed back - but it went by all very fast in the install).

Links in the product review forum still do not click through to the corresponding threads. It is not the default vb mobile style, it is another mobile style designed for vB Suite 4.1.x.

It's not quite that simple... to test you'd have to add it to varrious plugin routines inside the xml script so that echo statements are invoked as you load the pages you want to test (for example, you could echo back a test on the thread / product page or on the forum / product list).

As for how to fix it, I'd still suggest starting with the debugging to insure the mod is getting fired up but that's probably the case which means template hooks become the issues. For that you need to open up a default vB template and your mobile skin's (i.e. SHOWTHREAD which holds the product information) and see which hook variables have been removed.

If that sounds like greek, as the mod author if they ported over all the standard hooks into their SHOWTHREAD and FORUMDISPLAY templates.

GCC LLC 06-20-2013 09:23 PM

Got it figured out. I dug through the plugins and traced everything back to the following, in case anyone else runs into the same issue. Tom, you were correct in that the template hooks are not there by default in mobile styles. I also had to manually create each of the prodforum_* templates in our mobile style for some reason, but that's not a big deal.

The plugin renders the product information at the top of the showthread template into a template called showthread_above_posts. I looked for the hook inside of the SHOWTHREAD template in the mobile theme and it's just not there, so I added it in as follows:

{vb:raw template_hook.showthread_above_posts}

All is well!

Ted S 06-21-2013 04:47 AM

Quote:

Originally Posted by GCC LLC (Post 2429448)
Got it figured out. I dug through the plugins and traced everything back to the following, in case anyone else runs into the same issue. Tom, you were correct in that the template hooks are not there by default in mobile styles. I also had to manually create each of the prodforum_* templates in our mobile style for some reason, but that's not a big deal.

The plugin renders the product information at the top of the showthread template into a template called showthread_above_posts. I looked for the hook inside of the SHOWTHREAD template in the mobile theme and it's just not there, so I added it in as follows:

{vb:raw template_hook.showthread_above_posts}

All is well!

Fantastic!

How's everything else looking in the mobile theme? You can do a light version of the product page if you use it...

snakedevil 06-25-2013 07:42 AM

Hello Ted,

Thank you for this great mod, but I have a problem when sending an image in PNG, the image sent is no longer transparent but with a black background.

How to fix this please?

Thank you again!

Ted S 06-25-2013 02:30 PM

Quote:

Originally Posted by snakedevil (Post 2430335)
Hello Ted,

Thank you for this great mod, but I have a problem when sending an image in PNG, the image sent is no longer transparent but with a black background.

How to fix this please?

Thank you again!

That's up to the settings of GD on your server as it resizes the images... Does it happen elsewhere in vB?

snakedevil 06-25-2013 02:42 PM

No problem elsewhere, only on this mod :(

I have Chevereto and no problem

Ted S 06-25-2013 03:04 PM

Quote:

Originally Posted by snakedevil (Post 2430430)
No problem elsewhere, only on this mod :(

I have Chevereto and no problem

Hrm.

It's something in the image upload script but from the looks of it, could be one of a number of factors. We'll have to play around with it this weekend to see if we can force transparency on all GD setups.

snakedevil 06-25-2013 03:10 PM

Ok thank you,

In the meantime it is possible to display white instead of black? :)


Can be here ? :p

Quote:

function resize($width,$height) {
$new_image = imagecreatetruecolor($width, $height);
imagecopyresampled($new_image, $this->image, 0, 0, 0, 0, $width, $height, $this->getWidth(), $this->getHeight());
$this->image = $new_image;
}

Ted S 06-25-2013 03:26 PM

You can certainly try shifting the function around to see if it helps.

Functions stackoverflow shows people using for transparency:
imagealphablending($pathname, false); imagesavealpha($pathname, true);


All times are GMT. The time now is 02:17 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02133 seconds
  • Memory Usage 1,746KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete