vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - Product Review Forums ? Research, Review & Compare Items (https://vborg.vbsupport.ru/showthread.php?t=269808)

Volvoholic 01-31-2012 08:09 AM

Still getting the "this is an empty post" problem.

I have enabled the PF feature in that forum. Its is a forum not category.

I am using VB 4.1.7 and PF 1.2.2

http://www.siliconoasis.org/adverts/...memptypost.jpg

http://www.siliconoasis.org/adverts/...mPFenabled.jpg

Ted S 01-31-2012 08:21 AM

Quote:

Originally Posted by Volvoholic (Post 2294516)
Still getting the "this is an empty post" problem.

I have enabled the PF feature in that forum. Its is a forum not category.

I am using VB 4.1.7 and PF 1.2.2

So it's not an issue with the thread but rather the forumdisplay.

I don't recall the threads getting auto previews by default. Is this via a mod or setting?

Killhunter 01-31-2012 01:22 PM

Quote:

Originally Posted by Ted S (Post 2294472)
0 is not a valid setting but vBulletin does not let the admin panel enforce this in the field. There must be a review to post a review. :up:

Yes of course, but you know, i dont have this WYSIWYG Editor.. so how can i make the newest version running on my site? The only solution for me at the moment is, to take the oldest version of your addon... :(

Volvoholic 01-31-2012 01:51 PM

Quote:

Originally Posted by Ted S (Post 2294520)
So it's not an issue with the thread but rather the forumdisplay.

I don't recall the threads getting auto previews by default. Is this via a mod or setting?

I don't understand what you mean by thread getting auto previews.

Ted S 01-31-2012 05:33 PM

Quote:

Originally Posted by Volvoholic (Post 2294594)
I don't understand what you mean by thread getting auto previews.

In your forum display it's showing the first words of the first post... Is this from a mod or a setting?

Ted S 01-31-2012 05:34 PM

Quote:

Originally Posted by Killhunter (Post 2294586)
Yes of course, but you know, i dont have this WYSIWYG Editor.. so how can i make the newest version running on my site? The only solution for me at the moment is, to take the oldest version of your addon... :(

Upgrade your forum to a stable version or you'll just have to get use to hacking mods to make them work.

fungku 02-01-2012 05:45 AM

Quote:

Originally Posted by Ted S (Post 2294490)
Hey PF users, it sounds like we've got two issues impacting a few -- but not all -- installs. To get these nailed down please reply back if you have either problem:

1. Issues with categories not deleting / not having names.

I have VB 4.1.10

When I try to create a category I get this briefly at the top of the page:
Warning: mysql_real_escape_string() [function.mysql-real-escape-string]: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) in [path]/admincp/productforums.php on line 973

Warning: mysql_real_escape_string() [function.mysql-real-escape-string]: A link to the server could not be established in [path]/admincp/productforums.php on line 973

Then it refreshes and I have a blank category.

Then if I try to delete the blank category it says "Category ID not specified"

Ted S 02-01-2012 06:39 AM

Quote:

Originally Posted by fungku (Post 2294870)
I have VB 4.1.10

When I try to create a category I get this briefly at the top of the page:

Please see https://vborg.vbsupport.ru/showpost....&postcount=560

Danai 02-01-2012 07:02 AM

Just installed it, thanks, I love it!

fungku 02-01-2012 07:23 AM

1 Attachment(s)
The error when I create a category is generated from here, at SET title:
PHP Code:

    // update the review
    
$db->query_write("
        INSERT INTO " 
TABLE_PREFIX "pf_category
        SET title = '"
mysql_real_escape_string($vbulletin->GPC['title']) ."', active = '"$vbulletin->GPC['active'] ."'
    "
); 

It is not setting the title but why, oh why? :(

Ok... ran the queries you wanted...

Ted S 02-01-2012 09:00 AM

Quote:

Originally Posted by fungku (Post 2294889)
Ok... ran the queries you wanted...

Thanks.

We'll investigate this tomorrow and release a patch once resolved.

Ted S 02-01-2012 09:02 AM

Is anyone still having issues with the minimum review length on a recent version of vBulletin? If so please share your version and WYSIWYG admin setting.

Ted S 02-01-2012 09:11 AM

1 Attachment(s)
Quote:

Originally Posted by fungku (Post 2294889)
The error when I create a category is generated from here, at SET title:
PHP Code:

    // update the review
    
$db->query_write("
        INSERT INTO " 
TABLE_PREFIX "pf_category
        SET title = '"
mysql_real_escape_string($vbulletin->GPC['title']) ."', active = '"$vbulletin->GPC['active'] ."'
    "
); 

It is not setting the title but why, oh why? :(

Ok... ran the queries you wanted...

Give this version of admincp/productforums.php a try.

It should fix the create category error and the delete bug but I haven't tested it yet.

fungku 02-01-2012 05:14 PM

1 Attachment(s)
Quote:

Originally Posted by Ted S (Post 2294911)
Give this version of admincp/productforums.php a try.

It should fix the create category error and the delete bug but I haven't tested it yet.

Thanks, the new version works in creating new categories.

I still can't delete the blank ones.
  • It now says "Review not found" when trying to delete a blank one.
  • When I try to delete a non-blank category it says "Review ID not specified."

(Should I just delete the blank ones in phpmyadmin?)

Ted S 02-01-2012 05:49 PM

Quote:

Originally Posted by fungku (Post 2295039)
Thanks, the new version works in creating new categories.

I still can't delete the blank ones.
  • It now says "Review not found" when trying to delete a blank one.
  • When I try to delete a non-blank category it says "Review ID not specified."
(Should I just delete the blank ones in phpmyadmin?)

Please delete the bad ones manually, we will release a patch for deleting properly created ones today.

fungku 02-02-2012 03:29 AM

Quote:

Warning: mysql_insert_id() [function.mysql-insert-id]: A link to the server could not be established in [path]/admincp/productforums.php on line 494
I get this when I create a product.

At least it is not blank and shows up, but I have a "$" in front of manufacturer.

Also, a 404 when I click the "Be the First to Write a Review" link.

Ted S 02-02-2012 05:01 AM

Quote:

Originally Posted by fungku (Post 2295248)
At least it is not blank and shows up, but I have a "$" in front of manufacturer.

As stated previously, this will be addressed in the next update.

You can of course edit the templates and phrases however you like...

Quote:

Originally Posted by fungku (Post 2295248)
Also, a 404 when I click the "Be the First to Write a Review" link.

Why is it a 404?

Ted S 02-02-2012 05:03 AM

Quote:

Originally Posted by fungku (Post 2295248)
I get this when I create a product.

Your mySQL server is killing the query. It's not a big deal however as that code simply redirects the mod to the new product.

fungku 02-02-2012 08:20 AM

Quote:

Originally Posted by Ted S (Post 2295263)
As stated previously, this will be addressed in the next update.

Thanks.

Quote:

Why is it a 404?
I'm still trying to figure that one out.

fungku 02-02-2012 08:47 AM

Quote:

Originally Posted by Ted S (Post 2295263)
Why is it a 404?

Sorry there are 2 files named productforums.php and I didn't upload the one for the home directory... It's late :erm: thought it was a duplicate :P

Noticed something else now. Nothing shows up when I click Product Review Forum Settings.
Code:

http://www.myforum.com/admincp/options.php?do=optionsdogroup=prodforums_set
It does work if I go through the drop down menu on the admincp settings->options

Either way I'm happy now I can do everything I need to do with it. Thanks for the good mod. I was looking for something like this either for other forum or wordpress.

Killhunter 02-02-2012 01:50 PM

Quote:

Originally Posted by Ted S (Post 2294908)
Is anyone still having issues with the minimum review length on a recent version of vBulletin? If so please share your version and WYSIWYG admin setting.

Could you please implement the feature that if I type 0 into the minimum review length the programm isnt checking the length?

fungku 02-02-2012 03:23 PM

1 Attachment(s)
I think they are supposed to be here.

(See attachments)

edit: the post was deleted, the guy must have found them.....

Ted S 02-02-2012 05:30 PM

Quote:

Originally Posted by Killhunter (Post 2295369)
Could you please implement the feature that if I type 0 into the minimum review length the programm isnt checking the length?

Code:

if(strlen($comments) < $vbulletin->options['prodforums_minreview']){ $errors .= "Your review comments must be at least ". $vbulletin->options['prodforums_minreview'] ." characters long.<br />"; } // must have rating picked

Ted S 02-02-2012 05:31 PM

Quote:

Originally Posted by fungku (Post 2295292)
Sorry there are 2 files named productforums.php and I didn't upload the one for the home directory... It's late :erm: thought it was a duplicate :P

Noticed something else now. Nothing shows up when I click Product Review Forum Settings.
Code:

http://www.myforum.com/admincp/options.php?do=optionsdogroup=prodforums_set
It does work if I go through the drop down menu on the admincp settings->options

Either way I'm happy now I can do everything I need to do with it. Thanks for the good mod. I was looking for something like this either for other forum or wordpress.

Have you re-uploaded the xml files since upgrading?

Ted S 02-03-2012 06:39 AM

Version 1.2.3 stable has been posted as a non-critical but certainly suggested bug fix.

Major Fixes / Changes
- Fixed category management [adding / deleting]
- Fixed database escaping for users without persistent connections
- Added the option to disable the WYSIWYG editor
- Changed prodforums_product_details to use a <div> for the product block rather than an <li>
- Removed the $ before the Manufacturer name in products

To upgrade upload the new xml file and php files. You may also want to update the XML files to update your Admin CP links.

Toorak Times 02-03-2012 03:08 PM

Hi Ted, done something wrong,.

Uploaded as per instructions and I dont have a cp, did I miss something?

Ted S 02-03-2012 06:32 PM

Quote:

Originally Posted by Toorak Times (Post 2295720)
Uploaded as per instructions and I dont have a cp, did I miss something?

What do you mean?

Toorak Times 02-04-2012 12:21 AM

I can't find the controls for the mod, other such mods put a tab in my control panel; I'm new at this so please bear with me.

Ted S 02-04-2012 03:55 AM

Quote:

Originally Posted by Toorak Times (Post 2295892)
I can't find the controls for the mod, other such mods put a tab in my control panel; I'm new at this so please bear with me.

Did you upload the xml file folder? If so there will be a section in your Admin Control panel.

Volvoholic 02-04-2012 10:03 AM

Hi TED,

I get this message when adding a product via productreview.php, I do not get the error via the ACP add product method. Happens with both v 1.2.2 and 1.2.3
Quote:

Fatal error: Call to undefined function print_stop_message() in /home/xxx/public_html/forum/productforums.php on line 846

Ted S 02-04-2012 10:34 AM

Quote:

Originally Posted by Volvoholic (Post 2296045)
Hi TED,

I get this message when adding a product via productreview.php, I do not get the error via the ACP add product method. Happens with both v 1.2.2 and 1.2.3

This is the wrong function clearly but only is being called when a duplicate product is found -- adding new valid items should not be impacted. We'll get a fix out in the next version but you can manually resolve it by changing line 846 to

Code:

if($product['productid']){ eval(standard_error(fetch_error('prodforums_admin_dup'))); }

Killhunter 02-04-2012 10:39 AM

Hi Ted S,

i went back to 1.2.2, but now I have that problem that new reviews have to be activated manually by an admin. Is there a fix?

Ricsca 02-04-2012 01:10 PM

Quote:

Originally Posted by Ted S (Post 2291782)
Ouch. Thanks for the feedback but calling parts of a free mod a failure is probably not the best way to win the [positive] attention of the author.

Image urls were used because we don't see most people creating products individually, it's simply not scalable to hand enter even just a hundred products. When you enter a url, you define the image and thus you define the height... browser forced resizing is not a solution. Still there's been enough demand for uploading so while I think it will take people down the wrong path, we added to the feature roadmap a few weeks back.

I never wanted to say that the product is a failure! I realize now that google translate has mistranslated what I meant.

I do not understand what I mean.

I think this is a good product but the images are often canceled by other spiti therefore not able to upload pictures on your server I think it's something not right.

y2ksw 02-04-2012 02:11 PM

Quote:

Originally Posted by Ricsca (Post 2296092)
I never wanted to say that the product is a failure! I realize now that google translate has mistranslated what I meant.

I do not understand what I mean.

I think this is a good product but the images are often canceled by other spiti therefore not able to upload pictures on your server I think it's something not right.

My friend here would like to have a feature which imports external images to his forums and while this is done, to resize also the images. ;)

I think this could be done simply by a cronjob at regular intervals, or just while saving ...

Volvoholic 02-04-2012 05:54 PM

Quote:

Originally Posted by Ted S (Post 2296053)
This is the wrong function clearly but only is being called when a duplicate product is found -- adding new valid items should not be impacted. We'll get a fix out in the next version but you can manually resolve it by changing line 846 to

Code:

if($product['productid']){ eval(standard_error(fetch_error('prodforums_admin_dup'))); }

Thank you that worked !

morrow 02-04-2012 06:12 PM

"Something went terribly wrong in creating your product. End of the line. Admin-1027a"

Received that when adding a new product.

Also, I think this would be so much better if users could also add products. There are products I'd love to ad but don't know enough about whereas some of my users might know everything about the product.

Ted S 02-04-2012 09:00 PM

Quote:

Originally Posted by y2ksw (Post 2296108)
My friend here would like to have a feature which imports external images to his forums and while this is done, to resize also the images. ;)

I think this could be done simply by a cronjob at regular intervals, or just while saving ...

It's something we're looking into. Of course with cross site support it becomes much more complex than developing the feature for just one install.

Of course doing this will open up a lot of flexibility in displaying images so it's really just a matter of making it work right.

Ted S 02-04-2012 09:01 PM

Quote:

Originally Posted by morrow (Post 2296172)
"Something went terribly wrong in creating your product. End of the line. Admin-1027a"

Received that when adding a new product.

Have you specified which forum new products should be created in? Does this forum allow posting [not a category]?

Quote:

Originally Posted by morrow (Post 2296172)
Also, I think this would be so much better if users could also add products. There are products I'd love to ad but don't know enough about whereas some of my users might know everything about the product.

They can.

morrow 02-04-2012 09:35 PM

Quote:

Originally Posted by Ted S (Post 2296233)
Have you specified which forum new products should be created in? Does this forum allow posting [not a category]?


They can.

I created a new forum just for this mod. Forum ID is 178. Within the "Product Review Forums - Core Settings" under "Review Thread Forum ID' i have "178".

When I edit the forum I don't see anything regarding the product so I figured there is nothing to adjust there. The new forum is a forum.

Ted S 02-04-2012 10:19 PM

Quote:

Originally Posted by morrow (Post 2296246)
I created a new forum just for this mod. Forum ID is 178. Within the "Product Review Forums - Core Settings" under "Review Thread Forum ID' i have "178".

When I edit the forum I don't see anything regarding the product so I figured there is nothing to adjust there. The new forum is a forum.

As stated in the main mod post and the install guide there is an option in the forum settings to enable this mod.

It should be the last one on the page.

That said, it shouldn't have any issues causing this error. Does the forum allow posting [not permissions but core settings]? If so, try rebuilding the forum cache.


All times are GMT. The time now is 09:34 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02242 seconds
  • Memory Usage 1,865KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_code_printable
  • (2)bbcode_php_printable
  • (33)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete