vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Add-On Releases - CES Site News (https://vborg.vbsupport.ru/showthread.php?t=137365)

thincom2000 03-26-2007 11:23 AM

Quote:

Originally Posted by TheMilkCarton (Post 1212477)
One huge problem though.. :) It doesn't obey the default order I had set in the Forum Manager. I set all threads to sort by title, and this does it by date.

Will it be easy to add default sorting options back in? :)

This has been intended functionality since v1.0.0. You may have noticed that the Forum Search menus have also been removed from News(forum)display. The mentality behind this was that the Forum Search options added about 3 queries to the page (although looking back on it now this may just be sticky threads that do this - and you can't sticky the news anyway -> that's what announcements are for!), and developing it we felt that news was a much more "chronologically" dependent.

If this feature is that important to you, I will consider adding it back to version 1.3.0 later this week, with a little coding trick so that it skips the queries if we are sorting chronologically and as much as possible in other cases.

TheMilkCarton 03-26-2007 04:24 PM

OK, it works now. However, if the article is under the word limit it still displays "... Read more..." Is this normal?

Also, while in Newsdisplay, I notice that there is the typical icon legend at the bottom, but the icons don't actually show up anywhere in the articles.... I may have inadvertently deleted this from the template.. but I'll have to look into that.

I've also been trying to find where in the templates you were compensating for the display problems in other forums.. but I still can't find where you've moved the news postbit and the comment postbit 10px or so over to the right. I'll just have to search through the code more, unless you happen to know offhand where it is. :)

About the article sort order, it is kind of important.. as not all of my articles are News based, and need to be in alphabetical order... Won't it be easy to add a On/Off in the CES Site News options saying something like "Obey Default Sort Field and Default Sort Order?" That way if it's set to no it just defaults to chronological and saves on queries? Not sure how easy that would be though. :)

thincom2000 03-26-2007 06:15 PM

Quote:

Originally Posted by TheMilkCarton (Post 1212817)
OK, it works now. However, if the article is under the word limit it still displays "... Read more..." Is this normal?

This should not be happening, but quickly thinking it over I know where the problem lies. I will fix this for v1.3.0.

Quote:

Originally Posted by TheMilkCarton (Post 1212817)
while in Newsdisplay, I notice that there is the typical icon legend at the bottom, but the icons don't actually show up anywhere in the articles....

You did not delete anything from the templates. The icons will be fixed in v1.3.0.

Quote:

Originally Posted by TheMilkCarton (Post 1212817)
I've also been trying to find where in the templates you were compensating for the display problems in other forums.. but I still can't find where you've moved the news postbit and the comment postbit 10px or so over to the right.

Check your templates spacer_open and spacer_close. Also check the Main Table Width and Spacer Size in your CSS definitions.

Quote:

Originally Posted by TheMilkCarton (Post 1212817)
About the article sort order, it is kind of important.. as not all of my articles are News based, and need to be in alphabetical order...

I was able to bring the sort orders back without bringing back the queries I removed with some tricky JOINs. Looking at it now, I don't know why vBulletin has those extra queries in forumdisplay.

Sort order and the ability to search a news forum from Newsdisplay will appear in v1.3.0.

TheMilkCarton 03-26-2007 06:26 PM

Nice job. :)

I've gone over the template a million times and I've gotten rid of the spacers, moved them around and the news and comment postbits still jut off 10px to the right.

I have a table width of 800px, spacer of 10px, and everything is fine in my normal postbit in showthread, but in shownews there is 20px padding on the left and 10 px padding on the right. This causes the postbit to actually come off the page by 10px on the right side.

I'm going to try comparing source code between shownews and showthread and see where that goes.

Can't wait for 1.3.0 :D

Edit: Comparing the source code, I first noticed that this somehow breaks my RSS feed for my News forum... Clicking RSS up in the URL bar leads me to a blank page if I'm in a forum with your hack, but it works normally in the others. It might not break the feed per-se, but something's not right.

salami1_1 03-26-2007 06:32 PM

Hi,

I got your plugin working at:
http://www.samsunguniverse.com/forum/news.php?f=6

but I really would like to have blog like news included on:
http://www.samsunguniverse.com/index.php
under 'Samsung news' and then not in vbb style. But I still want the messages there also to appear in the forum as it does now.

Is there anyway to do this? I know some php code but divinginto vbb codes.
Thanks for the help!

Steve

thincom2000 03-26-2007 06:39 PM

Quote:

Originally Posted by TheMilkCarton (Post 1212915)
I have a table width of 800px, spacer of 10px, and everything is fine in my normal postbit in showthread, but in shownews there is 20px padding on the left and 10 px padding on the right. This causes the postbit to actually come off the page by 10px on the right side.

I'm going to try comparing source code between shownews and showthread and see where that goes.

There is nothing in the source code that would do that. It seems that there is still a $spacer_open somewhere and no $spacer_close. I will look into this.

Quote:

Originally Posted by TheMilkCarton (Post 1212915)
this somehow breaks my RSS feed for my News forum... Clicking RSS up in the URL bar leads me to a blank page if I'm in a forum with your hack, but it works normally in the others. It might not break the feed per-se, but something's not right.

This issue has come up before. You need to rename news.php to something else. Then set the new filename in the AdminCP (this problem is why the setting was created) and everything should work fine.

TheMilkCarton 03-26-2007 06:43 PM

I already did that though... because I didn't want it named news.php or shownews.php. I wasn't aware this was to fix RSS.

How ironic. I'm going to disable this plugin and see if I still have the problem.

Quote:

There is nothing in the source code that would do that. It seems that there is still a $spacer_open somewhere and no $spacer_close. I will look into this.
I meant that comparing source codes would help me figure out what was missing in the templates. :)


Edit: It just acts very strangely when I have the forums turned off. :) However, in news and shownews.php I don't get a dropdown box like I should when clicking on the RSS button. It takes me to the same RSS feed I would get if I clicked on the RSS button the main forums. In shownews and news.php it should be giving me a dropdown to select the RSS feed for that specific forum. I'm not really worried about this though... I'm not even sure I'm going to keep RSS enabled anyway :)

thincom2000 03-26-2007 07:03 PM

Quote:

Originally Posted by salami1_1 (Post 1212920)
I really would like to have blog like news included on:
http://www.samsunguniverse.com/index.php
under 'Samsung news' and then not in vbb style. But I still want the messages there also to appear in the forum as it does now.

Is there anyway to do this? I know some php code but divinginto vbb codes.

There is actually a way built into news.php to do something similar to this. First, you would have to make your own template so that it looks the way you want. Let's call it news_threadbit_main. You might have newsdisplay_main also (but this might take you some time).

In your .htaccess file, add new rewrite rule. If the rewrite engine is not yet on just say "RewriteEngine On"

In this case, your new rule would be:
Code:

RewriteRule ^index.php$ news.php?do=main&f={FORUMID} [L,QSA]
Create a plugin at cache_templates:
PHP Code:

if ((THIS_SCRIPT == 'newsdisplay') AND (MAINNEWS == true))
{
    
$globaltemplates[] = 'news_threadbit_main';
    
$globaltemplates[] = 'newsdisplay_main';


Create a plugin at global_start:
PHP Code:

if ((THIS_SCRIPT == 'newsdisplay') AND (MAINNEWS == true))
{
    
$vbulletin->templatecache['news_threadbit'] = $vbulletin->templatecache['news_threadbit_main'];
    
$vbulletin->templatecache['NEWSDISPLAY'] = $vbulletin->templatecache['newsdisplay_main'];


Hope that helps!

TheMilkCarton 03-26-2007 09:29 PM

I almost got everything sorted out.... I keep adding spacer_open and spacer_close everywhere and shownews is almost looking right now. Whenever there are no comments, the "No Comments" box stretches to 100% width though, so now I need to figure out where to put more spacer_open and closes.

I think I read somewhere in this thread where someone was having problems, so you "fixed" the spacer stuff in your next release.. Well I definitely think that person had something wrong with their board, since I haven't touched my spacer templates, and maybe you should look into fixing it back the way you had it.. Just a suggestion though. :)

Edit: I had to add another spacer into the news_comments template so that articles with no comments would show correctly.

I also had to completely comment out the "Forum Description" type stuff in my navbar. It was really acting up with forums that had descriptions in news and shownews.

I also noticed a bunch of extra whitespace at the bottom of the popup when you click on the poster's name... sure it's easy for me to fix in the template though. :)

thincom2000 03-26-2007 10:03 PM

Quote:

Originally Posted by TheMilkCarton (Post 1212933)
However, in news and shownews.php I don't get a dropdown box like I should when clicking on the RSS button. It takes me to the same RSS feed I would get if I clicked on the RSS button the main forums. In shownews and news.php it should be giving me a dropdown to select the RSS feed for that specific forum. I'm not really worried about this though...

I'm unfamiliar with the "RSS button" of which you speak. Is this another hack, or vBulletin's stock RSS Feeds feature?

Also, you mentioned Main Table Width is 800. What is your Form Width?

Quote:

Originally Posted by TheMilkCarton (Post 1213109)
I also had to completely comment out the "Forum Description" type stuff in my navbar. It was really acting up with forums that had descriptions in news and shownews.

If you're not ready to post a link, maybe a screen shot? I would like to look into this since it makes absolutely no sense.


All times are GMT. The time now is 02:01 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01396 seconds
  • Memory Usage 1,793KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (2)bbcode_php_printable
  • (11)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete