vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - Product Review Forums ? Research, Review & Compare Items (https://vborg.vbsupport.ru/showthread.php?t=269808)

marccap 03-09-2013 03:15 AM

I notice the reviews are in reverse alphabetical order - I cant see any settings to amend that so any clues how to change it?

Ted S 03-09-2013 04:31 AM

Quote:

Originally Posted by marccap (Post 2408943)
I notice the reviews are in reverse alphabetical order - I cant see any settings to amend that so any clues how to change it?

The ordering is coded into productforums.php

Quote:

ORDER BY title ASC
ASC is in order (a-z, 1-9)
DESC is reverse (z-a, 9-1)

CoZmicShReddeR 03-09-2013 01:51 PM

Ug I just updated this and it wiped all my style edits... :(

Is there anything in the future to make the style match the theme automatically or a least give the choice??

Ted S 03-09-2013 06:53 PM

Quote:

Originally Posted by CoZmicShReddeR (Post 2409005)
Ug I just updated this and it wiped all my style edits... :(

Is there anything in the future to make the style match the theme automatically or a least give the choice??

That stinks.

The templates in this addon work in the same way all vBulletin addon templates work... There is no "skip logical upgrade" option for developers that we checked. No "force override and piss people off" box either. :D

In theory the system [i.e. vBulletin core] tracks changed done through the template editor and prompts a revision when needed but in practice that tool is far from perfect. It certainly should never change a template that is not updated in our core and few have been in the last year.

Action-N 03-09-2013 07:57 PM

Not sure what Cozmic meant, but I've been working on setting this mod up myself an have an issue I think he meant. This mod has it's own css stylesheet for the productforum.php an doesn't use the default forums layout. For example your tables are squared with a black border, an I see even the forum overall width changes. On mine the search box is bunching up at a fixed 1024px forum so they must not be percentage based with nowrap. I broke the add product button some how so turned off user add products , but on the listing page the links still visible, although it does link to a feature disabled error. So if he had to fix those issues an updated an it reset them I can see what he meant. Basically I'll have to rewrite the templates for that page to use the forums default tables an not your custom ones. I see alot of mods doing that an sucks having to fix them all. I guess you can say the mod authors are reinventing the wheel with their layouts.

A couple more quick updates needed is on your own screenshot of the threaded reviews the forum header still has "Replies/ Views" shown, simple edit I'm sure. An the little green subscribe icon is pushed to the bottom of the table. I ended up deleting that stuff from my template, but you should consider fixing that or option to disable them.

I think your mod has great potential, however it was a pia getting it set up and learning to add products. The having to manually add the thumbnail pictures sucks, I have to open my ftp program an look for the images created last to guess which ones to use, was no id to know which images go to what product. Maybe have it use a product id number to atleast.

Ted S 03-09-2013 09:34 PM

Thanks for the comments Action-N... lengthy reply below (sorry).

Quote:

Originally Posted by Action-N (Post 2409063)
I guess you can say the mod authors are reinventing the wheel with their layouts.

Pretty much although it's rarely for the sake of doing so versus just being efficient. It's simply easier to build new than try and figure out what vB element would apply, much less explain to people how to customize it without changing the entire forum when the questions come in.

We make mods to bring functionality to sites and try to apply some best practices to go along with it [like being able to edit our mod's style without breaking your entire forum as we've seen others do]. While we keep to vB's squares and tables the layout their anything but modern nor is there a container to handle product type elements so you're dead on, we broke the box.

Certainly we could have made it all stock elements but we made a conscious decision on where to spend our time. If that results in a deal breaker that's great feedback but not likely to change.

Quote:

I ended up deleting that stuff from my template, but you should consider fixing that or option to disable them.
Thanks, we'll take a look for sure. Obviously fixing quirks and making logical decisions to the design is high on goal list but really we want to encourage sites to customize beyond the box especially where it's not possible for us to make a change without a code hack (like the column header for a forum).

It doesn't sound like this applies to you but most forums get sucked in to sticking to how things run by default and then wonder why their conversion rate, retention, revenue, or other KPIs are so bad. The web has too many options, too many great sites to be cookie-cutter.

Quote:

The having to manually add the thumbnail pictures sucks
We added an image uploader and bulk importer almost a year ago. Both autocreate thumbnails as long as have [to your first point] the template calls to get them.

Quote:

and learning to add products
Not sure what the problem is here but all for feedback?

Action-N 03-10-2013 05:41 AM

I'm not sure we are talking about the same thing, what I was afraid of. I mean the point of style sheets on a website is so user wants to change his category color he edits one variable an it changes all his pages to new color. What addon authors do is make their own style sheets so if I want to change my category color I do it for vbulletin then sort through my addons an change thier css variables. Just would make sense to me if mod makers shared the default vb's css variables. An for your addon you have your css as a file still (productforums.css)? Since I've already had to edit my vbtube mod I have the code saved, looks simpler to me:

Code:

<div class="block pfblock">
    <h2 class="blockhead">Heading Text</h2>
    <div class="blockbody">
        <div class="blockrow pftext">
                        Block Content
        </div>
    </div>
</div>

the pfblock and pftext would be your mods personal css variables. I understand your set in not using the stock elements, but it's your personal taste your hardcoding in the style. What I said I broke was the add product button doesn't show up anymore.


Yeah the sticky icon was easier to delete the code than figure out why it was on the bottom of the table. An I figured it being a special review only forum I didn't need the clutter.

Yes about cookie cutter websites, that's why the more variable you give them to turn on or off the better chance for them to be different. I don't want to spend hours customizing templates, checkboxs are much faster.

What I'm referring to is with adding product images I think from the forum I added one image link, then did the sync external images an that is where it makes them but didn't add the new images to the products for me. Haven't tried uploading from my computer yet. If it does yay, but fyi sync didn't.

I spent a few hours this morning trying to learn the addon an get products added an setup correctly. The product title can't handle quotes so it kept cutting my title short. So anyone wanting to review something described with inches has to spell out "inch".

Not trying to bust on your addon, like I said this is nice one to have, just trying to give feedback good and bad. Can I assume you being active on here that you are still working on the mod? Thanks for the effort with this, I wanted to make something an I couldn't even figure out how to start an addon.

One more thing, what's the deal with having to disable template comments? I want to edit the templates in this mod an need them to know what 's what?

Ted S 03-10-2013 10:16 AM

Quote:

Originally Posted by Action-N (Post 2409111)
I'm not sure we are talking about the same thing, what I was afraid of. I mean the point of style sheets on a website is so user wants to change his category color he edits one variable an it changes all his pages to new color.

We're talking about the same thing.

Quote:

Yes about cookie cutter websites, that's why the more variable you give them to turn on or off the better chance for them to be different. I don't want to spend hours customizing templates, checkboxs are much faster.
Fair enough although a checkbox is not the customization level I was implying... Ideally I think sites should really reach in beyond the options others determine they should have. Options are always limited by the ideas of their creator and more of them just adds to the load on the server.

Quote:

Haven't tried uploading from my computer yet. If it does yay, but fyi sync didn't.
Sync and upload work in the exact same way through the same process which first resizes a photo and then posts it to the product. If it's not sticking odds are the product didn't get a match and a new one, with the photo, was created.

Quote:

The product title can't handle quotes so it kept cutting my title short. So anyone wanting to review something described with inches has to spell out "inch".
Easy enough. Is it removing quotes or stopping the title entirely when they're entered?

Quote:

Can I assume you being active on here that you are still working on the mod? Thanks for the effort with this, I wanted to make something an I couldn't even figure out how to start an addon.
Of course. Our primary interest right now is monitoring and responding to any problems that may arise, including things like the icon you mentioned.

As for new features it's entirely demand driven. We combine community feedback with our own sense of what will help move the needle to push forward if there is interest for more. This mod has been pretty slow for the past few months so no plans for anything major yet.

Quote:

One more thing, what's the deal with having to disable template comments? I want to edit the templates in this mod an need them to know what 's what?
It's a quirk [or a bug depending on how you see it] in how vBulletin makes posts. When we fake a thread for a review it runs through the default vB post manager which brings in everything in the post template. For some reason this does not filter out comments and they will appear if the feature is not disabled.

Since it's a load constraint most sites we've worked with already have it off except during debugging.

flash84 03-12-2013 10:12 AM

Awesome mod! I just have one little issue, same as the user I quoted below. When you click to read a review it is using showthread.php which takes you to the top of the product thread. Is there anyway you can get it to use showpost.php to take you to the actual review post?

I have the "Create New Thread on Review" option turned off, so the reviews are posts all in one single thread.

Thanks so much if you can help me!

Quote:

Originally Posted by deverill2010

I noticed when you click through to reviews from productforums.php it doesn't actually take you to the specific review but instead the start of the thread.

Having the reviews pinned to the front would be handy to save users having to trawl through posts in between reviews.

sadiq6210 03-12-2013 11:30 AM

Q: What will happen to the threads if I uninstall it?

+

I try to uninstall the mod but I got this error

Database error in vBulletin 4.1.12:

Invalid SQL:
DELETE FROM activitystreamtype WHERE section = 'product' AND type = 'review';

MySQL Error : Table 'dbname_testforum2.activitystreamtype' doesn't exist
Error Number : 1146
Request Date : Tuesday, March 12th 2013 @ 02:25:48 PM
Error Date : Tuesday, March 12th 2013 @ 02:25:48 PM
Script : http://www.domain.com/vbtest/admincp...do=productkill
Referrer : http://www.domain.com/vbtest/admincp...duct_forums&s=
IP Address :
Username : sadiq6210
Classname : vB_Database
MySQL Version : 5.1.68-cll

_________________________________________

In 4.1.12 there is no activity stream

I will use it soon but I want to test it first and have all information about it.
Thank you for the great mod


All times are GMT. The time now is 09:46 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02721 seconds
  • Memory Usage 1,794KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (14)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete