vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Major Additions - GRPS: Groups Commune 2.0.x (https://vborg.vbsupport.ru/showthread.php?t=127303)

Merriweather 03-06-2007 02:36 PM

Quote:

Originally Posted by sabret00the (Post 1196934)
can i get a screenshot of this one please?

I PMed you the screenshot. :)

Merriweather 03-06-2007 02:42 PM

Quote:

Originally Posted by sabret00the (Post 1196948)
can you please run this query with the same values for which you used XX and YY on the test_viewthread.php please

[sql] SELECT grps_post.postid, grps_post.groupid, grps_post.username AS postusername, grps_post.ipaddress AS ip, grps_post.title AS posttitle, grps_post.dateline, grps_post.pagetext, grps_post.iconid, i.title AS icontitle, i.iconpath, grps_post.visible, grps_post.allowsmilie, grps_post.showsignature, grps_post.edit_username, grps_post.edit_userid, grps_post.edit_reason, grps_post.edit_dateline, grps_post.delete_username, grps_post.delete_userid, grps_post.delete_reason, grps.leaderid, u.*, uf.*, utf.*, a.avatarid, a.avatarpath, NOT ISNULL(ca.userid) AS hascustomavatar, ca.dateline AS avatardateline, ca.width AS avwidth, ca.height AS avheight
FROM grps_post
LEFT JOIN grps ON (grps.groupid = grps_post.groupid)
LEFT JOIN user u ON (u.userid = grps_post.userid)
LEFT JOIN userfield uf ON (uf.userid = u.userid)
LEFT JOIN usertextfield utf ON (utf.userid = u.userid)
LEFT JOIN icon i ON (i.iconid = grps_post.iconid) > 0
LEFT JOIN avatar a ON (a.avatarid = u.avatarid)
LEFT JOIN customavatar ca ON (ca.userid = u.userid)
WHERE grps_post.groupid = XX and grps_post.threadid = YY
ORDER BY grps_post.dateline ASC
[/sql]

and please just look for the iconpath column and let me know if it's empty on all counts.

hold on, i think i've figured it out. are you using a default icon on your forums?

I am using a default icon. But even if a different icon is selected, it doesn't show.

The results are 0 for all iconids, null for all icontitles and paths. Posttitle is NOT blank for some, but the title doesn't show on the posts.

sabret00the 03-06-2007 03:35 PM

Quote:

Originally Posted by Merriweather (Post 1197186)
I am using a default icon. But even if a different icon is selected, it doesn't show.

The results are 0 for all iconids, null for all icontitles and paths. Posttitle is NOT blank for some, but the title doesn't show on the posts.

can you please go to your Admin CP => vBulletin Options => Thread Display Options

and check your default post icon path please.

sabret00the 03-06-2007 03:37 PM

Quote:

Originally Posted by sabret00the (Post 1196940)
can i get a screenshot of that because i'm unable to replicate that.

confirmed, it's a problem with the WYSIWYG editor. being worked on now.

Merriweather 03-06-2007 04:28 PM

Quote:

Originally Posted by sabret00the (Post 1197246)
can you please go to your Admin CP => vBulletin Options => Thread Display Options

and check your default post icon path please.

Adding my full URL there fixed the default (YAY!) but there is still the issue that if you choose a different icon, or enter a title, they don't show. :)

sabret00the 03-06-2007 11:00 PM

Quote:

Originally Posted by Merriweather (Post 1197300)
Adding my full URL there fixed the default (YAY!) but there is still the issue that if you choose a different icon, or enter a title, they don't show. :)

enter a title?

Merriweather 03-07-2007 12:39 AM

Quote:

Originally Posted by sabret00the (Post 1197573)
enter a title?

Yes, when you post, you can enter a post title and your message. If you enter a title, it is supposed to show next to the post icon. Neither the selected post icon (if you select one) nor the post title (if you enter one) ever show. It only shows the default post icon. It's saving the titles, because I can see them in the DB, but they aren't displayed. I'm not sure about the post icons.

Merriweather 03-07-2007 02:36 AM

Other issues my users have reported:

(1) If a user has no avatar, it shows a red X or missing image placeholder for the user. It should not show anything, or at least some default "missing avatar" placeholder.

(2) When you post to a thread, the page refreshes to the start of page one, instead of where you just posted. So if you post to page five, it bounces you back to page one, and you have to click and scroll to get back where you left off.

(3) The [View My Last Reply] [View New Posts] [View Last Reply] links just take you to the start of the thread.

My own issue is that the system does not seem to check a user's permissions, only if they are a member. So when I had a member join a group, then get changed to a usergroup without group joining privileges, she could still see and post to the group because she was still a member. If the system could check the user against their usergroup permissions to make sure that they have permissions to access the groups, whether or not they are a member or leader of a group would be great. Perhaps a cron job to remove users from groups once their permissions change, even.

Merriweather 03-07-2007 03:02 AM

I've made some progress figuring out this maddening DB error on replying to posts as well as why it takes you to the start of the post and not where you left off. :)

If I click to reply on certain group threads, the HTML source looks like this:

Code:

<input type="hidden" name="s" value="" />
                <input type="hidden" name="do" value="postreply" />
                <input type="hidden" name="t" value="0" />
                <input type="hidden" name="p" value="" />
                <input type="hidden" name="posthash" value="" />
                <input type="hidden" name="poststarttime" value="" />
                <input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
                <input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

Obviously, the topicid and postid are missing.

On the ones that work, the source is like this:

Code:

<input type="hidden" name="s" value="" />
                <input type="hidden" name="do" value="postreply" />
                <input type="hidden" name="t" value="47" />
                <input type="hidden" name="p" value="" />
                <input type="hidden" name="posthash" value="" />
                <input type="hidden" name="poststarttime" value="" />
                <input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
                <input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

The topicid is there, though the postid is not. This is why I can reply to the post, but it takes me to the start of the thread, and not the post I made, after I submit.

Interestingly, on threads that have no topicid when replying, you CAN quote them -- the topicid gets pulled there. So perhaps an investigation of the code to see what the difference is in pulling the topicid for the quote vs. the new reply will help you solve this?

I will let you know if I figure out any more. :)

Merriweather 03-07-2007 03:07 AM

Another bug -- I deleted a post from a thread, but it still shows the thread as having a reply, which it no longer does. The info block on the right, however, that says "Posts in this Thread" has the correct count.


All times are GMT. The time now is 10:05 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02472 seconds
  • Memory Usage 1,758KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (7)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (5)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete