vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Show Thread Enhancements - OS/Browser Display in Postbits (https://vborg.vbsupport.ru/showthread.php?t=280899)

EliasAlucard 05-10-2012 01:59 PM

Quote:

Originally Posted by nhawk (Post 2327993)
I would prefer you didn't.

And I feel it's as complicated as it needs to be for what it does. If you disagree with that, use PMs and we'll discuss it.

Also, the system does identify Ubuntu, etc.

Well, if we may not come to agreement, I may just install it and use my own modification of it on my forum. I'm using vB3.8.7 now though, so I'm not using your plugin.

You've done a good job in adding more browser and OS support, but it's still quite incomplete (hey, I don't blame ya, I've learned myself that this takes quite some time).

We can take it here rather than PM. For one, I don't understand why you've grouped together Windows 7 and Server 2008 R2? They are clearly distinguishable by user agent string (6.1 and 6.0) and so it's possible to separate them in the postbit information. You also don't have a specific icon for Windows 7; you're using the Vista icon.

Personally, I think the icons should be sized at least 20 on the height and 24 as a max.

I wouldn't really need to modify your plugin though. I guess all I need is to add browser/OS version support for Fighter1405's old vB3.8 plugin, in the alt text. Do I need $tmp_array, $useragent and $client_data for that?

nhawk 05-10-2012 02:06 PM

Windows 7 and Vista do have the same logo from Microsoft. They never changed it.

So far as icon size, they are sized at 19. But if you like 20, I can't please everyone. ;)

I can't help with Fighter1405's plugin since I've never seen it and I don't know a thing about it.

datoneer 05-10-2012 02:16 PM

Installed and nominated

EliasAlucard 05-10-2012 02:16 PM

Quote:

Originally Posted by nhawk (Post 2328032)
Windows 7 and Vista do have the same logo from Microsoft. They never changed it.

So far as icon size, they are sized at 19. But if you like 20, I can't please everyone. ;)

I can't help with Fighter1405's plugin since I've never seen it and I don't know a thing about it.

Well, there are Windows 7 icons like this one:

http://www.pconline.se/wp-content/up...7/windows7.jpg

Here's Fighter's plugin:

https://vborg.vbsupport.ru/showthread.php?t=219687

nhawk 05-10-2012 02:22 PM

Quote:

Originally Posted by EliasAlucard (Post 2328034)
Well, there are Windows 7 icons like this one:

http://www.pconline.se/wp-content/up...7/windows7.jpg

Here's Fighter's plugin:

https://vborg.vbsupport.ru/showthread.php?t=219687

Well, the ones I user are the ones shown on most Microsoft packaging.

And if you didn't know it the Server 2008 version numbers are the same for Windows 7 and Vista.

Windows7/Server 2008 = 6.1
Vista/Server 2008 = 6.0

And the newest is Windows 8 = 6.2

I have no intention of using my time to decode someone else add-on. If you want to change it you are on your own.

EliasAlucard 05-10-2012 02:32 PM

Quote:

Originally Posted by nhawk (Post 2328037)
Well, the ones I user are the ones shown on most Microsoft packaging.

Yeah, but still, it would be like using a win2k icon for winxp if you know what I mean.

Quote:

Originally Posted by nhawk (Post 2328037)
And if you didn't know it the Server 2008 version numbers are the same for Windows 7 and Vista.

Windows7/Server 2008 = 6.1
Vista/Server 2008 = 6.0

And the newest is Windows 8 = 6.2

Yes, but most forum posters don't actually use Windows Server 2008 R2 so it's kind of redundant to even have that as the alt text.

Quote:

Originally Posted by nhawk (Post 2328037)
I have no intention of using my time to decode someone else add-on. If you want to change it you are on your own.

I can understand that. Looks like I'll be playing around with your plugin then :p

Also, you lack iOS icons and so on. I've currently done a good job with updating Fighter's plugin, but it's for vB3.8 only so I'm not sure if it's worth working any more on it.

nhawk 05-10-2012 02:41 PM

Quote:

Originally Posted by EliasAlucard (Post 2328043)
Also, you lack iOS icons and so on.


Quote:

1.0.6 - (May 10, 2012)
Add - iPhone/iPad iPhone OS
Hmmm :D

EliasAlucard 05-10-2012 03:21 PM

Quote:

Originally Posted by nhawk (Post 2328047)
Hmmm :D

That's good, although I've added icons for every Android version ;)

By the way, I was thinking... is it possible that you could add some statistics counter or something? In admincp or something that shows how many posts were made with this OS and that browser, something like that, would be nice.

Robru 05-10-2012 04:44 PM

Thank you for this update! :)

wally07 06-23-2012 08:57 PM

thanks for the update! :D


All times are GMT. The time now is 07:49 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01372 seconds
  • Memory Usage 1,743KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (9)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete