vb.org Archive
Page 14 of 21 « First 41213 14 1516 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Add-On Releases - Post Edit History (PEH) (https://vborg.vbsupport.ru/showthread.php?t=132708)

Gray Matter 08-13-2007 10:14 PM
This is a great hack, but the templates that go along with it have some slight design issues inside them and (in my opinion) are not visually appealing at all.

I have a few questions:
  1. Why does the username of the thread starter appear two times in the edit_history_view template? This is redundant. The second username should be the username of the post creator.
  2. What is the variable #$i? I cannot figure out what this is, as it is just displaying a useless number...
  3. What conditions must be met in order to show the compare link? I can't find any way to configure it.
  4. Why are there colspan="2" attributes on everything in the editbit template? These aren't necessary as there are only three columns in the table, and there are three columns in every row...
  5. What is the purpose of the CSS in the edit_history_view template?
and a few suggestions:
  1. Add a conditional so that if there is no post title, the "" won't display in the phrase "Edithistory of post "X" in thread "Y." This makes the text ridiculous by showing an unfilled set of quotation marks.
  2. When there is no title for the post, the "Post" row will just show a link that says "(Post)." This looks a little redundant, having "Post: (Post)." You should use a conditional to remove the parentheses when there is no post title, and also, I think, change the phrase text to "Show Post."
  3. The title row should not show when there are no titles to display. ;)
  4. The reason row should not show when there are no reasons to display.
  5. The edit time of the post should have a <span class="time"> on it, to keep with vB standards and also to set apart the time itself.
  6. Remove the closing </span> tag within the compare conditional. There is no opening tag for this so it shouldn't be there.
  7. Why is the phrase "cancle_compare" spelled "cancle?" The proper spelling is "cancel," unless there's some foreign version that I'm unaware of.
  8. The "message" text TD should have a valign="top" on it, since it looks a little out of place in the middle of a large post.
  9. The last two rows of the editbit table look really unorganized. You should try to configure them differently for a better-looking effect.
  10. Sometimes you write "Edit History," and other times as "Edithistory." Why the two versions? You should choose one (may I suggest "Edit History"). :p
  11. You have an ampersand that's not encoded in the link of the "Delete All Edits of This Post" link. ;)
Thanks for listening to me rant. Just some constructive criticism. :p

For anyone who's interested in applying the changes I suggested and removing the unnecessary stuff, I've attached my two templates and two screenshots (one for a post with a title and reason, and one for a post without them) as well. Feel free to use them (They are XHTML 1.0 valid, by the way). Keep in mind that if you use them, you must add two phrases: edithistory_of_post_in_thread_x (Text: Edit History of post in thread "{1}") and show_post (Text: Show Post). Enjoy. :)

BobbyBig 08-17-2007 09:50 PM
Thank you, installed this for our community Forum.
Please get the User Mass Restore Option implemented, it is required badly :)

Gute Arbeit.

regards

Pottsy 08-21-2007 12:33 PM
Help!! :)

I have uninstalled this product, but in my usergroup options there is a table left behind. No title, 7 blank Yes/No options, no description.

If I try to change any usergroup options, I get an error (below).

How can I remove PEH from my forum? I have tried installing again, then removing, but still the same. Pleeeeeease help!

Error:

Code:
Database error in vBulletin 3.6.8:

Invalid SQL:
UPDATE usergroup SET

### UPDATE QUERY GENERATED BY fetch_query_sql() ###
        `title` = 'Dealers',
        `description` = '',
        `usertitle` = 'Commercial user',
        `opentag` = '',
        `closetag` = '',
        `passwordexpires` = '0',
        `passwordhistory` = '0',
        `ispublicgroup` = '0',
        `canoverride` = '0',
        `mgccustomusergroupperms` = '0',
        `nbmsgshowchatbox` = '10',
        `allowhtmlpermissions` = '0',
        `edithistorypermissions` = '0',
        `vbwikiroles` = '',
        `vbwikipermissions` = '63',
        `forumpermissions` = '782591',
        `genericpermissions` = '505943751',
        `attachlimit` = '0',
        `pmquota` = '750',
        `pmpermissions` = '3',
        `pmsendmax` = '5',
        `calendarpermissions` = '63',
        `wolpermissions` = '1',
        `adminpermissions` = '0',
        `genericoptions` = '62',
        `profilepicmaxwidth` = '100',
        `profilepicmaxheight` = '100',
        `profilepicmaxsize` = '65535',
        `avatarmaxwidth` = '90',
        `avatarmaxheight` = '90',
        `avatarmaxsize` = '20000',
        `signaturepermissions` = '136703',
        `sigpicmaxwidth` = '1',
        `sigpicmaxheight` = '1',
        `sigpicmaxsize` = '1',
        `sigmaxrawchars` = '1000',
        `sigmaxchars` = '500',
        `sigmaxlines` = '5',
        `sigmaxsizebbcode` = '4',
        `sigmaximages` = '0'
WHERE usergroupid=10;

MySQL Error  : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054
Date        : Tuesday, August 21st 2007 @ 02:28:04 PM
Script      : http://www.mydomain.com/forum/admincp/usergroup.php?do=update
Referrer    : http://www.mydomain.com/forum/admincp/usergroup.php?do=edit&usergroupid=10
IP Address  : x.x.x.x
Username    : Pottsy
Classname    : vb_database

Pottsy 08-21-2007 01:04 PM
OK, panic over - I read this.

Surviver 08-25-2007 06:01 AM
Quote:
Originally Posted by Gray Matter (Post 1316905)
This is a great hack, but the templates that go along with it have some slight design issues inside them and (in my opinion) are not visually appealing at all.

I have a few questions:
  1. Why does the username of the thread starter appear two times in the edit_history_view template? This is redundant. The second username should be the username of the post creator.
  2. What is the variable #$i? I cannot figure out what this is, as it is just displaying a useless number...
  3. What conditions must be met in order to show the compare link? I can't find any way to configure it.
  4. Why are there colspan="2" attributes on everything in the editbit template? These aren't necessary as there are only three columns in the table, and there are three columns in every row...
  5. What is the purpose of the CSS in the edit_history_view template?
and a few suggestions:
  1. Add a conditional so that if there is no post title, the "" won't display in the phrase "Edithistory of post "X" in thread "Y." This makes the text ridiculous by showing an unfilled set of quotation marks.
  2. When there is no title for the post, the "Post" row will just show a link that says "(Post)." This looks a little redundant, having "Post: (Post)." You should use a conditional to remove the parentheses when there is no post title, and also, I think, change the phrase text to "Show Post."
  3. The title row should not show when there are no titles to display. ;)
  4. The reason row should not show when there are no reasons to display.
  5. The edit time of the post should have a <span class="time"> on it, to keep with vB standards and also to set apart the time itself.
  6. Remove the closing </span> tag within the compare conditional. There is no opening tag for this so it shouldn't be there.
  7. Why is the phrase "cancle_compare" spelled "cancle?" The proper spelling is "cancel," unless there's some foreign version that I'm unaware of.
  8. The "message" text TD should have a valign="top" on it, since it looks a little out of place in the middle of a large post.
  9. The last two rows of the editbit table look really unorganized. You should try to configure them differently for a better-looking effect.
  10. Sometimes you write "Edit History," and other times as "Edithistory." Why the two versions? You should choose one (may I suggest "Edit History"). :p
  11. You have an ampersand that's not encoded in the link of the "Delete All Edits of This Post" link. ;)
Thanks for listening to me rant. Just some constructive criticism. :p

For anyone who's interested in applying the changes I suggested and removing the unnecessary stuff, I've attached my two templates and two screenshots (one for a post with a title and reason, and one for a post without them) as well. Feel free to use them (They are XHTML 1.0 valid, by the way). Keep in mind that if you use them, you must add two phrases: edithistory_of_post_in_thread_x (Text: Edit History of post in thread "{1}") and show_post (Text: Show Post). Enjoy. :)


At first thank you for your post!

1.)That seems to be the bug - once it should be the threadstarter and the other should be the postauthor!
2.)Where did you finde it?
3.)You have to set the usergroup permissions. If this does not work, check if the templates are ok.
4.)You're right
5.)This is the CSS for comparing the edits

1.)Noticed for future Versions
2.)Noticed for future Versions
3.)Noticed for future Versions
4.)Noticed for future Versions
5.)Noticed for future Versions
6.)Noticed for future Versions
7.)This happens if i write very fast :D Maybe i will change this ;)
8.)Noticed for future Versions
9.)The Problem is i'm not a designer :D I will try to find a better solution :)
10.)hehe, ok i will use "Edut History" in future :)
11.)Noticed for future Versions


Thank you for your particural suggestions!
That's nice feedback :)

Greetings Surviver

edgecutioner 10-16-2007 12:25 PM
Quote:
Originally Posted by SDB (Post 1277803)
Right.

THis is urgent.

I now have a problem, as this install script didn't fully run, and I now can't make changes to my usergroups as it throws up a db error :

Code:
MySQL Error  : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054
whenever I try to update the usergroup.

Please help asap - first of all to remove this problem.
Quote:
Originally Posted by Surviver (Post 1315700)
Yes, ist works with 3.6.8

If the System is enabled and you have the permissions to view and the templateedits are done - in postbit/_legacy
It has bugs when you uninstall it namely the quote posted post above

Quote:
Originally Posted by Pottsy (Post 1322308)
Help!! :)

I have uninstalled this product, but in my usergroup options there is a table left behind. No title, 7 blank Yes/No options, no description.

If I try to change any usergroup options, I get an error (below).

How can I remove PEH from my forum? I have tried installing again, then removing, but still the same. Pleeeeeease help!

Error:

Code:
Database error in vBulletin 3.6.8:

Invalid SQL:
UPDATE usergroup SET

### UPDATE QUERY GENERATED BY fetch_query_sql() ###
    `title` = 'Dealers',
    `description` = '',
    `usertitle` = 'Commercial user',
    `opentag` = '',
    `closetag` = '',
    `passwordexpires` = '0',
    `passwordhistory` = '0',
    `ispublicgroup` = '0',
    `canoverride` = '0',
    `mgccustomusergroupperms` = '0',
    `nbmsgshowchatbox` = '10',
    `allowhtmlpermissions` = '0',
    `edithistorypermissions` = '0',
    `vbwikiroles` = '',
    `vbwikipermissions` = '63',
    `forumpermissions` = '782591',
    `genericpermissions` = '505943751',
    `attachlimit` = '0',
    `pmquota` = '750',
    `pmpermissions` = '3',
    `pmsendmax` = '5',
    `calendarpermissions` = '63',
    `wolpermissions` = '1',
    `adminpermissions` = '0',
    `genericoptions` = '62',
    `profilepicmaxwidth` = '100',
    `profilepicmaxheight` = '100',
    `profilepicmaxsize` = '65535',
    `avatarmaxwidth` = '90',
    `avatarmaxheight` = '90',
    `avatarmaxsize` = '20000',
    `signaturepermissions` = '136703',
    `sigpicmaxwidth` = '1',
    `sigpicmaxheight` = '1',
    `sigpicmaxsize` = '1',
    `sigmaxrawchars` = '1000',
    `sigmaxchars` = '500',
    `sigmaxlines` = '5',
    `sigmaxsizebbcode` = '4',
    `sigmaximages` = '0'
WHERE usergroupid=10;

MySQL Error  : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054
Date        : Tuesday, August 21st 2007 @ 02:28:04 PM
Script      : http://www.mydomain.com/forum/admincp/usergroup.php?do=update
Referrer    : http://www.mydomain.com/forum/admincp/usergroup.php?do=edit&usergroupid=10
IP Address  : x.x.x.x
Username    : Pottsy
Classname    : vb_database
I get the same DB error. any suggestions?

Surviver 10-17-2007 07:04 PM
Quote:
I get the same DB error. any suggestions?
Just reaf the thread - but will be fixed in the next realease (will be released in the next days ;))

https://vborg.vbsupport.ru/showpost....&postcount=109

CDarklock 10-17-2007 07:56 PM
I installed this mod, made the template changes, edited a post... and, um, nothing. I can't seem to find any difference. There's no link to a change history. Is this mod working as expected with 3.6.8?

I also have some suggestions for enhancements, when time is available for such things... I'd like the history extended to deleted posts, so when you can see a deleted post slug you can click a link to see what was deleted and still have access to the full history, and also the ability to revert a deleted post to any selected historical copy of that post without damaging the history.

FleXy 10-17-2007 11:28 PM
thanks for this mod

1) can i administrate mass all history... purge all history from administrator panel?

2) will it drop all tables if i need uninstall?

thanks.

Surviver 10-21-2007 07:11 PM
*** Update ***


All times are GMT. The time now is 07:12 AM.
Page 14 of 21 « First 41213 14 1516 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01393 seconds
  • Memory Usage 1,795KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code_printable
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete