vb.org Archive - Major Additions - Product Review Forums ? Research, Review & Compare Items

And I had a question. Is there a way for the 'normal' threads within the product forum to show normally. I.e don't show the Rated: 0.0 / 5 & reviews column as this looks confusing and messy. They are normal threads not products so shouldn't be interefered with.

Mixing normal threads with review threads is just fine. Changing the forumdisplay however changes it for the entire forum... You can tweak the prodforums_threadbit template to adjust however you like.

The code you're looking at is:

Code:

<vb:if condition="!$show['notificationtype']">                    

        <ul class="threadstats td alt" title="<vb:if condition="$thread['dot_count'] > 0">{vb:rawphrase have_x_posts_in_thread_last_y, {vb:raw thread.dot_count}, {vb:raw thread.dot_lastpost}}</vb:if>">

        <li>{vb:rawphrase prodforums_rating,{vb:raw thread.pf_rating}}</li>

        <li>{vb:rawphrase prodforums_reviews,{vb:raw thread.pf_reviews}}</li>

        <li class="hidden">{vb:rawphrase rating}{vb:raw thread.rating} / 5</li>

        </ul>

</vb:if>

GCC LLC

08-31-2012 05:14 PM

Ok, next up.. lol. Sorry to make it seem like all I'm doing is pointing out problems - because overall this is an excellent product. We have an issue where a user submitted their own new product which we approved. That seemed to work fine. However, when the user (or anyone for that matter) go to leave a review of the product, we (including myself as an admin) get this error:

We had an issue posting your review, please try again or contact support and use code 164251-E.

That error, according to your code seems to relate to something having to do with not being able to add new posts to the thread (build_new_post() function not adding the post?). When I turn on debugging, the only additional info I get in the error is Array (not the contents of the array).

The thread appears to be open and able to be posted in, according to mysql:

mysql> select open from thread where threadid = xxxxxx;
+------+
| open |
+------+
| 1 |
+------+
1 row in set (0.00 sec)

mysql> select visible from thread where threadid = xxxxxx;
+---------+
| visible |
+---------+
| 1 |
+---------+
1 row in set (0.00 sec)

Ted S

08-31-2012 06:47 PM

Quote:

Originally Posted by GCC LLC (Post 2361519)

Not to worry. It's actually good to see people going to this detail to use the features. Unfortunately with endless combinations errors do come up so I appreciate your tolerance to working through them.

That message means vB was not able to build a reply. We can diagnose this further if open up productforums.php and go to around like 544

Replace eval(standard_error(fetch_error('prodforums_review _critdebug','164251-E',$errors))); with:

Code:

echo "debug code:<br>";

print_r($errors);

die;

Run a review on a user made product and you should see more detail but in short what it's saying is that it couldn't post the reply so likely a permission issue.

GCC LLC

08-31-2012 07:38 PM

Thanks, it was due to the length of the post title. The product itself had a long name, then when you added on the "x out of 5 rating for" plus the product name, it exceeded vB's length.

As a hack, I just edited the construction on newpost['title'] to make it much shorter.

GCC LLC

08-31-2012 07:41 PM

Quote:

Originally Posted by Ted S (Post 2361402)

Please try the attached version of upload/productforums.php which addresses the dup content issue [note: I couldn't duplicate it so this may take another shot or two].

For moderation I'm honestly stumped and unable to recreate it thus I'll have to unfortunately as for a little help on your part...

Next time a review gets stuck in the queue before you release it please check it's status in your SQL database:

SELECT visible FROM post WHERE postid = XXXX;

We'll keep going from there until it's all fixed.

The updated php seems to have fixed the duplicate content issue. The posts still go into moderation though. At least it's much easier to just go in and approve them from admincp now though. I know you're working hard on this so I just wanted to take the time to say thanks for your time and effort!

GCC LLC

08-31-2012 08:09 PM

Ok, moderation issue fixed. Just before your build_new_post() function is called, I added the following two lines:

$forumperms = fetch_permissions($foruminfo['forumid']);
$foruminfo['moderatenewthread'] = 0;

ashimashi

08-31-2012 08:25 PM

Quote:

Originally Posted by Ted S (Post 2361510)

If you don't know where your database tables are you probably shouldn't try and do this, until you learn some mySQL & php that is. :up:

Messing around with your system at this level risks your entire forum if you do the wrong thing. Not the kind of stuff we like to document as the easier it appears, the more likely people are to jump in without paying attention to the warning system.

Okay thanks still!

Well I don't think there would be a mistake if there was a step by step guide on what to do. Besides I always back up files before doing something like this.

thanks anyways

Ted S

08-31-2012 09:30 PM

Quote:

Originally Posted by GCC LLC (Post 2361548)

Awesome...

Now to find out how long is too long...

Ted S

08-31-2012 09:34 PM

Quote:

Originally Posted by ashimashi (Post 2361566)

Okay thanks still!

Well I don't think there would be a mistake if there was a step by step guide on what to do. Besides I always back up files before doing something like this.

thanks anyways

People should back that up every time they install a mod, but they don't. People should read the install guide for a mod, but they don't. And this isn't about your files, it's your entire forum's data is.

While I totally want to see people grow their sites and make that easy [hence all the free mods], I'm certain that this passes the "risk to reward" threshold. Sorry!

If you want to take your forum beyond a certain point you really have to either learn some code or hire someone who knows it. There's great resources for both here @ vB.org too

Ted S

08-31-2012 09:35 PM

Quote:

Originally Posted by GCC LLC (Post 2361558)

Dude, rock on. For some reason those were hardset the other way.... and yet not breaking things for most forums?

Did this fix the posts and threads?

All times are GMT. The time now is 04:54 AM.

Page 130 of 186

130

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.02076 seconds Memory Usage 1,757KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (7)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (5)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: