vb.org Archive - New Posting Features - Photo Popup - Insert pictures easily from vB Albums, Photopost, vBGallery, Photoplog

Page 13 of 61

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)

- - New Posting Features - Photo Popup - Insert pictures easily from vB Albums, Photopost, vBGallery, Photoplog (https://vborg.vbsupport.ru/showthread.php?t=202385)

Namaless

01-28-2009 10:46 AM

1 Attachment(s)

Good MOD, but please use full link example:

Code:

$vboptions[bburl]/popup.php

I found problem with vBAdvanced Dynamics because this MOD work into subfolder into vb root :)

Thanks.

MikesSite

01-29-2009 04:00 AM

IDK if this was mentioned but I found a bug in photo_popup.php.

Line 408 - $origimg = $vb_url."./picture.php?albumid=".$array['albumid']."&pictureid=".$array['pictureid']."";

Remove the red period before /picture.php? or else original images will not load.

cellarius

01-29-2009 04:43 AM

Quote:

Originally Posted by MikesSite (Post 1727797)

No, that's just plain wrong.

The line 408 of the actual photo_popup-file reads:

PHP Code:

The equivalent to the line you posted is in line 510 and reads

PHP Code:


		
			
$origimg = $vb_url . "/picture.php?albumid=" . $array['albumid'] . "&amp;pictureid=" . $array['pictureid'] . "";

What you suggest is sure to break the popup for everyone who doesn't run his forums from the site root.

The line you "fixed" was in file version 1.0 and was indeed buggy. The bug was - correctly - fixed in file version 1.1.

So I suggest you update to the actual version before reporting all bugs over and over again that were fixed in the last 6 releases of this mod.

cellarius

01-29-2009 06:15 AM

Quote:

Originally Posted by Namaless (Post 1727073)

Good MOD, but please use full link example:

Code:

$vboptions[bburl]/popup.php

I found problem with vBAdvanced Dynamics because this MOD work into subfolder into vb root :)

Thanks.

That's a valid suggestion, thank you. Template edits adjusted accordingly, but no new version for this.

cdnbacon

01-29-2009 07:09 AM

Installed this tonight. Simply amazing!

I'm curious if anyone else is getting a couple syntax errors reported by Internet explorer? Everything appears to work 100% correctly but the photo popup shows a script error in IE. Just an annoyance.

Any ideas how to troubleshoot such a thing?

cellarius

01-29-2009 10:43 AM

Quote:

Originally Posted by cdnbacon (Post 1727896)

Any ideas how to troubleshoot such a thing?

Yep, will be fixed in next release, thanks for the heads up. Just two single-quotes that IE misses.

MikesSite

01-29-2009 11:54 AM

Quote:

Originally Posted by cellarius (Post 1727816)

No, that's just plain wrong.

The line 408 of the actual photo_popup-file reads:

PHP Code:

The equivalent to the line you posted is in line 510 and reads

PHP Code:


		
			
$origimg = $vb_url . "/picture.php?albumid=" . $array['albumid'] . "&amp;pictureid=" . $array['pictureid'] . "";

RELAX man, there was a bug in my version, just trying to help. It read exactly how I had it, or else I wouldn't have posted that. IDK why I had an older version.

cellarius

01-29-2009 12:27 PM

Oh, I'm quite relaxed and if you follow this thread, you'll see that there really are no complaints about my support here.

Why you had the old version is quite simple: you obviously never uploaded the photo_popup.php after initial installation or never upgraded at all. It is obvious from what you postet that you are still on version 1.0. I really don't see what would be wrong or unrelaxed about suggesting you properly upgrade before reporting any more old bugs.

MikesSite

01-29-2009 12:36 PM

Quote:

Originally Posted by cellarius (Post 1728090)

Of course I upload photo_popup.php, or else I wouldnt have found the bug. Either way, the hack is great, something that should have been included in vBulletin. Thanks

cellarius

01-29-2009 01:55 PM

Quote:

Originally Posted by MikesSite (Post 1728099)

Of course I upload photo_popup.php, or else I wouldnt have found the bug. Either way, the hack is great, something that should have been included in vBulletin. Thanks

You do realize that you have to reupload the file with every update of the mod, do you? Because that's exactly what you did not do.

All times are GMT. The time now is 12:42 AM.

Page 13 of 61

« First

Last »

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01479 seconds Memory Usage 1,755KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (4)bbcode_php_printable (6)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (2)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: