vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Major Additions - vBMS : vBulletin Mail System (https://vborg.vbsupport.ru/showthread.php?t=140828)

succo 03-17-2007 09:37 AM

Quote:

Originally Posted by thincom2000 (Post 1205442)
I also noticed that when HTML is allowed, VBMS still shows the plain-text version of the message. Apparently, in both the VBMS_READ template AND I believe vbms_read.php, it checks a vBulletin setting that doesn't exist:

In template VBMS_READ:
Code:

$vboptions['vbms_htmlaction']
In file vbms_read.php:
PHP Code:

$vbulletin->options['vbms_htmlaction'

Should be replaced with:
Code:

$vboptions['vbms_allowhtml']
PHP Code:

$vbulletin->options['vbms_allowhtml'

respectively.

yes, but i think that more modifications are needed, as 'vbms_allowhtml' is a boolean, so how can it be equal to VBMS_HTMLACTION_NONE?

thincom2000 03-17-2007 08:07 PM

Well perhaps, I just took out the == VBMS_HTMLACTION_NONE at the same time I changed the variables because they were boolean anyway. So I was unaware that VBMS_HTMLACTION_NONE was not boolean as well.

Luky 03-18-2007 10:09 AM

Incredibly amazing.

Krofh 03-19-2007 05:58 AM

Quote:

Originally Posted by succo
btw, my forum is vba-wrapped, so the newmail template breaks, as there is an headincluded javascript...

I guess I don't fully understand what is going wrong; if vBa is trying to put something in headinclude all the time (I assume with a global_start hook), wouldn't that automatically put it into the vBMS? Part of it is that I've never much worked with vBa, so I'm not exactly sure how the wrapping thing works... if you wanna send me the stuff you changed and such though, that'd be cool, and I'll see what I can do about figuring out the working it in.
Quote:

Originally Posted by abroad
Thank you Krofh. Would you recommend to wait a bit until this product is tested a bit more and just use it on a test server at the moment?

Tbh, I would, especially if you've got a fairly large site. I think it's mostly stable, and I've gotten through a majority of the bugs so far, but it's still got a little ways to go.
Quote:

Originally Posted by succo
another little request... would it be possible to use vbulletin_ajax_namesugg.js when choosing recipients?

Awesome idea, I'll try to get that in if I can. It'd be cool if I could get it to merge your address book with the suggested list too; I'll have to look into that.
Quote:

Originally Posted by succo
the html portion of the message wasn't closed with the correct boundary, so the receiving client thought that the whole attachment was part of the html portion of the mail

to solve this issue, edit includes/vbms_class_mail_message.php, search for

Mehh, perhaps something's screwy on my server, because I added that conditional to make it work properly for me; attachments weren't working right otherwise. I guess I'll have to do a bit more serious testing with that bit to get it all working properly. Thanks for the feedback on it though.
Quote:

Originally Posted by scan-pa
Everything works on my test site except outgoing emails.

I recv emails fine, but get this error on sending replies or compose new emails.

There was an error sending your mail message. This site's host may be experiencing technical difficulties with its mail server at the moment. Please inform the administrator that the following error has occured:

there is no error given.

Does the mail() function work normally to begin with? Try going to the "vBMS Control Panel" in the ACP and test sending emails (at the bottom) with both vbmail() and mail() and see what's happening.
Quote:

Originally Posted by thincom2000
I also noticed that when HTML is allowed, VBMS still shows the plain-text version of the message. Apparently, in both the VBMS_READ template AND I believe vbms_read.php, it checks a vBulletin setting that doesn't exist:

Quote:

Originally Posted by succo
yes, but i think that more modifications are needed, as 'vbms_allowhtml' is a boolean, so how can it be equal to VBMS_HTMLACTION_NONE?

Ahh, this seems to be a leftover from when the old version started getting ported and didn't get finished. Got it changed now, will be proper in the next update. It's true, it's a boolean option now; it seems that there used to be different actions for handling HTML messages before though (automatically deleting them, removing the content and flagging them, converting them to bbCode [this is now the default "no" to allowhtml], or leaving as-is [this is the "yes" in allowhtml]). So yeah, feel free to take the VBMS_HTMLACTION_NONE bit out entirely of both of those and convert them both to allowhtml. Also btw, thanks especially to both of you for finding (and correcting) bugs so far, it's really been a big help (as well as everyone else who's been contributing here).

I just got back in town late last night, so hopefully I should be able to get another update out sometime this week. Keep the bugs coming :p

succo 03-19-2007 06:16 AM

Quote:

Originally Posted by Krofh
I guess I don't fully understand what is going wrong; if vBa is trying to put something in headinclude all the time (I assume with a global_start hook), wouldn't that automatically put it into the vBMS?

no, as far as i can see, vba uses only the body portion of any template and adds it to the central column of it, so anything in the head portion is simply ignored... i saw this when vba-wrapping other products using whole page templates, like vbagooglemaps... i had to insert the head scripts in a 'new' myproduct_headinclude template and parse it in the headinclude template with a little plugin which looks for the scriptname and if it's, say, vbms_new adds the vbms_headinclude part to headinclude
Quote:

Originally Posted by Krofh
Mehh, perhaps something's screwy on my server, because I added that conditional to make it work properly for me; attachments weren't working right otherwise. I guess I'll have to do a bit more serious testing with that bit to get it all working properly. Thanks for the feedback though on it though.

eh, i had to telnet to the mailserver and retr a message to see what was going on, as i'm not so accostumed to the mail syntax :)
anyway, once done, it was quite clear that the closing boundaries for the html part was missing :)

chilllax 03-19-2007 07:27 PM

I can send and receive emails wonderfully. But for some reason the trailer message isn't attached to the sent emails. Do you have any idea why?

By the way, thank you so much for putting the time in to deliver this amazing hack
;-)

d8tabyte 03-19-2007 09:36 PM

Installed and working great, thanks!

scan-pa 03-20-2007 05:19 AM

Quote:

Originally Posted by Krofh (Post 1207145)
Does the mail() function work normally to begin with? Try going to the "vBMS Control Panel" in the ACP and test sending emails (at the bottom) with both vbmail() and mail() and see what's happening.

Both of those tests worked, Email sent out were fine.

JawadIT 03-20-2007 04:58 PM

great hack
and its installed:up:

mindcry 03-21-2007 02:08 AM

One thing that I noticed which would probably be a good thing to add. If you are creating an alias you can have spaces and other illegal characters. Considering some users some of us have that could be bad, for example if someone made their name firstname@lastname@domain.com or firstname lastname@domain.com.


All times are GMT. The time now is 09:41 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01553 seconds
  • Memory Usage 1,761KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (2)bbcode_php_printable
  • (11)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete