vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   vRewrite - SEOed URLs for vBulletin (https://vborg.vbsupport.ru/showthread.php?t=104484)

Dean C 01-08-2006 01:41 PM

Quote:

Originally Posted by Immortal
What do you mean? Dean must be angry that his Mom didn't give him his cereal this morning, or exams are getting too tough. One of the small prices of being a coder that's still in school. vRewrite is just as efficient as Dean's. I can't say the same about vBSEO as it's encoded. If you find anything that's not "efficient" then let me know, and I'll be happy to investigate the problem.

First of all, stop throwing your dummy out the pram. Second of all, I explained to you exactly what is inefficient about your modification. Take it or leave it, and don't take it personally. You should be trying to learn, not snap because you can't take criticism.

Immortal 01-08-2006 01:48 PM

Quote:

Originally Posted by Dean C
First of all, stop throwing your dummy out. Second of all, I explained to you exactly what is inefficient about your modification. Take it or leave it, and don't take it personally. You should be trying to learn, not snap because you can't take criticism.

All I can see is you yellin' at my hack saying don't install it. Yet you never once said what was wrong specifically. You used a general term, and I looked through it and didn't see anything of that nature. I'll admit, I'm a PHP programmer, not a vB coder. I'm still learning the tricks of the trade, so I won't doubt there is problems. But you used a general term which I could not find. So could you? I would love to fix any issues before 1.0. But I still can't see anything of the nature you described.

croportal 01-08-2006 01:49 PM

Quote:

There is absolutely no need to run a query to get the forum titles for example, that information is in the forumcache, and also the forumtitle is available in other variables depending on the page you are on. Most of all you have un-necessary regex's being run on pages they don't need to be run on. It's far more efficient to redirect old URLs to their new equivalent using .htaccess, than to to try and rewrite every rule everywhere or at least limit the regex's on pages they only need to be on.
i agree with Dean, i have very large board and this will be...uffff

Guest190829 01-08-2006 01:59 PM

Everyone please remain calm here. Immortal, Dean's criticism was all constructive in my opinion and he wasn't being personal about any of it. I must assure everyone to keep their posts in this thread towards this hack only. Please do not bring up any other similiar modifications or anything else for that matter, it is not fair to the author and anyone else looking for valuable content concerning the hack. If you feel you need to discuss a hack or multiple hacks, you can do so maturely in an independent thread in the General Modifications Forum. :)

adb22791 01-08-2006 02:00 PM

Quote:

Originally Posted by Dean C
My SEO mod is not aimed at just rewriting URLs, when it comes out of beta it'll rewrite many sections of the vB HTML output, and also come with a sitemap generator of it's own and SEO tips in the readme. But the rewriting of URLs in my modification is done a lot more efficiently, the regexs are only called when they need to be. And no queries are run to get any of the information. :)

Good for you, now shut up and go write yours instead of picking on other peoples threads. Telling people not to install a hack somebody worked hard on is ridiculus. None of us would do that in your thread would we, so grow up and learn to show some respect.

Dean C 01-08-2006 03:56 PM

Quote:

Originally Posted by adb22791
Good for you, now shut up and go write yours instead of picking on other peoples threads. Telling people not to install a hack somebody worked hard on is ridiculus. None of us would do that in your thread would we, so grow up and learn to show some respect.

I didn't bring my modification into this topic whatsoever until someone mentioned it.

Anyways, Immortal, you should look at only running code on certain pages by checking the value of THIS_SCRIPT. Also the forum titles are stored in the datastore cache and you should use that to get the title associated with an ID.

vau7 01-08-2006 04:59 PM

Quote:

Originally Posted by Immortal
What do you mean? Dean must be angry that his Mom didn't give him his cereal this morning, or exams are getting too tough. One of the small prices of being a coder that's still in school. vRewrite is just as efficient as Dean's. I can't say the same about vBSEO as it's encoded. If you find anything that's not "efficient" then let me know, and I'll be happy to investigate the problem.

Sorry, but youre a bad loser. Deans arguments posting by posting are full of facts & hints for you and you just spit these childish stuff instead of arguments.

Go ahead, read the Code by Dean an learn.

@Dean: Concentrate on your exams and dont look in threads like this. ;)

MidnightPyro 01-08-2006 05:32 PM

Quote:

Originally Posted by vau7
Sorry, but youre a bad loser. Deans arguments posting by posting are full of facts & hints for you and you just spit these childish stuff instead of arguments.

Go ahead, read the Code by Dean an learn.

@Dean: Concentrate on your exams and dont look in threads like this. ;)

Bad loser? I don't really think anyone's losing here - especially someone who takes the time and effort to release their work to the community for free. While I know Dean most likely didn't have bad intentions, when you recommend NOT installing someone's hack in their thread, I can see why the hack author would get upset.

Immortal 01-08-2006 05:41 PM

Quote:

Originally Posted by Dean C
Anyways, Immortal, you should look at only running code on certain pages by checking the value of THIS_SCRIPT. Also the forum titles are stored in the datastore cache and you should use that to get the title associated with an ID.

Thank you Dean. I'm fixing it now for 1.0. As I said, I'm not a vB programmer ;)

Chroder 01-08-2006 05:43 PM

Also keep in mind this plugin is still considered 'beta' (as anyone can clearly see by looking at the 'Mod Version' information above).

The author is taking suggestions, fixing errata and is trying to optimize for version 1.0. We can't ask anything more then that :)

Anyway, good job thus far on the mod.


All times are GMT. The time now is 01:13 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02124 seconds
  • Memory Usage 1,751KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (8)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete