vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - Product Review Forums ? Research, Review & Compare Items (https://vborg.vbsupport.ru/showthread.php?t=269808)

GCC LLC 08-28-2012 02:04 PM

Quote:

Originally Posted by Ted S (Post 2360596)
That said I'll take a look at the search bug and see if we can fix it.

I had to remove the mysql_real_escape_string() from around the format search input for it to work. Anything better I could replace it with? We use mysqli if that matters. Its working fine without any function wrapped around it, but not sure if that could lead to other issues on the textbox input on product title searches.

GCC LLC 08-28-2012 02:13 PM

I noticed that in your code, you don't include a link identifier on the mysql_real_escape_string:

if($vbulletin->GPC['title']){ $conditions .= " AND pfp.title LIKE '%". mysql_real_escape_string($vbulletin->GPC['title']) ."%'"; } // title of product

It should default to the last used connection, but in my case I think it's not. In the meantime, I've switched to mysql_escape_string() which appears to be working. Do you see any issues with this?

Also all new reviews go into moderation even though I have the option turned off and made sure the forum have all moderation turned off. Thought it might be a conflict with Glowhost so uninstalled that and they still get moderated.

ynh 08-28-2012 08:29 PM

Anyone have an idea of how to add an attachment option to the post new product page?

(productforums.php?do=addproduct)

Ted S 08-28-2012 08:31 PM

Quote:

Originally Posted by GCC LLC (Post 2360667)
Every store in our industry has well over 100 manufactureres so if your going to support a mass import of products then users are going to get a list of companies that stops in the middle because of the 100 set limit whether its manageable or not. I agree there has to more search options but you will still run into this error with bulk imports.

Sounds like my comment didn't come ascross right...

The business we run that inspired PRF processes something like 14 million products nightly from hundreds of thousands of manufacturers. And that's small potatoes compared to what our partners do... There's no problem with the structure of how the brands are stored whether you have 1, 100 or 10,000. We have the limit clause in for database speed but as you noted, it's no big deal to remove and perhaps something we can make an option of.

The issue however is in the presentation and resulting UX.

PRF was designed for the typical community owner who, to this point, is generally adding at most a few hundred products from a few dozen brands. As such a dropdown works fine.

However at a scale of say 50 [you'd have to test to find the actual threshold] dropdown lists become unusable for the user. Technically they still work, still load but it's just not feasible to scroll and mentally process. Thus you either need an open search field or progressive autofill...

While it's not a built in feature we designed PRF as a starting place to cover 90% and this is one of those 10% items worth customizing given your particular use yourself. But of course that's just my $0.02

Ted S 08-28-2012 08:32 PM

Quote:

Originally Posted by ynh (Post 2360790)
Anyone have an idea of how to add an attachment option to the post new product page?

(productforums.php?do=addproduct)

There is no simple way to do this. You can however very easily add them to the first post in the product's thread :D

Ted S 08-28-2012 08:34 PM

Quote:

Originally Posted by GCC LLC (Post 2360704)
I noticed that in your code, you don't include a link identifier on the mysql_real_escape_string:

if($vbulletin->GPC['title']){ $conditions .= " AND pfp.title LIKE '%". mysql_real_escape_string($vbulletin->GPC['title']) ."%'"; } // title of product

Escaping the string is essential for preventing injections so good call on working through that...

We'll be redoing the search function a bit in light of your bug report and will try to test with a few mySQLi connections as well.

Quote:

Originally Posted by GCC LLC (Post 2360704)
Also all new reviews go into moderation even though I have the option turned off and made sure the forum have all moderation turned off. Thought it might be a conflict with Glowhost so uninstalled that and they still get moderated.

Does the forum allow for new replies? Closed forums seem to have this issue...

GCC LLC 08-29-2012 12:02 AM

Quote:

Originally Posted by Ted S (Post 2360791)
Sounds like my comment didn't come ascross right...

The business we run that inspired PRF processes something like 14 million products nightly from hundreds of thousands of manufacturers. And that's small potatoes compared to what our partners do... There's no problem with the structure of how the brands are stored whether you have 1, 100 or 10,000. We have the limit clause in for database speed but as you noted, it's no big deal to remove and perhaps something we can make an option of.

The issue however is in the presentation and resulting UX.

PRF was designed for the typical community owner who, to this point, is generally adding at most a few hundred products from a few dozen brands. As such a dropdown works fine.

However at a scale of say 50 [you'd have to test to find the actual threshold] dropdown lists become unusable for the user. Technically they still work, still load but it's just not feasible to scroll and mentally process. Thus you either need an open search field or progressive autofill...

While it's not a built in feature we designed PRF as a starting place to cover 90% and this is one of those 10% items worth customizing given your particular use yourself. But of course that's just my $0.02

I'm not disagreeing, just stating that you could come across this when importing large amounts of products. Now if someone searches this thread, they will know why. :)

GCC LLC 08-29-2012 12:11 AM

Quote:

Originally Posted by Ted S (Post 2360793)



Does the forum allow for new replies? Closed forums seem to have this issue...


Yes, everything is open. We are using the forumdisplay.


User posts a review. It gets put in moderation, but it still posts the review.

Now it gets strange. It posts the review twice (within the same post). You will get <review><br><review> all within the postbit. The <br> is visible. This seems to happen with users copying and pasting with or without WYSIWYG on.

Now usually as we know, a new post will update the sorting order (newest post first). Even though the review is posted, the forumdisplay will not update the sorting order until I approve the post (review).

Ted S 08-29-2012 12:22 AM

Quote:

Originally Posted by GCC LLC (Post 2360842)
Yes, everything is open. We are using the forumdisplay.


User posts a review. It gets put in moderation, but it still posts the review.

Now it gets strange. It posts the review twice (within the same post). You will get <review><br><review> all within the postbit. The <br> is visible. This seems to happen with users copying and pasting with or without WYSIWYG on.

Now usually as we know, a new post will update the sorting order (newest post first). Even though the review is posted, the forumdisplay will not update the sorting order until I approve the post (review).

So I'm clear only 1 post is made, but with duplicate content in it, and it's always in moderation?

GCC LLC 08-29-2012 12:28 AM

Quote:

Originally Posted by Ted S (Post 2360848)
So I'm clear only 1 post is made, but with duplicate content in it, and it's always in moderation?


Yes. User "submits" one review but the content gets posted twice within postbit with a visible <br> in between.

Every review goes into moderation even though I have moderation turned off within the plugin as well as in the forum. I don't think it shows the <br> and duplicate content within the moderation window. I will check and see next time it happen.


All times are GMT. The time now is 10:32 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03586 seconds
  • Memory Usage 1,757KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (9)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (5)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete