vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Chat Modifications - MGC Chatbox Evo (https://vborg.vbsupport.ru/showthread.php?t=168992)

XiZa 05-07-2008 06:59 AM

Couple more suggestions, can't help myself :) I like this software alot.

In safari, the colors don't show in the dropdown, so you only see #xxxxx numbers, which are meaningless to my users. (Well, maybe just me, since there aren't that many safari users, but still).

It would be better if you used the real name for the color (magenta, etc) or if that's not possible, check if it's safari and show only basic colors.

Second suggestion, most of the time, when one chooses a color and font, it is meant to style the whole message, so displaying those BBCodes in the small chatbox just clutter that up and make it prone to user error. It would be better if you put that in some sort of javascript variable which you then pre and append when the user clicks submit so that the server does indeed receive the BBcode correctly. There could be a checkbox to show the bbcode for more advanced users.

Third, sometimes a user selects one color but then changes his/her mind and chooses another. In your app, this results in two [color] bbcodes. Maybe clean that up if possible?

Thanks again :)

MV Blackie 05-07-2008 07:29 AM

no i did'nt :rolleyes:

Quote:

Originally Posted by Digital Jedi (Post 1510579)
Did you set your permissions yet?


VBDev 05-07-2008 09:59 AM

Quote:

Originally Posted by XiZa (Post 1511280)
Well,

You could add json commands like {command:'removeMessage': 112} and things like that to remove messages. But that would mean you would have to keep a log of removed messages.. and edited messages.. in separate tables since if you just send the last x messages you wouldn't know if they were deleted or edited.

Or perhaps just an extra column in the message table status: active, deleted, edited (perhaps a date value)

And if the user wants to ignore someone, then you can indeed respond with a full reload or just use client side javascript to remove the entries by that user if you kept that information available.

<tr id="message_y" class="user_x">

The javascript would also be intensive too with that method and not very brain savy to implement, especially as I don't know anything about Json :D

Quote:

Originally Posted by XiZa (Post 1511280)
Also, when someone isn't online and you try to PM them, it states "that user doesn't exist". Think it would be better if you would say "the user isn't online".

Anyway, you have seen the popup dialog screenshot, will you be fixing that?

You can send a PM to a user who isn't online. There is nothing to avoid it in my code.

Perhaps you are not using the right syntax.

Quote:

Originally Posted by XiZa (Post 1511280)
I also attached a pic about the spacing issue, small issue but would be better if fixed :) No space between date and "To/from" and after the name. Maybe if you used &nbsp; it would work better.

It works as implemented.

I still don't see what is the issue.

Quote:

Originally Posted by XiZa (Post 1511280)
Also, a spelling error in the help: "usergroupds "

Added to the bug list thanks.

Quote:

Originally Posted by XiZa (Post 1511280)
Edit: I would also love the ability to remove certain icons, like the button that empties the chat input field. And the ability to change the icon images.

I won't add options for each buttons. Having an option for each buttons tends to be a bit too much don't you think ? You can remove them by editing the mgc_cb_evo_editor template.

About icon images, you can do you own by changing the one in the misc/mgc_cb_evo directory located in the images directory of your style.

Quote:

Originally Posted by XiZa (Post 1511282)
One more question, I just noticed a different initial state (chat log) from two accounts. Is this a setting somewhere or a bug? If I go in safari to the archives I see all of it, but if I use my other user account in firefox, it only shows my posts I just made.

(Note that i am just testing this currently with only two users, offline)

What do you mean by different initial state ?

Perhaps they don't have the same rights for the commands used ?

Quote:

Originally Posted by XiZa (Post 1511290)
Also, the command syntax could possibly be made better?

Does vbulletin allow usernames that are numbers only? If not you could check if integer, its uid otherwise username.

Another error in the help:

/pm uname "userid"

should be "username"

I just checked and it doesn't appear that vbulletin blocks integer names..

Better syntax could be:

/ignore username
/unignore username
/ignore userid uid
/unignore userid uid

So only use a parameter (uid) to the more advanced option which I doubt many people will use anyway.

Don't require " " around the username unless there are spaces in the username. (then you could show an error mesage before sending the command to the server)

I won't change the commands syntax sorry.

However I plan on doing an autocompletion system so this will help.

VBDev 05-07-2008 10:04 AM

Quote:

Originally Posted by XiZa (Post 1511350)
Couple more suggestions, can't help myself :) I like this software alot.

In safari, the colors don't show in the dropdown, so you only see #xxxxx numbers, which are meaningless to my users. (Well, maybe just me, since there aren't that many safari users, but still).

It would be better if you used the real name for the color (magenta, etc) or if that's not possible, check if it's safari and show only basic colors.

I know that safari don't take into account the color and background-color attribute in the option tag of a select.

Sorry but I won't put color names as adding colors would add a lot of translation issues...

However perhaps I will implement a color picker in a next version.

Quote:

Originally Posted by XiZa (Post 1511350)
Second suggestion, most of the time, when one chooses a color and font, it is meant to style the whole message, so displaying those BBCodes in the small chatbox just clutter that up and make it prone to user error. It would be better if you put that in some sort of javascript variable which you then pre and append when the user clicks submit so that the server does indeed receive the BBcode correctly. There could be a checkbox to show the bbcode for more advanced users.

Hum yes I could make a checkbox show/hide bbcode. Good suggestion.

Quote:

Originally Posted by XiZa (Post 1511350)
Third, sometimes a user selects one color but then changes his/her mind and chooses another. In your app, this results in two [color] bbcodes. Maybe clean that up if possible?

I don't think it's that useful no ? It's a bit of perfection to go that far in optimization ;)

Quote:

Originally Posted by MV Blackie (Post 1511383)
no i did'nt :rolleyes:

Then you have your answer ;)

XiZa 05-07-2008 10:15 AM

Don't think the javascript would be intenstive at all, class selectors are used everywhere in most every ajax script. Just write something like $('#chatbox .user_25') to select all his/her messages (note jquery syntax, but can ofcourse be adapted to any framework..) point i'm trying to make is that if you use a #chatbox (<table id="chatbox">) it will only search there for specific classes so that will take much less resources. And most of the time there aren't going to be any chat messages anyway or messages won't be deleted so none of this will be executed anyway.

Much better to send an empty response versus the 55kb sent every 10 seconds (i checked).

The issue is that there is no space between the date and "to/from"

It is:

06:29To lala

But should be

06:29 To lala

I hope you will at least fix the dialog popups that don't display properly see my earlier attachment.

And yeah doh i can just change the templates :) nix that suggestion about icons on/off :)

About the colors, you could do default array: #00000 => #00000, then english: #00000 => Black etc, but I guess a color picker works equally fine :)

When I talked about the initial state I meant the messages that were posted in the chatbox when you load the page. On one, it showed all, on the other, it showed nothing. Permissions are the same as far as i can see.

soundbarrierpro 05-07-2008 10:40 AM

Quote:

Originally Posted by VBDev (Post 1510979)

However XiZa is right, it will use bandwidth but that amount is not that significant comparing to downloading a file for example ;)

The use of the bandwith won't be that intensive.

Cool, downloading and marking installed another nomination:)

VBDev 05-07-2008 11:00 AM

Quote:

Originally Posted by XiZa (Post 1511474)
Don't think the javascript would be intenstive at all, class selectors are used everywhere in most every ajax script. Just write something like $('#chatbox .user_25') to select all his/her messages (note jquery syntax, but can ofcourse be adapted to any framework..) point i'm trying to make is that if you use a #chatbox (<table id="chatbox">) it will only search there for specific classes so that will take much less resources. And most of the time there aren't going to be any chat messages anyway or messages won't be deleted so none of this will be executed anyway.

Much better to send an empty response versus the 55kb sent every 10 seconds (i checked).

Humm. That's a good point ! I'll make some research on that and see if I can use jquery to do that as it seems interesting.

Quote:

Originally Posted by XiZa (Post 1511474)
The issue is that there is no space between the date and "to/from"

It is:

06:29To lala

But should be

06:29 To lala

Oh ok, noted !

Quote:

Originally Posted by XiZa (Post 1511474)
I hope you will at least fix the dialog popups that don't display properly see my earlier attachment.

I haven't understood when that problem has occured to you ?

Quote:

Originally Posted by XiZa (Post 1511474)
When I talked about the initial state I meant the messages that were posted in the chatbox when you load the page. On one, it showed all, on the other, it showed nothing. Permissions are the same as far as i can see.

There shouldn't be any difference then.

You can reproduce it recurently ?

soundbarrierpro 05-07-2008 11:26 AM

When I enter text into the chat box and hit ok as admin I see no verbiage in the open chat area? I selected in ACP for Admin to have all permissions and registered users have the ability to see and respond but I see nothing at all?

VBDev 05-07-2008 11:43 AM

Quote:

Originally Posted by soundbarrierpro (Post 1511535)
When I enter text into the chat box and hit ok as admin I see no verbiage in the open chat area? I selected in ACP for Admin to have all permissions and registered users have the ability to see and respond but I see nothing at all?

Do you see the sent shouts in the admin ?

Do you get any error in your browser (javascript error) ?

XiZa 05-07-2008 11:47 AM

You can see a screenshot of the dialog box here that is not displaying correctly in safari:

https://vborg.vbsupport.ru/attachmen...7&d=1210106416


All times are GMT. The time now is 12:46 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.12112 seconds
  • Memory Usage 1,792KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (18)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (7)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete