vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.7 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=228)
-   -   Major Additions - Links and Downloads Manager (https://vborg.vbsupport.ru/showthread.php?t=166094)

vbboarder 09-21-2008 03:25 AM

Thanks for the bug fix, but unfortunately it didn't work correctly. The entries that are showing are newer than before the fix, but it's not correct. The VBA module for new entries stats (ldm_new.module) correctly retrieves the newest entries. I have a test forum so I'm fully aware of all the new entries, and the VBA entries list is correct.

Can I just cut the php code from ldm_new.module and paste it in the ldm_get_hitparades function (and removing the current code)?

vbboarder 09-21-2008 03:49 AM

Ok, I got the nominations display problem figured out. The problem was the nominated entries page do not show any entries until the contest is over (time period is set in the starred_entries_gather variable.). Sorry for the confusion Andrew, the page correctly shows winning nominations now.... I mistakenly thought that the page was supposed to show nominations that were winning the current contest.

Question: I can only nominate 1 entry until the contest is over. If I nominate another entry, then that entry will replace my current nomination. Is there a way to allow multiple nominations during 1 contest period?

Feature Request: Can you provide a page that displays the current nominations (sorted by # of votes) so that users can easily vote instead of having to surf through different categories and see what's nominated?

vbboarder 09-21-2008 04:08 AM

Can you help me to get the featured entries page to work?

I enabled featured sites, I set featured_all_categories to yes, I selected entries as favorites, and I set my userid in featured_user_favs. The my favorites page shows the entries that I selected as favorites, but the featured sites page do not show any entries.

Quote:

It's $nhits that's the problem. I imagine you've got featured sites enabled and there are none to show in the current category. The code which sets up the featured sites is over-writing the correct value of $nhits.
.
The featured sites problem is also causing the filter links bar to not appear since you stated the featured sites is overwriting the $nhits value.

AndrewD 09-21-2008 04:43 AM

Quote:

Originally Posted by vbboarder (Post 1626671)
Thanks for the bug fix, but unfortunately it didn't work correctly. The entries that are showing are newer than before the fix, but it's not correct. The VBA module for new entries stats (ldm_new.module) correctly retrieves the newest entries. I have a test forum so I'm fully aware of all the new entries, and the VBA entries list is correct.

Can I just cut the php code from ldm_new.module and paste it in the ldm_get_hitparades function (and removing the current code)?

I thought there was probably a reason why I'd coded it the way I did :). The change I proposed gives you 'N entries created since X' instead of 'the N most recent entries', whereasthe original code was just giving you 'N entries'

Actually, there seem to be a range of problems in that part of the code, including in the vba module, so I must work through this again.

**Edited: Can you give this code a try?

AndrewD 09-21-2008 04:46 AM

Quote:

Originally Posted by vbboarder (Post 1626677)
Ok, I got the nominations display problem figured out. The problem was the nominated entries page do not show any entries until the contest is over (time period is set in the starred_entries_gather variable.). Sorry for the confusion Andrew, the page correctly shows winning nominations now.... I mistakenly thought that the page was supposed to show nominations that were winning the current contest.

OK, that's how it is intended to work.

Quote:

Originally Posted by vbboarder (Post 1626677)
Question: I can only nominate 1 entry until the contest is over. If I nominate another entry, then that entry will replace my current nomination. Is there a way to allow multiple nominations during 1 contest period?

Perhaps we can have a setting 'Allow each user N nominations'. What do you think?

Quote:

Originally Posted by vbboarder (Post 1626677)
Feature Request: Can you provide a page that displays the current nominations (sorted by # of votes) so that users can easily vote instead of having to surf through different categories and see what's nominated?

Actually, this is on my list of things to do...

AndrewD 09-21-2008 04:52 AM

Quote:

Originally Posted by vbboarder (Post 1626683)
Can you help me to get the featured entries page to work?

I enabled featured sites, I set featured_all_categories to yes, I selected entries as favorites, and I set my userid in featured_user_favs. The my favorites page shows the entries that I selected as favorites, but the featured sites page do not show any entries.

I can't reproduce this - it works ok for me. Any more information you can give me?

Quote:

Originally Posted by vbboarder (Post 1626683)
The featured sites problem is also causing the filter links bar to not appear since you stated the featured sites is overwriting the $nhits value.

Just change $nhits for (e.g.) $nfhits at around line 733 in local_links.php (in the code which is building the featured sites bit)

vbboarder 09-21-2008 06:55 AM

Quote:

Originally Posted by AndrewD (Post 1626699)
Perhaps we can have a setting 'Allow each user N nominations'. What do you think?

Good idea!
Quote:

Actually, this is on my list of things to do...
Sounds great!
Quote:

I can't reproduce this - it works ok for me. Any more information you can give me?
Will test the featured sites some more and see what other info I can come up with. cache_LDMfavourites() is called at about line 505 in local_links_search.php, which sets the linkids that are marked as favourites in array $links_fav - can you tell me where the $links_fav variable is put to use (what file, function, or template)?

AndrewD 09-21-2008 07:24 AM

Quote:

Originally Posted by vbboarder (Post 1626745)
Can you tell me where the $links_myfav variable is put to use (what file, function, or template)?

In includes/local_links_includes ldm_get_entrybits() in order to check whether each entry bit corresponds to a favourite or not.

vbboarder 09-21-2008 09:58 AM

Found problem to getting featured sites to display entries:

I've been reviewing & modifying lots of codes & templates lately, so when the featured_user_favs setting asked for users, I instinctly put in userids. Unfortunately, that field doesn't accept userids, but require usernames. And because my test forum doesn't have usernames starting with numbers, the ajax name helper never appeared. LOL - I feel so silly :o Sorry for any confusion Andrew; you might want to put a note next to that field that userid's are not accepted so people don't waste your time like me :rolleyes:

The filter links bar will only show in categories that have featured sites - I will try the change from $nhits to $nfhits as you suggested. Also, I'll test the new local_links_vbafunc.php and report back later.

Feature Request: Can you provide an option so that featured sites are not displayed again in the regular listing when viewing a category's entries?

dranet 09-21-2008 12:00 PM

I have a question about setting the submission date. Does the time zone of the uploader affect when the file will become available? Or is it based on the server time?

Thanks!
Tracy


All times are GMT. The time now is 11:40 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02770 seconds
  • Memory Usage 1,757KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (11)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (5)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete