vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 2.x Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=4)
-   -   Collapsable forums on forum home (https://vborg.vbsupport.ru/showthread.php?t=33961)

dabean 01-18-2002 02:10 PM

Quote:

Originally posted by Sven

I installed it yesterday and it works perfect with 2.2.1!

Just a little annoying though that settings are not saved for users - that's why I asked for the enhancement on the previous page.

Dabean, any comment on this?

They should be saved if the hack is installed correctly..
have you uploaded updateindex.php to your forums directory?

When i visited your site I received a 404 page not found when requesting that file, suggesting it has not been uploaded.

Shenlong: The name that you give the provided style set is not important what is important is that when you view your site via the the provided style the collapse/expand buttons should appear.

Sven 01-18-2002 02:56 PM

I feel like a little dumbass...
I uploaded it to the admin dir....

Now it's working, thx a lot ;)

Arsenik 01-20-2002 06:31 PM

I installed the hack and works the way it was written for. Great job!

It would be very usefull if users could edit their user settings so that the forums status are remembered:

1- select if all the forums should be collapsed or expanded
2- select the categories they want collapsed or expanded
3- choose to use the default settings defined by the admin or not...

Since only the settings defined by the Admin for the default collapse/expand status of categories are remembered it would be nice if the users could edit their settings that way changes are remembered. Since changes arent remembered on the fly it would be a good way around the problem it seems.

dabean 01-20-2002 11:27 PM

Quote:

Originally posted by Arsenik
I installed the hack and works the way it was written for. Great job!

It would be very usefull if users could edit their user settings so that the forums status are remembered:

1- select if all the forums should be collapsed or expanded
2- select the categories they want collapsed or expanded
3- choose to use the default settings defined by the admin or not...

Since only the settings defined by the Admin for the default collapse/expand status of categories are remembered it would be nice if the users could edit their settings that way changes are remembered. Since changes arent remembered on the fly it would be a good way around the problem it seems.

Item 1., I'll consider it for a future version.
Item 2. how is this different to the current behaviour?
Item 3. ditto.

Both item 2 and 3 should be satisfied by hack as it exists currently when correctly installed.

Common installation errors are:
- updateindex.php not being uploaded to the forum directory.
- old version of the forumhome_expandjscript template.. not 100% sure why people are still having problems with this as the current zip contains a working version of the template.

Arsenik 01-21-2002 02:22 AM

I was talking about the Users them selves and not only the Admin of the board. ;)

I mean have the members edit their options and be able to use the settings the Admin selected by default or just not to use it at all if they dont want to. And also have the members be able to select what category they want collapsed or expanded like the Admin but in their own user options and be keept in the db since Collapsing and Expanding the forums on the fly doesnt work well. (the changes arent remembered)

Right now the hack keeps in the db the settings the Admin selects but not what the Members select thats what i was wanting to say. My bad if i wasnt clear. :(

dabean 01-21-2002 05:42 PM

Quote:

Originally posted by Arsenik
I was talking about the Users them selves and not only the Admin of the board. ;)

I mean have the members edit their options and be able to use the settings the Admin selected by default or just not to use it at all if they dont want to. And also have the members be able to select what category they want collapsed or expanded like the Admin but in their own user options and be keept in the db since Collapsing and Expanding the forums on the fly doesnt work well. (the changes arent remembered)

Right now the hack keeps in the db the settings the Admin selects but not what the Members select thats what i was wanting to say. My bad if i wasnt clear. :(

Um no the users choice to expand or contract a forum is saved in the database with the hack as it exisits currently. This is in addition to admins being able to choose the forums to collapse by default. The the defaults are just that a user overridable default.

To make it clear exactly how this is achived I'll go through the function found in the current version line by line

PHP Code:

function dostatesaveXP (forumIDvalue) {
 var 
ifrm;
 if (
document.getElementById("colapser")) {  <- does the iframe element exist?
 
// okay iframe exists
  
document.getElementById("colapser").setAttribute("src""updateindex.php?s=$session[sessionhash]&fid="+forumID+"&val="+value);  <- set the iframe's SRC to load the preferance update.

  document.getElementById("colapser").style.visibility="visible"; <- make iframe visible
  document.getElementById("colapser").style.display="inline"; <- display iframe

  document.getElementById("colapser").style.visibility="hidden"; <- make iframe invisible
  document.getElementById("colapser").style.display="none"; <- hide iframe
 } else { <- no iframe exists lets make one :)
  ifrm = document.createElement("IFRAME"); <- create the iframe
  ifrm.setAttribute("id","colapser"); <- set its unque identifier
  ifrm.setAttribute("src", "updateindex.php?s=$session[sessionhash]&fid="+forumID+"&val="+value); <-  set the iframe'
s SRC to load the preferance update.
  
ifrm.style.width 80+"px"; <- make the iframe small
  ifrm
.style.height 30+"px"; <- make the iframe small
  
// ifrm.onload = hideframe; <- commented out, useless currently as IE doesn't support this
  
document.body.appendChild(ifrm); <- append the iframe into the document
  document
.getElementById("colapser").style.visibility="hidden"; <- make frame invisible
  document
.getElementById("colapser").style.display="none"; <- hide frame
 
}


Now for clarity the diference between display and visibility is display controls the box visiblity whilst visibility controls the element visiblity.. A display value of none with visibilty of visible would still leave the element visible, but out of "flow" with the other elements. Just like a display value of inline and visibility of hidden would hide the element but leave it's box behind leaving a empty "hole" in the page.

philphee 01-22-2002 12:46 AM

dabean,

After I reread the instrustions and applied the changes specified to "forumhome_forumbit_level2_post" instead of "forumhome_forumbit_level1_post" it worked like a charm.

(Perhaps I should stop smoking crack :stupid: )

Thanks again for the great hack!!!

mvigod 01-30-2002 02:46 AM

Just for clarity before I install this what exactly is Template_Option.txt in the instructions? What option does this refer to? Have no idea what you mean by

Quote:

If you have the forum, post, threads, template hack

dabean 01-30-2002 12:26 PM

Quote:

Originally posted by mvigod
Just for clarity before I install this what exactly is Template_Option.txt in the instructions? What option does this refer to? Have no idea what you mean by


Basically that exention was provided as a request to cover sites with the template modification that adds a "header" to each grouping.
For a example Scroll back towards the begining somewhere around page 2 or 3 for posts by sirsteve.

mvigod 01-30-2002 05:03 PM

Great hack!

Just installed it, followed the well written instructions and worked perfect on 2.2.1

I tested it on IE on the PC and it works fine...BUT...tried it on IE 5.0 on the Macintosh and when you collapse a forum all the forum titles, thread titles, descriptions and tables below the collapsed forum get squeezed to the left (take up maybe 30% of the left hand side of the table instead of running normally to fill the whole table left to right).

If you have a Mac with IE you can test it at my forum to see it.

http://www.rcuniverse.com

Any idea how to fix?

Also attached some images to match the default vbulletin style for anyone who wants them.

marc


All times are GMT. The time now is 03:10 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02099 seconds
  • Memory Usage 1,766KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_php_printable
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete