| Bunni U |
07-28-2011 09:54 PM |
Quote:
Originally Posted by HipHopStan.com
(Post 2226196)
wow... ur right... that option definitely adds to the load time
|
hmmm that option, for what ever silly reason, catches the ESB hook "parse_templates"
PHP Code:
if ($vbulletin->options['bbactive'] and $vbulletin->options['esidebar_switch'])$bbandSBactive=1;
if ($bbandSBactive){
if($vboptions['storecssasfile']){
$tempside='<link rel="stylesheet" type="text/css" href="\' . $vbcsspath . \'forumhome-rollup.css" />';
}else{
$tempside='<link rel="stylesheet" type="text/css" href="\' . $vbcsspath . \'sidebar.css,forumbits.css,forumhome.css,tagcloud.css,widgets.css,options.css" />';
if($vbulletin->options['esidebar_onload'] and in_array(THIS_SCRIPT, array('index', 'forumdisplay', 'showthread', 'newreply', 'editpost', 'vbcms', 'usercp', 'member', 'private', 'search', 'album', 'faq', 'calendar', 'list', 'profile', 'subscription')))
$tempside.='<style>#sidebar_container{display:none;}#content_container{display:none;}</style>';
$tempside.='<!--[if IE 6]><link rel="stylesheet" type="text/css" href="\' . $vbcsspath . \'forumbits-ie.css" /><![endif]-->';
$tempside.='<!--[if lt IE 8]><link rel="stylesheet" type="text/css" href="\' . $vbcsspath . \'forumbits-ie.css,sidebar-ie.css" /><![endif]-->';
}
$sidebarext_search = '$final_rendered = \'\'';
$sidebarext_replace = '$final_rendered=\''.$tempside.'\'';
$vbulletin->templatecache['headinclude_bottom'] = str_replace($sidebarext_search, $sidebarext_replace, $vbulletin->templatecache['headinclude_bottom']);
}
for my forum line 9 of that hook:
PHP Code:
$tempside.='<style>#sidebar_container{display:none;}#content_container{display:none;}</style>';
applied those display:none css styles to both the sidebar and all forum content, causing all content to be hidden, for what ever reason, updating from 1.4.3.1 to 1.4.3.3 caused that display:none style to not be removed (assuming it was supposed to be removed when the page loaded). This resulted in all correlating pages to be empty vb pages (had header and footer but nothing else).
Interestingly, the aforementioned functionality worked correctly when the forums were disabled via VB settings-> Forum disabled. And ceased to work with the above observations once the forum was enabled.
Perhaps our boards differ from others in that our main content has the content_container class, so perhaps functionality that was only ment for ESB was also being applied to all site content and thus my board was the only one that encountered such problems.
In regards to your finding, Ill assume that this "Show ESB Onload" option, causes ESB to hide your page results, until everything is loaded. So, in essence you are just seeing the page load now in the same amount of time, but now you can see it loading. Where-as before page content was hidden until the page finished loading. |
More Information