vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Show Thread Enhancements - Image resizer (https://vborg.vbsupport.ru/showthread.php?t=118048)

Hollanda 02-22-2007 06:00 AM

Quote:

Originally Posted by RedGTiVR6 (Post 1188024)
I'm guessing I've done something wrong:

Code:

Invalid SQL:
ALTER TABLE `user` ADD `ncode_imageresizer_mode` ENUM("none", "enlarge", "samewindow", "newwindow") DEFAULT "enlarge" NOT NULL;

MySQL Error  : Duplicate column name 'ncode_imageresizer_mode'
Error Number : 1060

I selected the radio button to allow the upgrade even...and I uploaded the newest .js file as well.

Ideas on where to start?

Same problem...

dirty68 02-22-2007 06:10 AM

Thank you

Spleasure 02-22-2007 06:27 AM

Quote:

Originally Posted by RedGTiVR6 (Post 1188024)
I'm guessing I've done something wrong:

Code:

Invalid SQL:
ALTER TABLE `user` ADD `ncode_imageresizer_mode` ENUM("none", "enlarge", "samewindow", "newwindow") DEFAULT "enlarge" NOT NULL;

MySQL Error  : Duplicate column name 'ncode_imageresizer_mode'
Error Number : 1060

I selected the radio button to allow the upgrade even...and I uploaded the newest .js file as well.

Ideas on where to start?

Quote:

Originally Posted by Hollanda (Post 1188101)
Same problem...


Which file did you download? Are you sure that it is the latest version? Please remove as a temporary fix the image resizer before you install the newest version.

TrIn@dOr 02-22-2007 09:17 AM

updated, thanks.

RedGTiVR6 02-22-2007 10:58 AM

well, I'm not sure what I did or didn't do initially, but I tried it again, and it's all good now!

Thanks again!

encryption 02-22-2007 11:25 AM

Love the simplicity of this mod.... fantastic

Caiman 02-22-2007 01:59 PM

Love it, seems to work fine but I keep seeing this in whosonline;

Unknown Location
/clientscript/ncode_imageresizer.js?v=3

^Seems to show up whenever a user has clicked on an image and expanded it. As far as I can tell, everything is working, just curious as to why it shows users viewing this location.

Spleasure 02-22-2007 03:41 PM

Quote:

Originally Posted by Caiman (Post 1188300)
Love it, seems to work fine but I keep seeing this in whosonline;

Unknown Location
/clientscript/ncode_imageresizer.js?v=3

^Seems to show up whenever a user has clicked on an image and expanded it. As far as I can tell, everything is working, just curious as to why it shows users viewing this location.

That's strange. At a forum of mine where this mod is also used I can't see this behaviour. Does anyone else have this problem?

Smoothie 02-22-2007 03:58 PM

It's a very strange import screen when installing this. After add/import product, browse for the file and then click import it takes you to a screen that says something about adding the tables (not an error) and if doesn't add them you have to run the queries manually. At the bottom it says import successful and then there's a back button. Very odd and confusing.

da420 02-22-2007 05:19 PM

Quote:

Originally Posted by Smoothie (Post 1188370)
It's a very strange import screen when installing this. After add/import product, browse for the file and then click import it takes you to a screen that says something about adding the tables (not an error) and if doesn't add them you have to run the queries manually. At the bottom it says import successful and then there's a back button. Very odd and confusing.

Same here, it told me if the table was not created that I would have to run the query manually... I didn't even think to find the name of the table, and check PHPMyAdmin to see if it created the table, because I updated this at about 2am last night and was too tired to figure it out.

It seems to work fine though.

Smoothie 02-22-2007 05:25 PM

At first, after seeing this screen, I wasn't sure the thing even installed correctly. Only when I scrolled way down to the bottom of the page did I see the installed successful message. I did click back and was in the import screen again, and the link to the file still there in the browse box

da420 02-22-2007 05:36 PM

Yeah, I did pretty much the same. It was confusing at first, but I *think* everything was installed properly. I over wrote the product this morning just to see what would happen, and it seemed to over write without a hitch and I didn't get that message. So from the sounds of it, it installed properly... just something I have never seen before...

Spleasure 02-22-2007 06:45 PM

I will make it more intuitive in the next version. In the previous version I had people complaining that the installer did not update the database correctly, so I thought it would be good to make clear which changes are about to be done. It turns up that this is confusing. I'm going to see if there is a beter way.

Tralala 02-22-2007 07:08 PM

I thought it was pretty clear, the message says "This is not an error"

You may just want to clarify, say "The following is for your information, should you find the need to manually update the database, etc."

Hollanda 02-22-2007 07:11 PM

It's working after a remove of the previous version!

Tralala 02-22-2007 07:14 PM

Quote:

Originally Posted by Caiman (Post 1188300)
Love it, seems to work fine but I keep seeing this in whosonline;

Unknown Location
/clientscript/ncode_imageresizer.js?v=3

^Seems to show up whenever a user has clicked on an image and expanded it. As far as I can tell, everything is working, just curious as to why it shows users viewing this location.

Quote:

Originally Posted by Spleasure (Post 1188357)
That's strange. At a forum of mine where this mod is also used I can't see this behaviour. Does anyone else have this problem?

Just checked this myself (briefly) but didn't see that behavior... WOL reported the user was reading that particular thread, as usual...

Smoothie 02-22-2007 07:30 PM

Quote:

Originally Posted by Tralala (Post 1188507)
I thought it was pretty clear, the message says "This is not an error"

You may just want to clarify, say "The following is for your information, should you find the need to manually update the database, etc."

If you re-read post 379 you'll see I did mention that. It just seemed rather odd what I saw after clicking import. If the proper queries weren't executed during the install, I would think it's a problem with the installer, not the end user. It's either installed completely or it's not. I just wanted to mention this so members who install would be aware of this, as it's something I've never experienced before.

Spleasure 02-22-2007 07:33 PM

It could be that the MySQL user on which vB is running does not have ALTER permission to the database.

Smoothie 02-22-2007 07:37 PM

Quote:

Originally Posted by Spleasure (Post 1188542)
It could be that the MySQL user on which vB is running does not have ALTER permission to the database.

I'm not denying some people have issues altering the DB, but it should be in the instructions, not in the import/install script. It's confusing, because I wasn't 100% sure the thing installed correctly.

I would also like to mention this is a wonderful mod and I appreciate all the hard work you have put into it. It works beautifully.

Spleasure 02-22-2007 07:43 PM

Quote:

Originally Posted by Smoothie (Post 1188548)
I'm not denying some people have issues altering the DB, but it should be in the instructions, not in the import/install script. It's confusing, because I wasn't 100% sure the thing installed correctly.

I would also like to mention this is a wonderful mod and I appreciate all the hard work you have put into it. It works beautifully.

What I'm going to do (and should have done) is checking after executing the query if the database is OK. If it is, I should not print anything.

Caiman 02-23-2007 02:54 PM

Alright, apparently I diagnosed my problem incorrect, it seems to be a conflict with vBadvacned. The issue I posted about the unknonw location showing in whosonline has nothing to do with someone viewing a thread with images in it, rather... whenever anyone is looking at my vBa index or a vBa page, I see the;

Unknown Location
/clientscript/ncode_imageresizer.js?v=3

In whosonline. Any idea why this might be the case, I would assume it shouldnt interact with or intefere with vBa in anyway?

Spleasure 02-23-2007 03:30 PM

Quote:

Originally Posted by Mike-D (Post 1189090)
It's been almost 3 weeks since I tried to install your hack. The latest version won't works, but this RC4 works, except some things. 1st of all: A damn good hack. That what I've been searched for a long time. Thank you for all, Spleasure ;).

In past versions I relied on the per version installation code functionality of vBulletin. Either I misunderstood this functionality or something else went wrong, but I now just use one installation code. The SQL error you give is related to an old version. Please uninstall everything and reinstall the latest version to get rid of everything. Perhaps you can give me the version number of the version you had before so I can test how upgrading between these two versions goes and I can try to improve this.

Quote:

Originally Posted by Caiman (Post 1189099)
Alright, apparently I diagnosed my problem incorrect, it seems to be a conflict with vBadvacned. The issue I posted about the unknonw location showing in whosonline has nothing to do with someone viewing a thread with images in it, rather... whenever anyone is looking at my vBa index or a vBa page, I see the;

Unknown Location
/clientscript/ncode_imageresizer.js?v=3

In whosonline. Any idea why this might be the case, I would assume it shouldnt interact with or intefere with vBa in anyway?

vBAdvanced compatibility is something I will look into in the near future. I will take this report into account then.

Spleasure 02-23-2007 04:18 PM

If you use the RC1 database schema you will get problems, because is has changed in the meantime. As I said, I will look into the upgrade problems. I will not go back to the old method, that's for sure.

Tralala 02-23-2007 08:10 PM

Quote:

Originally Posted by Mike-D (Post 1189178)
Oh I forgot the most important...

Mark as Installed + Nominated for MOTM

The first post (and readme) also mention another way to thank Spleasure. :) A few bucks via PayPal is how I showed my thanks, for the best hack to come along in a while... along with great support and responsiveness! Thanks again, Spleasure!

Spleasure 02-24-2007 06:39 AM

I have tried all kinds of upgrade scenario's and I can't reproduce the errors. Mike-D: can you tell me which versions you had installed? In which order did you upgrade?

digital3 02-25-2007 05:41 PM

Why is it working for my members with FireFox but not with IE? *sighs* Why can't anything ever be foolproof?

lauxanh 02-25-2007 07:44 PM

Great Mod,

Improve the board look alot ;)

Spleasure 02-25-2007 08:00 PM

Quote:

Originally Posted by digital3 (Post 1190483)
Why is it working for my members with FireFox but not with IE? *sighs* Why can't anything ever be foolproof?

I visited that URL in Internet Explorer 6 and it works for me. Please contact me by IM so we can fix this bug.

futuredood 03-01-2007 10:32 AM

does this work with 3.6.4? if so, why not mention it in the original post?

Spleasure 03-01-2007 12:48 PM

Quote:

Originally Posted by futuredood (Post 1193235)
does this work with 3.6.4? if so, why not mention it in the original post?

Yes, it works with 3.6.4. It actually works with 3.6.0 and up, it's a little unclear. But if you keep in mind that there isn't much difference between 3.6.x and 3.6.y (x != y), just bugfixes, then this is clear automatically.

Caiman 03-01-2007 02:01 PM

I've fixed the issue I was having- to some extent, seems it was actually a result of a mod_rewrite rule in my htaccess (which redirects all incorrect URLs under my domain to the homepage). But that means something in this plugin was causing vBa to request the aforementioned script url. Eitherway, thanks again this is a really great and appreciated addition to my board.

Maksa 03-01-2007 04:08 PM

really cool :) i loved it

nhdriver4 03-02-2007 01:24 PM

Newest version (RC4) confirmed working with 3.6.5. However, the update seems to have broken the images from being resized in vBadvanced CMPS.

Thanks for the update!!

Stifmeister2 03-02-2007 02:11 PM

Great work mate. :) Just voted for MOTM.

Fred. 03-03-2007 03:16 PM

Nice mod!

i got one problem.

If the image url contains %20 it don't work.

Like this

Fotos%20US%20&%20Hawaii/DSC03131.jpg

is there a workaround?

da420 03-03-2007 03:17 PM

^^I've noticed that same thing...

mandy71480 03-05-2007 10:23 AM

Quote:

Originally Posted by da420 (Post 1194896)
^^I've noticed that same thing...

Yup, it's been crashing my browser, too!

Smoothie 03-05-2007 01:05 PM

What browsers are you guys using?

Fred. 03-05-2007 02:56 PM

Quote:

Originally Posted by Smoothie (Post 1196224)
What browsers are you guys using?

I use Firefox 2.0 (the real browser) :D
With IE 6.0 the image is not resized on my board. :confused:

Tralala 03-05-2007 11:36 PM

Quote:

Originally Posted by Fred. (Post 1194893)
Nice mod!

i got one problem.

If the image url contains %20 it don't work.

Like this

Fotos%20US%20&%20Hawaii/DSC03131.jpg

is there a workaround?

Can you post an example on your site for others to test?


(Reason I ask is, I couldn't recreate the problem.)

I tested the %20 thing over here on my Mac, with Safari, and vBulletin 3.6.4. Also tested Camino and Firefox 2.

Seems to me like images that have %20 in the name don't load in browser pages, period, even if you remove vBulletin from the equation. So let's assume we are talking about images that actually have a SPACE in the name (which as we know, sometimes translates in the associated URL to a %20.)


With an image called (and typed into the vBulletin post within IMG tags as) "play ground.JPG" (with a space) it displayed fine and Image Resizer worked normally.

With the same URL typed into the post as "play%20ground.JPG," the picture did not display, all I saw was the link/URL.

But that's because I had Allow Dynamic URL for [IMG] Tags turned OFF in my AdminCP. With it ON, both versions displayed properly, with Image Resizer in effect.

So it seems to me, at least, that it's working fine... at least on my Mac with the three major browsers.


All times are GMT. The time now is 06:47 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01931 seconds
  • Memory Usage 1,836KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (18)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete