vBPunch v1.2 - A Quick Warning System

[Alan @ CIT]

If Upgrading from version 1.1, upload all of the files in the Zip, making sure that they overwrite the old ones, then install the product XML.

If upgrading from version 1.0, please follow the instructions in the install guide in the Zip file.

Changelog
Version 1.2

Clicking "Cancel" on the extra text prompt means that the PM will not be sent
Adding an option to display a confirmation popup when the PM has been sent
Fixed a bug with usergroup permission checking (thanks Osmosis)Version 1.1

Added a global on/off switch for vBPunch
Added the ability to add/remove reputation points when punching
Added usergroup permissions - you can now choose which usergroups are allowed to use vBPunch
Now includes 3 "Punch User" images as well as the text linkWhat is vBPunch?
vBPunch is a quick way of sending a warning PM to a user, based on a post they have made.
It adds a link to the postbit called "Punch User". When an admin clicks this, vBPunch pops up a textbox letting the admin type a reason (if they wish, it's optional), then it sends the user a PM.

What makes vBPunch so special then???!?
The useful thing about vBPunch is that it does it all in the backgorund using Ajax. That means, no popup windows, no page refreshes, nothing. All the admin does is click the "Punch User" link, enter a reason if needed, then continues reading the thread / post, without being interupted.

Installation
Please read install.html located in the zip file

Un-installation
Please read install.html located in the zip file. Please ensure that you delete the uploaded files, before un-installing the product in the vBulletin AdminCP, otherwise you will recieve errors when you edit a usergroup.

-----------------------------------------------------------------

Important: Unfortunately, my leased vBulletin licence has now expired, and I won't be renewing it until September which means I will be unable to reply to this thread, or update this mod until then. I'm hopeful that the great vBulletin.org community will step in to answer any questions in my absence though :) See you all in early September! :D

[Hawkbizkit]

OMG this is the best hack on the vborg Clicks install w00tage Alan-CIT you rock.

[Guest190829]

* Guest190829 punches Alan @ Cit in the face

:D

Great job, can't wait to see this AJAX-licious modification.

[Alan @ CIT]

Forgot to mention, vBPunch uses 4 phrases, all in the GLOBAL section, and all begining with vbpunch_ so they should be easy to find.

The PM message that is sent is vbpunch_warning_text if you wish to change it

[Bad Bunny]

lol This is awesome. I think my forum would actually really like to do this to each other. LOL

How would I go about making it so different usergroups can punch someone?

[Azhrialilu]

LOL funny, I like it :D

[Hawkbizkit]

yes in the plugin vBPunch : Template conditional checks change this line:
else if (can_administer())
To:
else if (in_array($vbulletin->userinfo[usergroupid], array(5,6,7,9)))
just add the usergroups you want to the array.

Also edit vbpunch.php on line 25:
if (!can_administer())
With this:
if (!in_array($vbulletin->userinfo[usergroupid], array(5,6,7,9)))

[Alan @ CIT]

Good idea Hawkbizkit, I'll add usergroup permissions in the next release :)

[Cyricx]

Wow this could be a great basis for someone to use to rewrite the vbpager system with.

Using AJAX for that would be awesome too.

Nice work Alan! :), I may use this code a lil differently but it's definately extremely useful :)

[memorex]

Good idea Hawkbizkit, I'll add usergroup permissions in the next release :)

Can't wait for the next release :banana:

[jugo]

LMAO...This is why I love this Community. Because even in jest we can produce some good stuff.

Awesome work.

Hey, if I change some of the Phrases can I make it a positive thing...like "The Admin" kisses (pulling name out of a hat) amykhar in the lips". or something like that?

Also, it would be a cool addon if this added or took away rep points.

BTW: INSTALLED!!!

[Alan @ CIT]

Thanks for the good comments guys :)

Jugo: I'll make the add/remove rep points an option in the next version.

[Bad Bunny]

yes in the plugin vBPunch : Template conditional checks change this line:
else if (can_administer())
To:
else if (in_array($vbulletin->userinfo[usergroupid], array(5,6,7,9)))
just add the usergroups you want to the array.

Also edit vbpunch.php on line 25:
if (!can_administer())
With this:
if (!in_array($vbulletin->userinfo[usergroupid], array(5,6,7,9)))

Yes! I need to go gold, then my users will be spurred on to participate more as their love to punch each other in the face will be encouraged! YES!

[utw-Mephisto]

I like that addition, however, I rather moved it on the bottom of the post rather on the top ... I guess a button would be cool too rather than simple text (gonna make one soon myself).

Another idea : Instead of a link rather a drop down menu entry (Moderation) where you simply tick the post u want to punch ..

[Alan @ CIT]

Hi Mephisto,

Changing it to a button is on my todo list, and it can be placed anywhere on the postbit, just move it about :)

As for the dropdown, I thought about doing this, but it would mean the admin would have to tick the post, scroll down, pick Punch from the dropdown, enter the reason, then scroll back up and carry on reading. Or, they would tick multiple posts, scroll down and pick Punch from the menu, then have to enter x amount of additional text to add to the PM's (if they wanted), and all this just seemed like a lot of hassle comapred to the 2 click system at the moment.

[utw-Mephisto]

Hi Mephisto,

Changing it to a button is on my todo list, and it can be placed anywhere on the postbit, just move it about :)

As for the dropdown, I thought about doing this, but it would mean the admin would have to tick the post, scroll down, pick Punch from the dropdown, enter the reason, then scroll back up and carry on reading. Or, they would tick multiple posts, scroll down and pick Punch from the menu, then have to enter x amount of additional text to add to the PM's (if they wanted), and all this just seemed like a lot of hassle comapred to the 2 click system at the moment.

Ok, point for you :)

[jesus likes pie]

Alan, is this why you asked me to count my rows in phpmyadmin over at #vbfans about 2 weeks ago? (I'm ATI4EVER! on vbfans).

eh?

Anyways, lmao, this looks awesome but does it really "warn" as in after X ammount of warnings the user gets banned?

I would really like to see a full wrning system that uses AJAX.

[jesus likes pie]

To add to my last post (editing sucks without Ajax :P), there should be an option to just "punch" and one to actually warn. So punching would be for little stupid things that kinda break forum rules or are just stupid posts that make no sense, and another one punches AND adds a "warn", and after say, X ammount of warns the user gets banned for X ammount of days.

Ideally you should be able to change these values through the admincp. But this would then be a full warning system that is probably harder to do.

Anyways Alan, if you do this, I'll kiss your feet.

See ya at #vbfans!

[Alan @ CIT]

lol - hey ATI mate,

I was asking for the number of rows in your threadrate table as I'm working on a rating system for a different project and wanted to see how well vB's performed on a big forum :D

At the moment, this isn't really what you'd call a real warning system (points / bans / etc), all it does is send a PM to the user with some pre-set text + whatever additional text you send. At the moment it says something along the lines of "You have been warned for this post, pleae follow the forum rules when posting"...etc - this can be changed in the Phrase manager though.

I didn't plan on adding points / bans / etc to vBPunch, but I might write another hack based on it that works as a proper warning system.

I'll see what I can do bud :)

[jesus likes pie]

Alright.....

now join #vbfans and we can talk real time :D

[Alan @ CIT]

Add me to MSN or GTalk mate - awagstaff@gmail.com for both, or I'm in #vborg (^^^ chat link up there)

[Dan]

Really nice :D I like it

[Hawkbizkit]

here is a little quick button for people with dark backgrounds

upload the fist to your images/buttons folder for your style
in your postbit template you use

Find: <a href="#" onClick="do_punch('$post[userid]', '$post[postid]'); return false;">$vbphrase[vbpunch_punch_user]</a>
Replace with: <a href="#" onClick="do_punch('$post[userid]', '$post[postid]'); return false;"><img class="inlineimg" src="$stylevar[imgdir_button]/fist.gif" alt="$vbphrase[vbpunch_punch_user]" border="0" /></a>
this is just a quick fix to remove the text link i'm sure Alan-CIT will use a better one for the next release of the hack...also thanks Alan-CIT for all your hard work this hack is great

[Anette]

Lovely. Thank you! :D

[Alan @ CIT]

Thanks Hawk, I'd like to add the button into the next release if you'll allow me mate :)

I'm away Sunday, but will catch you on IRC on Monday at some point :)

Also, thanks to all those who have installed vBPunch so far, I've started adding a few new features for the next release, and all being well, should have it finished by next Friday.

[csidlernet]

very cool thanks
/me installs

[rb290]

it did not work for me.
i installed it perfect too
i have vB 3.5
anyone know whats the problem ?

[lamilein]

* lamilein loves this one :D

* lamilein clicked install :D

[Bad Bunny]

it did not work for me.
i installed it perfect too
i have vB 3.5
anyone know whats the problem ?

You probably didn't install it perfect. It works for everyone but you? This isn't a very realistic assumption. Perhaps you can share any errors or other clues with us, so we can see what exactly doesn't work.

I stopped reading minds earlier this year, so I need some help to know what your problem is. (sorry if my post is punchy, I'm not trying to be rude, I'm just silly right now)

[Alan @ CIT]

it did not work for me.
i installed it perfect too
i have vB 3.5
anyone know whats the problem ?

Unfortunatly, that doesn't give us a lot to go on :)

What exactly doesn't work? Do you recieve any Javascript or PHP errors?

Are you certain that you uploaded the files to the correct places?

[Hawkbizkit]

i figured i would go back in and fix the fist and make a PSD of it with the dark themed version and the light themed version if anyone wants it... Cheers

[Alan @ CIT]

Thanks bud, very handy :)

Just to let everyone know, I haven't forgotten about vBPunch, the next version is half done, just needs finishing up. I've been a bit distracted with 2 other hacks I'm working on :)

[rb290]

I put everything in the right place and I dont see the vbpunch in peoples post

[Alan @ CIT]

pb290: Revert the postbit template back to it's original, and try the change again.

[akanevsky]

Screenshot please?

[Alan @ CIT]

Screenshot of what? It's just a link that says "Punch User"... :)

Screenshot:

Punch User

:)

[u4ea]

Awesome tool!

How can I set this so mods can use as well as admins?

[Alan @ CIT]

u4ea: Follow the instructions here https://vborg.vbsupport.ru/showpost.php?p=781531&postcount=7

[u4ea]

u4ea: Follow the instructions here https://vborg.vbsupport.ru/showpost.php?p=781531&postcount=7


Where do I state what user groups in the code below... SOrry im such a newbie...

yes in the plugin vBPunch : Template conditional checks change this line:

PHP Code:
else if (can_administer())


To:

PHP Code:
else if (in_array($vbulletin->userinfo[usergroupid], array(5,6,7,9)))


just add the usergroups you want to the array.

Also edit vbpunch.php on line 25:

PHP Code:
if (!can_administer())


With this:

PHP Code:
if (!in_array($vbulletin->userinfo[usergroupid], array(5,6,7,9)))

[Alan @ CIT]

In this line:

if (!in_array($vbulletin->userinfo[usergroupid], array(5,6,7,9)))

The numbers in that line represent usergroup id's. Replace them.

Alterantivly, wait a day or so, and the next version of vBPunch will be released which will make it easier to do this.

[The Realist]

updated yes but where is the actual hack, cos its not in the 1st post?

[Alan @ CIT]

2 minutes, I'll upload it

[Alan @ CIT]

Sorry folks, last minute bug has reared it's ugly head - just fixing now - 5 more minutes...

[Alan @ CIT]

ok bug (hopefully) fixed :)

v1.1 is now available for download

[Hawkbizkit]

sweet new version is great.... :)

[OsMoSiS.it]

Personally, I don't like the punch starts even if Cancel is clicked on prompt window... if I click erroneously the user gets punched because I can't undo my action... that's not good for me, not intuitive ("cancel" usually means "cancel action"). I've changed "do_punch" to suit my needs: if (message != null) then punch else don't do anyting :)

I'll add also an alert box to confirm that punch was sent (no errors) because some browsers (eg. firefox by default) don't allow status bar text changing via javascript :)


Keep testing it... btw good idea :)

[OsMoSiS.it]

Security checks should be hardened... I was able to send a punch even if I'm not logged in. Try to write the url with the querystring and the user receive a PM from a "non registered" user...

http://[forum_root]/vbpunch.php?punch=[YourUserId]&postid=1&warning=message

A workaround that seems to work (but I don't think is the right way):

In vbpunch.php replace:
if ((!$vbulletin->options['vbpunch_enabled']) or (!$vbulletin->bf_ugp['vbpunch']['can_punch']))

with:
if ((!$vbulletin->options['vbpunch_enabled']) or (!($permissions['vbpunch'] & $vbulletin->bf_ugp['vbpunch']['can_punch'])))

[Alan @ CIT]

Osmosis: Thanks for pointing that out, I forgot to add "$permissions['vbpunch']" in vbpunch.php - an oversight on my part :) I'll fix it in the next release.

[rb290]

hey I uninstalled everything cause I dont think it worked for me so now when I went to edit a usergroup it said this:

"Database error in vBulletin 3.5.0:

Invalid SQL:
UPDATE usergroup SET

### UPDATE QUERY GENERATED BY fetch_query_sql() ###
`title` = 'Administrators',
`description` = '',
`usertitle` = 'Administrator',
`opentag` = '<strong><font color=\"#3A69DE\">',
`closetag` = '</font></strong><strong><font color=\"#FF0000\">_BOSS</font></strong>',
`passwordexpires` = '180',
`passwordhistory` = '360',
`forumpermissions` = '470810623',
`genericpermissions` = '255852479',
`attachlimit` = '0',
`pmquota` = '50',
`pmpermissions` = '3',
`pmsendmax` = '5',
`calendarpermissions` = '63',
`wolpermissions` = '31',
`adminpermissions` = '3',
`genericoptions` = '31',
`profilepicmaxwidth` = '100',
`profilepicmaxheight` = '100',
`profilepicmaxsize` = '65535',
`avatarmaxwidth` = '100',
`avatarmaxheight` = '100',
`avatarmaxsize` = '10000',
`vbpunch` = '0'
WHERE usergroupid=6;

MySQL Error : Unknown column 'vbpunch' in 'field list'

[rb290]

its bringing up an error when I save and it says unknown column 'vbpunch in 'field list', how do I remove that ?

[rb290]

some help please ^

[Suiko Jin]

Awesome sounding hack. I might install if my board gets bigger.

[Guest190829]

Just checked, and I have 1.0 installed. Timeeee to upgrade!

[Alan @ CIT]

rb290: Did you remember to delete the bitfield_vbpunch.xml file from the /includes/xml/ directory?

Danny: 'bout time :D

[TyleR]

rb290: Did you remember to delete the bitfield_vbpunch.xml file from the /includes/xml/ directory?

im getting the same error and yes i already deleted that file.

[Alan @ CIT]

For anyone getting the error when editing usergroups after uninstalling, please rebuild the bitfields by following the instructions here: https://vborg.vbsupport.ru/showthread.php?t=92592

For future un-installers, please remove the files uploaded (in particular bitfield_vbpunch.xml), before un-installing the product from the AdminCP.

[SuperFly]

nevermind read above post :)

[subnet_rx]

the upgrade instructions say to remove our postbit changes before installing. Is that really necessary to upgrade from 1.1 to 1.2?

[Alien]

The previous version worked great, this new 1.2 version gives me problems. Using vBulletin 3.5.1

I re-uploaded all new files. Re-imported the product XML, set to overwrite old one.

Still says version 1.1 in the product page. I even re-build bitfields, and replaced the html in the templates again. Every single thread becomes completely unreadable with an error that states:

Parse error: parse error in /pathtomyforums/showthread.php(96) : eval()'d code on line 28

Unable to add cookies, header already sent.
File: /pathtomyforums/showthread.php(96) : eval()'d code
Line: 28

[rb290]

i get this error when I go into a thread:

"Parse error: parse error, unexpected $ in /home/thug/public_html/showthread.php(96) : eval()'d code on line 220

Warning: Cannot modify header information - headers already sent by (output started at /home/thug/public_html/showthread.php(96) : eval()'d code:220) in /includes/functions.php on line 2342

Warning: Cannot modify header information - headers already sent by (output started at /home/thug/public_html/showthread.php(96) : eval()'d code:220) in /includes/functions.php on line 2349"

[phonexpo]

I have this error "showthread.php(96) : eval()'d code on line 28" any ideas ?

[Alan @ CIT]

Hey all,

For those experiencing the error "Parse error: parse error in /pathtomyforums/showthread.php(96) : eval()'d code on line 28" please install the attached, updated, product XML, ensuring that you set "Allow Overrite" to yes.

This should fix the problem.

Thanks,
Alan.

[phonexpo]

Hey all,

For those experiencing the error "Parse error: parse error in /pathtomyforums/showthread.php(96) : eval()'d code on line 28" please install the attached, updated, product XML, ensuring that you set "Allow Overrite" to yes.

This should fix the problem.

Thanks,
Alan.

Hi Alan,

Yes that fixed it. Thank you very much. :-)

[Boofo]

Is there a way to add more than one message to this so you can just tick which message you want sent? Like more than one default message.

[Alan @ CIT]

Boofo,

Not easily in it's current state. I'll look into adding that feature into the next version.

[Alien]

Yeah that would be a cool addition.

Btw, bug fixed with that last file! Thanks so much!

[Juzmi]

Ah works now :)

Thanks :)

[Alan @ CIT]

Juzmi: Good to hear :)

[Juzmi]

Okay when i send a user a punch.. it does not show a new PM message.... but if you go into your PM box it shows it.. any reason why it would do this>

[Alan @ CIT]

Juzmi: Sorry, didn't see your message - I'll look into this.

Everyone: Anyone got any feature requests for the next version? I plan on starting work on it next week.

[puertoblack2003]

Okay when i send a user a punch.. it does not show a new PM message.... but if you go into your PM box it shows it.. any reason why it would do this>

yea same here ran a test on my test user , went into pm and found all of the punches...lol i'll wait for the fix.... :ermm:

[coolgus]

Juzmi: Sorry, didn't see your message - I'll look into this.

Everyone: Anyone got any feature requests for the next version? I plan on starting work on it next week.

I believe that this mod only misses the options to choose in how many warnings the user will be banned permanently or for a short time. Sure I can use the other mod but I like simplicity and of course AJAX :-)

[eXaulz]

Very nice modification, indeed. I modified this modification a bit, and this is what I got:

A 'Punch X' in the user menu

If you want to do this, find the following in the postbit / postbit_legacy template:

<if condition="$post['userid'] AND $show['member']">
<tr><td class="vbmenu_option"><a href="profile.php?$session[sessionurl]do=addlist&amp;userlist=buddy&amp;u=$post[userid]"><phrase 1="$post[username]">$vbphrase[add_x_to_buddy_list]</phrase></a></td></tr>
</if>

Add after:

<if condition="$can_punch">
<tr><td class="vbmenu_option"><a href="#" onClick="do_punch('$post[userid]', '$post[postid]'); return false;"><phrase 1="$post[username]">$vbphrase[punch_x_user]</phrase></td></tr>
</if>

Add the phrase:

punch_x_user
Punch {1}

Done! :)

By the way, to the developer:

Bug? My PM count doesn't get updated when the PM is sent (nor do I receive the new pm notice).

[Alan @ CIT]

Hi,

I believe that this mod only misses the options to choose in how many warnings the user will be banned permanently or for a short time. Sure I can use the other mod but I like simplicity and of course AJAX :-)

Writing a full fledged Warning system based of vBPunch has always been on my todo list, and still is. Unfortunatly, there are many many things above it on my todo list :D


Bug? My PM count doesn't get updated when the PM is sent (nor do I receive the new pm notice).


Thanks, I've added it to the vBPunch todo list :)

[AWI]

By the way, to the developer:

Bug? My PM count doesn't get updated when the PM is sent (nor do I receive the new pm notice).

Same here, installed it on 3.5.2...great hack man

[puertoblack2003]

Okay when i send a user a punch.. it does not show a new PM message.... but if you go into your PM box it shows it.. any reason why it would do this>


any updates with the problem when sending pm's

thanks

[Alan @ CIT]

Sorry, but I've been unable to reproduce this.

I've done various tests on my forum (3.5.2) and it all works fine. When I punch a user, they recieve the PM popup if they have it enabled, and recieve an e-mail about the new PM if they have that enabled.

Thanks,
Alan.

[MissKalunji]

n e one has a couple screen shot or a demo ? i'de love to know how it looks

[puertoblack2003]

Sorry, but I've been unable to reproduce this.

I've done various tests on my forum (3.5.2) and it all works fine. When I punch a user, they recieve the PM popup if they have it enabled, and recieve an e-mail about the new PM if they have that enabled.

Thanks,
Alan.

will, i checked that out and it's activated so i did a test run it won't show either the pop-up or it won't show that that the user received a pm upon using the vbpunch..

any idea's :ermm:

[GSM_electronic]

My board's running on vb 3.5.2 also, is it possible that I can't see 'punch' icons at all?

They're shown in the 'preview' of template, but not at the forum...

[eXaulz]

Hey. A few suggestions.

More Group Permissions
Can Be Punched? Yes | No
Can View Punch History? Yes | No (see below)
Maximum Number of Punches to Receive a Day: [________________] (field)
Maximum Number of Punches to Give a Day: [________________] (field)

More Features
Punch History: Keeps a detailed record of who punched x user (probably something like vbpunch.php?do=history&uid=xxx), along with date, reason, etc.

That's all I can think of right now.

[GSM_electronic]

My board's running on vb 3.5.2 also, is it possible that I can't see 'punch' icons at all?

They're shown in the 'preview' of template, but not at the forum...


My excuse to all...

I was editing postbit template all the time..
And I'm using postbit_legacy :)


Everything ok, but I'm not recieving new pm-s popup window...

[Smiry Kin's]

does this warn the person of the post that they was punched on??

[Smiry Kin's]

also installed, tested... PM doesnt send.

[Smiry Kin's]

Ok PM sends, but its like the PM system doesnt relise its there, doesnt say new PM, yet in PM control panel,. it has them there! using version 3.5.2!

[Andyrew]

Ok PM sends, but its like the PM system doesnt relise its there, doesnt say new PM, yet in PM control panel,. it has them there! using version 3.5.2!

Same for me in 3.5.2

[Bad Bunny]

Do you refresh the page? It uses technology that sends the PM without refreshing the page, so you will not know it is there until you go to a new page or refresh.

[Smiry Kin's]

yeh.... i had to check in my usercp to find out it does this :S

[Bad Bunny]

Keep in mind that it will not function like this under normal usage. It is actually very rare that you will be "punching" yourself. Why would you give yourself a warning?

Anyway, a refresh of the page would tell you that there was a PM.

[Smiry Kin's]

Keep in mind that it will not function like this under normal usage. It is actually very rare that you will be "punching" yourself. Why would you give yourself a warning?

Anyway, a refresh of the page would tell you that there was a PM.

as stated before..


Ok PM sends, but its like the PM system doesnt relise its there, doesnt say new PM, yet in PM control panel,. it has them there! using version 3.5.2

[Alan @ CIT]

Hi all,

As of right now, I'm going away on holiday for 2 weeks :)

I will answer any questions, fix any bugs, deal with any comaplaints, and test any suggestions when I return in January :)

Happy Holidays all!

Alan.

[GSM_electronic]

Happy Holiday to You too, mate, and thx for every support ;)

[Wildthinks]

Happy Holiday to You too, mate, and thx for every support ;)

same problem with not pm popup 3.52 german

Awesome hack - installed...
Thomas

[onkel.joi]

unfortunately on my 3.5.2 it is also not have pm popup . Would there be any fix for that?

[Snake]

Cool I have installed this hack.

[onkel.joi]

Any news on this hack?

[betterman]

I receive no notice that a PM was received. Tested by punching a test user account, then loggin in as that user. PM is there, but no notice.

[GSM_electronic]

Maybe ajax is making trouble?

[onkel.joi]

Maybe ajax is making trouble?
I was thinking the same.

I am relly want to get this hack fixed, because this one is very usefull.

[Alan @ CIT]

Hi all,

I have now returned from my holidays, hope you all had a good <insert-seasonal-holiday-name-here> :)

I'll start answering any questions, fixing any bugs, and adding any new features next week, but I've got a lot of hacks to update, so it might not be immediate :)

Thanks,
Alan.

[Alan @ CIT]

Also, with regards to the PM popup problem - https://vborg.vbsupport.ru/showpost.php?p=848482&postcount=77 - I can't reproduce it at all, so I can't fix it :/

[onkel.joi]

Also, with regards to the PM popup problem - https://vborg.vbsupport.ru/showpost.php?p=848482&postcount=77 - I can't reproduce it at all, so I can't fix it :/
Very strange. Because not only me have that problem. And also the problem is that forum is not recognizing PM at all!!! It is not even showing that there is any PM, forum shows that there is 0 PM received, after 10 refreshes nothing change. Only when I go in PM forlder I can see it there, but that is the only way to see it. :disappointed:

[exegete]

Very strange. Because not only me have that problem. And also the problem is that forum is not recognizing PM at all!!! It is not even showing that there is any PM, forum shows that there is 0 PM received, after 10 refreshes nothing change. Only when I go in PM forlder I can see it there, but that is the only way to see it. :disappointed:

I have the exact same problem - vB 3.5.3.

[onkel.joi]

Any fixes?

[coffeefix]

Very strange. Because not only me have that problem. And also the problem is that forum is not recognizing PM at all!!! It is not even showing that there is any PM, forum shows that there is 0 PM received, after 10 refreshes nothing change. Only when I go in PM forlder I can see it there, but that is the only way to see it. :disappointed:


same here.

[onkel.joi]

OK I uninstalled this hack because PM is not working and its looks like nobody would fix it. Well too bad, because this is very nice hack if fix PM.

[zylstra]

Alan,

Concerning the PM popup problem, does your unread PM count increase upon a warning? I think you may see that it won't. Those of us who have the PM popup option turned off will never see an indication of a new PM. Try turning off your PM popup option: AdminCP -> vBulletin Options -> Private Messaging Options -> Instant Messaging Support - Check for New Private Messages.

Maybe this will help you solve the problem.

Thanks!

[coffeefix]

With or without the pop-up option- it still registers 0 unread pm's, yet when you go to your pm box, the unread pm is there.

[brent_strong]

Hey, quick request here, probably 75% of people on here could help me out.

I have this hack installed and working beautifully. Now, I would like to change it up a bit so that it will check in a different directory, based on which style is being used. I know this is possible, since the Multiquote hack I installed does this. I think it has something to do with using the $style variable or something similar.

Basically, instead of having the punch image uploaded to /images/vbpunch, I would like to have it be something like /images/$styleid/vbpunch so that I can have both a light colored and dark colored image for the punch button.

Also, if there is any interest, a friend on my site has made a new punch icon to go with a dark theme (Afterdark from vbstyles, specifically). I'd be happy to attach that for anyone who would use it.

[brent_strong]

I also now have a button that matches Aria (vbstyles.com) well, again, if anyone wants it.

[brent_strong]

<!-- Start vBPunch -->
<if condition="$can_punch">
<a href="#" onClick="do_punch('$post[userid]', '$post[postid]'); return false;"><img src="$stylevar[imgdir_misc]/punch.gif" border="0" alt="$vbphrase[vbpunch_punch_user]" /></a>
</if>
<!-- End vBPunch -->

That should tell the mod to search in the style/misc directory for the Punch image. Seems to work for me!

[akanevsky]

Does this hack also ban users or no?

[phonexpo]

Does this hack also ban users or no?

Only if you use a right hook with a left upper-cut. :D

[The Chief]

Only if you use a right hook with a left upper-cut. :D

lol, good point ;)

[Skyline_GT]

any fix on this problem where it doesn't show in the pm number..
but it is in the pm box..

[akanevsky]

well I hope Alan can either implement the uppercut or allow me to implement it as an add-on.

[Smiry Kin's]

is this ok for 3.5.2 and 3.5.3?

[Skyline_GT]

well I hope Alan can either implement the uppercut or allow me to implement it as an add-on.

do you have a clue how to fix the pm problem?

[Stone Cold 3:16]

Ahaha! Im about to bust alot of users :p

Thanks.

[Stone Cold 3:16]

Wait, this is weird. When i press the punch, it just brings me to the top of the page...

[Renee]

I installed it on a new board with no any hacks and it sends me on punch a new pm.

Now I installed it on the publish board, which is hacked to death, it don't works :D

But I changed in the vbpunch.php on

// No errors, so send the PM
$pm->save();

I add before this:

$pmpunch = "UPDATE " . TABLE_PREFIX . "user SET pmtotal=pmtotal+1, pmunread=pmunread+1 WHERE userid=" . $vbulletin->GPC['punch'] . "";
$db->query_write($pmpunch);

So it works for me with the pmcount :)

[Oblivion Knight]

I installed it on a new board with no any hacks and it sends me on punch a new pm.

Now I installed it on the publish board, which is hacked to death, it don't works :D

But I changed in the vbpunch.php on

// No errors, so send the PM
$pm->save();

I add before this:

$pmpunch = "UPDATE " . TABLE_PREFIX . "user SET pmtotal=pmtotal+1, pmunread=pmunread+1 WHERE userid=" . $vbulletin->GPC['punch'] . "";
$db->query_write($pmpunch);

So it works for me with the pmcount :)Try this instead:
$db->query_write("UPDATE " . TABLE_PREFIX . "user SET pmtotal+1, pmunread+1 WHERE userid=" . $vbulletin->GPC['punch'] . ");I think that should work.. *scratches head*

[yinyang]

is there a way to track how many times a user is punched? i.e., can you show this in the postbit area?

[Oblivion Knight]

I can't get this to work for me (running 3.5.4)..

Everything seems fine until it comes to "punching" a user, text is added to the prompt and ok is clicked, but the PM is never sent and the confirmation box never pops up.

[Alan @ CIT]

Hi Oblivion Knight,

I've just installed a clean copy of vB 3.5.4 and tested vB Punch and it seems to work fine here.

Anyone else found this hack to stop working on 3.5.4? If so, what other hacks do you have installed?

Thanks,
Alan.

[ElForro]

This hack is great!!! Installed!

Works in 3.5.4

Although, I had to make this (https://vborg.vbsupport.ru/showpost.php?p=900428&postcount=121) change in vbpunch.php in order to show the "new PM"...

[Smiry Kin's]

when i punch a user, it and it sends a PM, it doesnt count as a PM, in the inbox, doesnt say any new PM's but its there.. any help.?

[phonexpo]

when i punch a user, it and it sends a PM, it doesnt count as a PM, in the inbox, doesnt say any new PM's but its there.. any help.?
https://vborg.vbsupport.ru/showpost.php?p=960321&postcount=126

[futuredood]

hey Alan, can we get this to work in the memberinfo?

[powerful_rogue]

Bit of a longshot, but would this work on 3.6.7?